From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10058.outbound.protection.outlook.com [40.107.1.58]) by dpdk.org (Postfix) with ESMTP id 6B0C2239 for ; Tue, 24 Jul 2018 16:37:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ftqEmuzkcQBdE7EgQ/yLifVQYTRCPKT+xlrRbLeZ6LI=; b=biMNZrHpXvupEcRQ7Z8CZa0hWvyjkqJJi7eF9iAFlIv+Ho9J8m1wj2hS96L8Eiwdye2m/OABoA9PrMZVBxqfnV+b0US7J0l3QSxJQfapISI0rwLaKrJ9N2iqVxTwRM5PwXlAmAVQ/53niDa24/1OMG6NrfW7ldCJKB7a5x8j2Ng= Received: from AM0PR05MB4435.eurprd05.prod.outlook.com (52.134.92.20) by AM0PR05MB4114.eurprd05.prod.outlook.com (52.134.90.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Tue, 24 Jul 2018 14:37:24 +0000 Received: from AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::74c6:6add:f439:ffd3]) by AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::74c6:6add:f439:ffd3%4]) with mapi id 15.20.0973.018; Tue, 24 Jul 2018 14:37:24 +0000 From: Mordechay Haimovsky To: Thomas Monjalon , Jasvinder Singh CC: "dev@dpdk.org" , "bernard.iremonger@intel.com" , "reshma.pattan@intel.com" , "olivier.matz@6wind.com" , "cristian.dumitrescu@intel.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d Thread-Index: AQHUInI9WfrVI52/I0681kO64dk53aSePSGAgAATHICAAB6SEA== Date: Tue, 24 Jul 2018 14:37:24 +0000 Message-ID: References: <20180723104425.10090-1-jasvinder.singh@intel.com> <1876510.4y0gDTZx5Q@xps> <1925999.Zqez9Xlb98@xps> In-Reply-To: <1925999.Zqez9Xlb98@xps> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR05MB4114; 6:oBft5LV3pZZFfyUJ7CpDGUbrHgMjPjlAkN2ggx/4mcW85OrwY/4mW8g6Ws8EZPi1CofgErHfbR57g0vTVlJdNq6tW1ITQCwAk1XLkr1gdwpcCwhO0tPupi8duqBQZA7X8OscHbIfX/OcuLGXnnn+j05a7XVD5hJPXEzi+hv92pTi3KcejVohyW6HcJTzak4RZkZXlatW4Mg0qR9PnQrVEs6NcXnMncoCQE7r/Kpt3FU70O36sTu3NrC6P0KCfHbMVVZqt1rL7uDurvijVPbvyQDtjmVGEkEzL94JyW6gd3WZpFYprv+5Z2ouRTkSFu4NjYS1wq3JhxREZ3irSYirz8mUSDXhQwCHA7VX0+unZcK3br+Lv1qGyadQuLVrRsit3xjAlc4dCHs1Gbo1agE2dr9Q4yhdvAAPB4HZvWdYHtTEHCUXjYFK4PyyN/ZMnSy9AOS9N22uvunOW5m0llb1gg==; 5:k91jJVZzZobT+RWnjEn9nOTnZQex+ZSMntPDoFmSkEvU+0b5D/2E3R9nQnf8SjxTzAX8XvDkM+SBD2e81vxtnBP7o915N23bLuMIfphszlXuyq2V6Vjo/SCy5yufoDn/USStHojKjLKEh0KkFUpjwLknZtyBV4ZpFfWZlPTr/iQ=; 7:eIWBI8zsrf+xpqPAHuMHvuMAl6N9/lwhMgBiW2AFKNuYiWJSttirgM9CTFOWAHcffVQZbgPKVkVc1Rgi63hcgAy3u+SETfqXHpxg0c6qTdHRB1bn2shozJsHHbrJGH1/KoBuhiwbPSTHceicX4iKGxQgzBOR1nDk+4b5wIanJ4qKyXpUq2bYeiRsPBSZ5nEVo6NkEXxeaMTy9c4YgqkONOa20mLv48yWWiu8qUVxSIodRdL+S1M4MZYNnD/V0eBo x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2ef3a7e9-c971-4a44-ca81-08d5f172f8ec x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM0PR05MB4114; x-ms-traffictypediagnostic: AM0PR05MB4114: authentication-results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:AM0PR05MB4114; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB4114; x-forefront-prvs: 0743E8D0A6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(39860400002)(346002)(136003)(366004)(13464003)(189003)(199004)(53936002)(33656002)(478600001)(26005)(7736002)(97736004)(55016002)(305945005)(74316002)(2900100001)(5250100002)(68736007)(86362001)(256004)(14444005)(229853002)(102836004)(54906003)(6506007)(316002)(186003)(110136005)(53546011)(2906002)(4326008)(8936002)(25786009)(66066001)(106356001)(5660300001)(76176011)(7696005)(105586002)(486006)(14454004)(446003)(99286004)(11346002)(8676002)(6116002)(6246003)(81166006)(6436002)(3846002)(81156014)(476003)(9686003)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4114; H:AM0PR05MB4435.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: X1dALp2+JFglApQ84gOIg9YCD6whiwXr+PKn6abh8EHy2u3O5duNqHmsu1/JnRoS82FPbGpCBxFtktMy8bbpm8i8+kBATU77ubrTP4R7QKar3Z7FE8lDjjma1nN1V+pLrGyfZW6gQuuzFgjDrN46cD6c/nm37qn4PoEuVJagpUPnoe+F+HOIcwAFkUacS5l2lrTNvzCWfbQffjw0orfOeLFehMNFSGuic1pVNwYJnWV78LwpVb/FiO6kGicO/neFo58Rk34fJtV/+gLlnYvduVhYIR7hQot0YxHdTc1E1RQ420Gak2G7sCbwhL+ZFpQ8BF1IAVLvTJQS0f7CXm7qXNarRGQOPTz9DNOv1LYY4tk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ef3a7e9-c971-4a44-ca81-08d5f172f8ec X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2018 14:37:24.7001 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4114 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 14:37:26 -0000 Even after this fix we still have setups that use netvsc for example, on = which testpmd exits with rte_panic right after loading it even without touc= hing the KBD. I recommend returning the previous prompt routine in test-pmd/cmdline.c and rework the SOFTNIC section there, preferably moving its poll section to= use rte_service in a separate file cleaning the CLI files from PMD-specifi= c implementation. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, July 24, 2018 3:34 PM > To: Jasvinder Singh > Cc: dev@dpdk.org; bernard.iremonger@intel.com; > reshma.pattan@intel.com; Mordechay Haimovsky ; > olivier.matz@6wind.com; cristian.dumitrescu@intel.com > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+= d >=20 > Important note: > testpmd is currently really broken. > We cannot have a RC2 until it is fixed. >=20 >=20 > 24/07/2018 13:25, Thomas Monjalon: > > 23/07/2018 12:44, Jasvinder Singh: > > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission > > > character (EOT) on the empty command line. > > > > Please describe what is the issue and what is the cause. > > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > > > > > Reported-by: Mordechay Haimovsky > > > Signed-off-by: Jasvinder Singh > > > --- > > > app/test-pmd/cmdline.c | 10 ++++++---- > > > lib/librte_cmdline/cmdline.c | 2 +- > > > > It is very suspicious to change the cmdline library. > > If there is a bug in this library, it deserves a separate fix. >=20 >=20