From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60068.outbound.protection.outlook.com [40.107.6.68]) by dpdk.org (Postfix) with ESMTP id 50CC0F72 for ; Wed, 25 Jul 2018 10:53:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4xwG/qwcVVkbt0RB6hui3g0QiyQyINEDc1IoDkmSKDY=; b=rNCMX77l+OjjKiTdkzqJkUrZWAHxBKoUbndJwxn58y3iWmVx8blrSB3Dp4+A8waB9dU1l3E2tBFE+CV+Rhun67J1Zc3qTqRJq5n2mAgtdI8/4vXMzXYM0B7CM3iHG6+Ll2t1P7MWQFItvyvTPXUgjf64ZZXThKkgVy0wPHwfZp4= Received: from AM0PR05MB4435.eurprd05.prod.outlook.com (52.134.92.20) by AM0PR05MB5076.eurprd05.prod.outlook.com (52.134.89.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.17; Wed, 25 Jul 2018 08:53:38 +0000 Received: from AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::74c6:6add:f439:ffd3]) by AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::74c6:6add:f439:ffd3%4]) with mapi id 15.20.0973.022; Wed, 25 Jul 2018 08:53:38 +0000 From: Mordechay Haimovsky To: "Singh, Jasvinder" , Thomas Monjalon , "Dumitrescu, Cristian" CC: "dev@dpdk.org" , "Iremonger, Bernard" , "Pattan, Reshma" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d Thread-Index: AQHUInI9WfrVI52/I0681kO64dk53aSePSGAgAATHICAAB6SEIAAK6kAgAEA24CAAANoAIAABR7w Date: Wed, 25 Jul 2018 08:53:38 +0000 Message-ID: References: <20180723104425.10090-1-jasvinder.singh@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E7792AF@IRSMSX107.ger.corp.intel.com> <1707406.j7eEjrHijo@xps> <54CBAA185211B4429112C315DA58FF6D335DD24E@IRSMSX103.ger.corp.intel.com> In-Reply-To: <54CBAA185211B4429112C315DA58FF6D335DD24E@IRSMSX103.ger.corp.intel.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR05MB5076; 7:lmvTMqQ8j5wFst8Z/irSG34PqIVNlJErCiiSVNj0nv87db6x9odNYwXRm8akk7NP/MNbRa7AuuovJMZfhNv6w2Wn7uUKg8yv1bPn+6ZdjkPnOi7d0fhFFIMMoXgUIwyBNuPhrfy0PiV49fp7EEBMWslAPoEOtHYEw5Gp4YDYzGZ3tf4lXQ35RZLS4zLlYoZd31+VyNZUqaEy4m0ajF1ZcmrumAg5BXJmu8y/X9qzAHvB1vNQ5ivh6+kroDoRDvjp x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: abab91a6-5490-4326-189c-08d5f20c1d36 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM0PR05MB5076; x-ms-traffictypediagnostic: AM0PR05MB5076: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:AM0PR05MB5076; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB5076; x-forefront-prvs: 0744CFB5E8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(346002)(396003)(136003)(376002)(13464003)(199004)(189003)(55016002)(53936002)(68736007)(33656002)(446003)(4326008)(86362001)(6116002)(476003)(305945005)(54906003)(2900100001)(186003)(7736002)(9686003)(11346002)(26005)(106356001)(478600001)(256004)(6436002)(486006)(6246003)(3846002)(5660300001)(110136005)(8936002)(2906002)(14454004)(97736004)(25786009)(99286004)(14444005)(81166006)(5250100002)(93886005)(74316002)(66066001)(102836004)(53546011)(105586002)(8676002)(316002)(76176011)(6506007)(81156014)(229853002)(7696005)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5076; H:AM0PR05MB4435.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: oR+H3nGEtlU2g7OR/1UkB8sbZNtZnpPhhPTWlB84xiJK+HH1UBB5rRYJah99wO+pdICZ/jwwAew37c/SsdthaNszsGTIp+gSM6v/C0uJzTg+hOInbjnvcNBPlNshFm+9nl021pLsi7QnEl0Pfxrvz47CQZzetDAeOAwOcMpYLBsj0edrIdkbmSzqIhLTs7/HUyCfsrNFNRcwUPO8T5szdA47MbZxNtjcscYJviAQqeweqCz4DwWwN3OeJAmnELPZqj6Ist5dE26ydCn2EcV7c9aEKmWtqxrkNtVamWhkHn00E5xA9J+csLzsqyBwxbPpFqnSAYursSaOfON8P8k4kQjvPzr5E6pEHC0EHIkRVbc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: abab91a6-5490-4326-189c-08d5f20c1d36 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2018 08:53:38.5313 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5076 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 08:53:40 -0000 Hi, This issue happens on some of our setups sometimes without even pressing an= y key. I will try to create a minimalistic setup which will show the problem and w= ill be easy to construct by you. Will send you all the details later on today. Moti > -----Original Message----- > From: Singh, Jasvinder [mailto:jasvinder.singh@intel.com] > Sent: Wednesday, July 25, 2018 11:31 AM > To: Thomas Monjalon ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Mordechay Haimovsky ; > Iremonger, Bernard ; Pattan, Reshma > ; olivier.matz@6wind.com > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+= d >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Wednesday, July 25, 2018 9:19 AM > > To: Dumitrescu, Cristian > > Cc: dev@dpdk.org; Mordechay Haimovsky ; Singh, > > Jasvinder ; Iremonger, Bernard > > ; Pattan, Reshma > > ; olivier.matz@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using > > ctrl+d > > > > 24/07/2018 18:59, Dumitrescu, Cristian: > > > From: Mordechay Haimovsky [mailto:motih@mellanox.com] > > > > > > > > Even after this fix we still have setups that use netvsc for > > > > example, on which testpmd exits with rte_panic right after > > > > loading it even without touching the KBD. > > > > > > > > I recommend returning the previous prompt routine in > > > > test-pmd/cmdline.c and rework the SOFTNIC section there, > > > > preferably moving its poll section to use rte_service in a > > > > separate file cleaning the CLI files from PMD-specific implementati= on. > > > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > > > > > Important note: > > > > > testpmd is currently really broken. > > > > > We cannot have a RC2 until it is fixed. > > > > > > > > > > > First, testpmd is not really broken, as only thing that changed is > > > the Ctrl + D > > behavior. I agree this is an issue that we need to fix, as it looks > > that it is breaking some automation scripts for some people. > > > > > > The change in behavior for Ctrl + D exit is caused by replacing the > > > call to > > cmdline_interact() with calling cmdline_poll() in a loop. These two > > approaches should be identical in behavior, but it looks like they are > > not due to some issue in the cmdline library. Jasvinder proposed a > > quick patch, but it looks like something else needs to be fixed in > > cmdline library in order to bring > > cmdline_poll() on parity with cmdline_interact(). Any advice from > > Olivier would be very much appreciated! > > > > > > It is really a bad practice to use cmdline_interact() in testpmd, as > > > it is a > > blocking call that prohibits doing other things on the same thread > > that runs the CLI. Sometimes we need to run other things on the same > > core, e.g. the slow > > softnic_manage() function. > > > > > > Worst case scenario: We can revert the cmdline_poll() back to > > cmdline_interact(), this is a small change, but not the proper way of > > doing things, as this is simply hiding the issue in cmdline library. > > It would also prevent us from testing some Soft NIC functionality. > > > > There are some crashes, even without touching the keyboard. >=20 > Thomas, could you be specific here so that we can reproduce the issues yo= u > are mentioning? Thanks. >=20 > > So yes, we should revert. > >