From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BA83A0597; Fri, 10 Apr 2020 00:20:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADDD01C2EF; Fri, 10 Apr 2020 00:20:34 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2056.outbound.protection.outlook.com [40.107.20.56]) by dpdk.org (Postfix) with ESMTP id 5CF181C2ED; Fri, 10 Apr 2020 00:20:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2D96EmtivQoikifpsZb3Yx840W2onU6U46Lw3TZY+SS3EdfF+j3FyG+3eWcucT3S4be4Mk1OhYad56nKvclTUbTyzdK2FwTc98tgamSBknNQwlJF8ExpghowZSXlKpbEho71Z1T+dJI79YAPdh8vNTh6iJSjO/KvDpYtJA6ihngXoLcKUH2L7Q15P1iutOVslrLBtMINEmmK/UeU3uqIVQjkFiXqItQcnsrH1jNyBXGPNXetAWR4PQHbl9+frA7agb5wzJMQVDk4o1hNZngTmOxH/cWw/HUH1YbfHwHewe7jp4MHzWT2IjSEHHHBDDK+8WINKeGvTn08MX+wTjwsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3iX+t6uwK0OlUq6ekbqjQPIK16GDbEtF9DBrJaN/xuc=; b=GhDOLPYj13/o9+liwOBWkGp6RMFz2eULybGkMWQe9dRiSKAc17xffS/qQrMAnDkundaWmZHCWOKM851GvDxprk9WuNJ6O0Z3uFM4OHr8SSP7A2opsUEbXEHeZ2h/KasvPHElBxP7nh0PB0dT8z2AmaXGTCI0t6Har/aXWV7rj52S3UWOSYDI0LJG7oaAxjw7m1V98A+qPtAYZBNMRYVzcLPHs1GiQwM+hf7/SKayAlb5aQRA70DO+bJgiS8vUiG2mAG8sSm5knZzUaYFTtVzKqK/FmzNXUDRFGd++qNl3Khrj23UI7RSJvootRHhuqosZJjJFJuqg+AYVPf/4yNbHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3iX+t6uwK0OlUq6ekbqjQPIK16GDbEtF9DBrJaN/xuc=; b=oMsfGozGqK2cFMmBUnj8KUbCVA44oBQi7LRWVtMhM8dxLKMQs0lWBO4p4iisqfmMehGNc9oaRhrGu99BfdsSgo9xibE5NbCjrbH6Av5i94Ke3jCumECJjx9nA2rJpIu6aEu6owPUrlRSx0UKxjIi7F8bBgLubwuYJsU7QZtgSxU= Received: from AM0PR05MB4561.eurprd05.prod.outlook.com (2603:10a6:208:ad::20) by AM0PR05MB6260.eurprd05.prod.outlook.com (2603:10a6:208:cd::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.17; Thu, 9 Apr 2020 22:20:32 +0000 Received: from AM0PR05MB4561.eurprd05.prod.outlook.com ([fe80::20a9:df2a:69cf:1494]) by AM0PR05MB4561.eurprd05.prod.outlook.com ([fe80::20a9:df2a:69cf:1494%6]) with mapi id 15.20.2900.015; Thu, 9 Apr 2020 22:20:32 +0000 From: Alexander Kozyrev To: Mohsin Shaikh , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: use open/read/close for reading ib stat Thread-Index: AQHWDq8Af5Q7F9vd/kWQY5wexwiWi6hxXEog Date: Thu, 9 Apr 2020 22:20:31 +0000 Message-ID: References: <1586464626-12958-1-git-send-email-mohsinshaikh@niometrics.com> In-Reply-To: <1586464626-12958-1-git-send-email-mohsinshaikh@niometrics.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akozyrev@mellanox.com; x-originating-ip: [2607:fea8:e380:d8e0:c10b:9f1a:6dd4:51db] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bb0bd0c1-1885-4191-0ed6-08d7dcd4379c x-ms-traffictypediagnostic: AM0PR05MB6260: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 0368E78B5B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4561.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(66446008)(71200400001)(4326008)(478600001)(4744005)(55016002)(64756008)(9686003)(2906002)(66476007)(66946007)(76116006)(66556008)(110136005)(81166007)(316002)(6506007)(53546011)(7696005)(33656002)(81156014)(86362001)(186003)(5660300002)(8936002)(52536014)(8676002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: njUF8x/nU8e5k74rOI/LOvOpZcey/hzdDPcleeg+oBZk/rFy+IDn9WnM5I/m3A8hxhzZNrOOVcQwrsQWWK2h2YPrAEBkuT0HSva8yWRFX9mOS0Mmc4/niiPuDigBSJ15If26TFzD3T94C2ceLIDfLtiZTu5TZtjzzjwVPdnSLjZgU201YK5H4IjA1WbZBvaxKwo/y0qkSthpycgbJWD0pN1lkpBuKwhfBEkgdAA4z/0gD1IpJrMYWh6og4Jt80JBCd4h27E0KZypwJ00U2WFJCc+tP91+vN1c5YBKB/9+u20TmTS5cJp0kI6nfZP49kLiW1Qq+9h7uhWiZFg8riXd3qPguG5xnDole3LSOqYsrUtLUBY/V135z1EplZlxGgB64CzldDip1QuqN4G34js+fFFUEV0X16tW6bAZLEIBqK+8Yir6mg3j7AuP4/Tyq+s x-ms-exchange-antispam-messagedata: 7yvO+1MLDctE6MoGeeeHrW1Olb0rgtmg2+tTXdYWzBlLko9YVJ62IqnImJeh+OcSuuAJ+DnFN8NqQ2G8zdEnrQuj24vYYnDwM4ewHyXW9QJQDZMGycmW2T8sv1knMbz/8oyhYdx1eLvubFgIBK0IBl2hydgg/TtjEAOl8A0GO/fA7mA7UtE3RX00gyb5vsk/2P/Dh9/MOzJBRAUL6CG7Ww== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb0bd0c1-1885-4191-0ed6-08d7dcd4379c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2020 22:20:31.8647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SfmeOfK76mnlYKy1Qzg5ugZCYxT7efTHTLtgXKCUz1ADm1tKrWgdN4pNmQsv7wJYqRJ2iQwYT5t1R0KF/qSxtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6260 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib stat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Mohsin Shaikh > Sent: Thursday, April 9, 2020 16:37 > To: dev@dpdk.org > Cc: stable@dpdk.org; Alexander Kozyrev ; Mohsin > Shaikh > Subject: [PATCH] net/mlx5: use open/read/close for reading ib stat >=20 > fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads to TLB > shootdown interrupts to all dpdk app cores including RX cores. > This can cause packet drops. Use read(2)/write(2) instead. >=20 > Bugzilla ID: 440 > Cc: stable@dpdk.org >=20 > Signed-off-by: Mohsin Shaikh > --- Reviewed-by: Alexander Kozyrev