From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB6CEA04F1; Thu, 18 Jun 2020 11:41:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5CD21BEB2; Thu, 18 Jun 2020 11:41:57 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70050.outbound.protection.outlook.com [40.107.7.50]) by dpdk.org (Postfix) with ESMTP id 22CCC1BEB2 for ; Thu, 18 Jun 2020 11:41:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k8/Xc3OzdWxdRQ1kTcRcSg5AicUXuEGOWlrfGPDa2G3kuchpEC8hi9V2V+T1qjjhkzVpNclikDokx0vWNCZBKRG259Ps24IuIzZk3tiZIJ6m4D0w5bvB/MAIZHsR0PvguJaupZs9cS+qG+hZJx26CylVgr6MWty/G0jCAOnHFRyJaw0n5m2FYQxAzpbDVP0VoApvv5y0C+e5NSSoh01XXdMapoKKK8rX2BV+fLVo2RMypNGuVW/xRKsA6Hl9GEAPHeRD0LMqgmAr5PGGtSpi/Ew4oZ0c21nBbQxU5u6SWKuZh1MVl+cWJlLBA2vtTGadNYM/q528qWGa2ZetBn1j9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VTYk0wFBuKmhIfEalhb+PD8GZGxZMfsiNpCqz7M3bwA=; b=hqIVS7LiyOpXnnqnhMR5L4o2MoquWNs7Ztvk5/bvxe9mXmEkrkZo9jx6+Hm7t7AYmgrcB4ZfrhxAoAnlmPiYLONZS6aTswzW5IUcnWHDxWPGwnBjJgBvpS/6ngrCKRCusmF4FvhLo5LwnBuhov2Hij1Zezc/GJYzyamqLASNiIfjKvqW27bqMUmDcscovhvhjmw+4ca9eSpBbCwwtEydwvEKl8GLoktZ7me/GWjGoJApMp+oS5PrCGWsgIUOuJOflyBe7MfPV2YpZlXNWlUw3/Fa6vzyDarNdmYUz5d+YkSRu4QSMQlR767cgjsHqGI0h0RlcrEwKTm6FpuO3ZIRig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VTYk0wFBuKmhIfEalhb+PD8GZGxZMfsiNpCqz7M3bwA=; b=d7xKGo9eFlAuvTx2+5Kj1CmmmwwDvh+oVPowdewtxa2hgyBsbjJBR/xnmvKtEcy+l4eyf5Cwr7FuZAyagXiE2HEUkH8GxRKzej51ruhApJyUH5061ZBXhT730gBYeKZh2a4EBG7bM4bGe2a5FzTErtaQ1VQpWqHg3W+7/IrAmZk= Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB5153.eurprd05.prod.outlook.com (2603:10a6:208:f5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.23; Thu, 18 Jun 2020 09:41:55 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3109.021; Thu, 18 Jun 2020 09:41:55 +0000 From: Parav Pandit To: Thomas Monjalon , =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , Ori Kam , Matan Azrad Thread-Topic: [dpdk-dev] [RFC PATCH 4/6] bus/mlx5_pci: add mlx5 PCI bus Thread-Index: AQHWP0sfgNP7CvRWkEyQE8rWCA18pqjaMXkAgAJOVYCAAajXgA== Date: Thu, 18 Jun 2020 09:41:54 +0000 Message-ID: References: <20200610171728.89-1-parav@mellanox.com> <20200610171728.89-5-parav@mellanox.com> <20200615210042.gblrdp6rus6exooy@u256.net> <2695586.TfsyjlpMEJ@thomas> In-Reply-To: <2695586.TfsyjlpMEJ@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [106.51.29.68] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8d349c45-be7b-44bd-85e6-08d8136bd647 x-ms-traffictypediagnostic: AM0PR05MB5153: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0438F90F17 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nzI8TkS8o1j/QbnkQzPNjdtGJpPHf6jepFSzMPdRPuIcEmdELnHQrj5V4fVZWtcigj1hFs5j806Q/d0MUhob2brPJR4f5YcRVPHq0Z+O7RURxtiPkPa0eb9w6OtqinN5kz8n+/tdtDzX2j3KRQltcfykyQrU8YEWbZ0AsoNv1fH8LzCpFVYWKabRCut1jldyl/NVhvq7dr9tJOQHhvJv15yGjXArWEQmiknE5iGr6jXLgRyB749B+hWfL1w4ryriLiH3JU3JnrHGmp0biffRNaimObCWECzorTa7CIpAv262KRcqag3lHaNOBiBHkxDASa8qB1aTQuS9oZZ3xPrMgA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(7696005)(316002)(186003)(86362001)(54906003)(110136005)(478600001)(4326008)(6506007)(66574015)(53546011)(107886003)(55236004)(26005)(8936002)(9686003)(52536014)(2906002)(76116006)(66946007)(8676002)(71200400001)(5660300002)(64756008)(55016002)(33656002)(66446008)(66556008)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Rku+Nj50DvxSKQaBcRPEaKa72AF+q75kLT5Aes4sQztbS5k38nVuvcXMyRds5lD95H88R0KafrRkoJi+cIX0SDVxerByIgjiw3zHlgPOS7XP/ioVPzdB/G7GRQS+N3YlSrPnW4MBPxobP0pqF9PtERpqQwbwlHKblkzB33Qnb1vX4sSfXovrDPZLZbhwhVDblugTc6SvGolAXbifUwt27WzBlI5avOH5f4ARnBqvvBJBlT9HKCLl++uprdJaZGom1qEWUh8I9FmCo+Jvw+tc41ly7H76t+CjAEv4rkPpenYUajfYa9DPMPV235oonrHK1wsZT/F1luf962HWFpl/bGDrIyQgzRkN2+JzHS582WuQHqBfggIHjfJa6kSodUr5YvXmyAyaG94Mj4h0t04qCfleUdhzQzz9qqVBALEQDywRIGLv0csM8JCUnVUnNVap/1K9zjKC809Zn0X6lEAmlqIIteoBadTiYbQhHalhHSs= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d349c45-be7b-44bd-85e6-08d8136bd647 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 09:41:54.9185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: frnSbEApuVfo2qZ/YiVlJ2yx9gjmhWjBpU+IMxqWMUa7O79aYVcelfk1DVRajVWbAQ60bcBN8H790WGs2gbRkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5153 Subject: Re: [dpdk-dev] [RFC PATCH 4/6] bus/mlx5_pci: add mlx5 PCI bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Thomas Monjalon > Sent: Wednesday, June 17, 2020 1:44 PM > To: Parav Pandit ; Ga=EBtan Rivet > Cc: dev@dpdk.org; ferruh.yigit@intel.com; Ori Kam ; > Matan Azrad > Subject: Re: [dpdk-dev] [RFC PATCH 4/6] bus/mlx5_pci: add mlx5 PCI bus >=20 > 15/06/2020 23:00, Ga=EBtan Rivet: > > On 10/06/20 17:17 +0000, Parav Pandit wrote: > > > +# DEBUG which is usually provided on the command-line may enable # > > > +CONFIG_RTE_LIBRTE_MLX5_DEBUG. > > > +ifeq ($(DEBUG),1) > > > +CONFIG_RTE_LIBRTE_MLX5_DEBUG :=3D y > > > +endif > > > + > > > +# User-defined CFLAGS. > > > +ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DEBUG),y) > > > +CFLAGS +=3D -pedantic > > > +ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) CFLAGS +=3D -DPEDANTIC > endif > > > +AUTO_CONFIG_CFLAGS +=3D -Wno-pedantic else CFLAGS +=3D -UPEDANTIC > endif > > > + > > > > At this point why not define some > > $(RTE_SDK)/drivers/common/mlx5/mlx5_common.mk > > > > That should be included by vdpa, mlx5, this one? > > This would force-align flag behavior, this is becoming untidy. > > > > (Make is disappearing soon I heard, but still.) >=20 > Yes makefiles will be removed in 2 months. > Please do not move makefiles at this point. >=20 > [...] > > > +/** > > > + * A structure describing a mlx5 pci driver. > > > + */ > > > +struct rte_mlx5_pci_driver { > > > > A note on the namespace: rte_mlx5_pci seems heavy. > > Do you expect other types of "super-driver", other than PCI? > > Wouldn't rte_mlx5_driver be ok for example? > > > > > + enum mlx5_class dev_class; /**< Class of this driver */ > > > + struct rte_driver driver; /**< Inherit core driver. */ > > > + pci_probe_t *probe; /**< Class device probe function. */ > > > + pci_remove_t *remove; /**< Class device remove function. */ > > > + pci_dma_map_t *dma_map; /**< Class device dma map function. > */ > > > + pci_dma_unmap_t *dma_unmap; /**< Class device dma unmap > function. */ > > > + TAILQ_ENTRY(rte_mlx5_pci_driver) next; > > > + const struct rte_pci_id *id_table; /**< ID table, NULL terminated. > > > +*/ > > > > At this point, why not inherit an rte_pci_driver instead of the core > > rte_driver? >=20 > I agree we expect inheriting rte_pci_driver. >=20 Ok. I will attempt this.