From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87C76A0526; Tue, 21 Jul 2020 14:51:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A00251BFEB; Tue, 21 Jul 2020 14:51:47 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60081.outbound.protection.outlook.com [40.107.6.81]) by dpdk.org (Postfix) with ESMTP id A783D1BFE9 for ; Tue, 21 Jul 2020 14:51:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fkomFrdqOMMgtzyAqxHfqCS6kW/EpRzrXfUvRajTV2pYkUxxYpKU9KsSEA+w7Iq7JYF8l6lz+2+8VPzLKslRoVz8OvVAKz4V3tdWfn8iiVne7AVBZzoPugEtkhhCquftR+jDtnFbZS+hkH4lLIEIzRmwsUkhWRGs9PAZOtyoR/t52wBMUDPuvnZvfq55/PQhSQ0afNJJmiV5movuFdw9WBqfZX0GrfYXCPhUDvtb6HaJbXLvuX0AA6ZZYGkwc6Z+1yENRv3VJsDvMH+dspPXOR+mIzQR9evI2moidNDkaLo4hulnFJH4j2rXYcu4Hdm5Pt9+RM8xaAqT9QqI8k/uzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P+vfT49rhz0hWJ/M/Gz3kw/eIPkndJkQmlO08XkeKZY=; b=N3MGf0HCQEhsGfwX5CODc8RPxE3E0f3SYh8q29OGtExUeNntiH72Ao64OTW50wE/Lv5bfyZp0QFlcpU46DxmUSF+AR4+fAYONIXXbFzu2MEtc7uuAlGFITxD1Z4Agk+h2eDTOoO9d2Nz0LN2yYAJ3qWdPQlY/XEqQ/1jymHY0D17Xa5WFM4hBrqInych7HgCJgHMKzpd02HwGbf2i8qah7Kl+cduD8c/bnE6p7YmkP8YYG/qW+6D6Tg8iW59yw/4ekvmejADI0KmM4jQ86sm0SvpAn2OP0XdwotyXbEHfxeHC4xPlUz4zCF0aF7tZoEIE+I1N3/TmatDeL6hbVlyOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P+vfT49rhz0hWJ/M/Gz3kw/eIPkndJkQmlO08XkeKZY=; b=V1g9O4EEUdnn9cz1AL3NxOvTOuCa6ois1e32hoUpBHUxTiwqwFCdDxiPASU2v2LXqJJ52gAFJFqfFSJe+0N5rpPMwmnivDDHlwQ8K2thR8n5sCdQtvTc61J3JRACJkxatnjmkp/wXogy/UOxjbFYgm/yPj1hZEp3RmGSLXl1uk8= Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB5329.eurprd05.prod.outlook.com (2603:10a6:208:ed::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 12:51:41 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 12:51:41 +0000 From: Parav Pandit To: Thomas Monjalon CC: David Marchand , "dev@dpdk.org" , Ori Kam , Ferruh Yigit , dev , Gaetan Rivet , Raslan Darawsheh , Matan Azrad , Joyce Kong Thread-Topic: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level Thread-Index: AQHWXEEk2UU4ORJTmUKp6of5rpppW6kQq0aAgAAHfACAACcGAIAABg0AgADsBoCAAB0XAIAAAu2AgAALaLCAAASTAIAABfbw Date: Tue, 21 Jul 2020 12:51:41 +0000 Message-ID: References: <20200610171728.89-2-parav@mellanox.com> <6790966.1uoSfovWKA@thomas> In-Reply-To: <6790966.1uoSfovWKA@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [106.51.108.81] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7815f6f3-25d1-435e-aed6-08d82d74d0fb x-ms-traffictypediagnostic: AM0PR05MB5329: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gzfzHMEx77ogFNkyWLaHXv6zqyPSYoYn9WW0BL7fKYa+E8pb2a5MwnhUKaMHln1zhb6HwX6Bw69j3JJie++/bnyDLrqem6V8PY/SSZAKbqPvFhV5hhcPyCoLh1eDhWQsrasTQXqruUXx1CWkRVA9L+nO8qpIDhmJ8BB83B1xmmKpAWIXeB8bHUfEV3GYMCYDGeNCsIbR1jbvit2CyFpoRPX59YBWPkEA3zmcvYF5KS4FndDRjYY+2uM6Cx9lDFZbSPLlCVLI0IShIzP+fdCDiAZAaXL31AWtZaKOQ5JrmICDxsKsmvyeiO5OO2EkpmoPnD52mDYQ3WFsk3yRav6Cfw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(26005)(71200400001)(186003)(86362001)(498600001)(9686003)(53546011)(2906002)(5660300002)(4326008)(33656002)(66946007)(66446008)(76116006)(66476007)(52536014)(66556008)(64756008)(8676002)(6506007)(54906003)(6916009)(7696005)(8936002)(55236004)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: XLK9fH7yq6RGG2ku/nqgzjSNiU8u2DjJbhf7hyzVkb0Y7eea4ZFQVWj6lGzEDrHGOZYJP756HQaYhYdAFgZlvb4IjRYfuZYbWmyExfIBLlUkO4pjOEx6HgYSNo8coFojmLiyN5KTuHooy78hSklFfywUc9bP1S6sHtr0Lulpklhf49cqtZ5fxnqUAKErxjvTVNpc2jQCM1u9R+JYYxG94dwE7q5V8E56pcKZ6VonlYPL4THlpk4D6HyHqhvDgn8dhIfuf252pCtXfgfbjkqedtkEvnL9TvpXurSnghDgeCWkBOP7t3VoBuHDGKpnZkppCypJ+aoMC6GQTrDjYmlGAVoByuB6lmxLs1UdN6jYmm/aZxVsGxF72fqg57HNoZRdcsOom5BtJPBxFUsURW0565kSl2MWSx/0bemVpTyM+igv5RKfWMcKORDYLNBjjn8/mmyuQhEepQS00+qnSjNKY0/XzmyND1+y/TkrGapWHx25mzyaxcAuwARu/gYDuDkq Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7815f6f3-25d1-435e-aed6-08d82d74d0fb X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 12:51:41.7377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Tr3Z5U6ybvwzZFGRdnB4kHttNg6xj+ZwXrTEZEVunAZLs6milDbyY7tZoB7DiDVfLHGTW3kUjWBjZxffiZRclg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5329 Subject: Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Thomas Monjalon > Sent: Tuesday, July 21, 2020 5:57 PM >=20 > 21/07/2020 14:13, Parav Pandit: > > From: David Marchand > > > On Tue, Jul 21, 2020 at 1:19 PM Parav Pandit > wrote: > > > > > This way, net/mlx5 and vdpa/mlx5 will pass their id_map to the > > > > > mlx5 pci driver whether it is registered to the pci bus or not ye= t. > > > > > > > > And here pci_id_table will not be const *. > > > > Is that ok? > > > > > > This is already the case in the current patch. > > > I see nothing wrong with it. > > > The pci code expects this pointer to be const and will it treat it as= such. > > > > > o.k. > > > > Gaetan, Ferruh, Thomas, > > Can you please ack as well? >=20 > Yes of course it is OK updating the PCI table of the common layer in runt= ime. > The most important is to keep the fixed PCI table of the PMDs the same as > registered for pmdinfo usage. o.k. pci id table registered with PCI bus will be build dynamically, simila= r to how its done in v7. Instead of doing it in constructor of mlx5_pci_bus, it will be done inside = rte_mlx5_pci_bus_register(). Right? And since we don't register it as rte_bus, shall I name it as rte_mlx5_pci_= driver_register()/unregister(). Right? >=20 > > > On the other hand, you may remove the pci table exported by the > > > common driver as it is useless. > > > pmdinfogen only parses the .o and extracts the table symbol, so it > > > won't load other mlx drivers to generate the .pmd.c file. > > > > Ok. >=20 > One more nit: please don't use "class" as variable name for drivers. Ok. I will address that.