From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51631A04F1; Thu, 18 Jun 2020 11:47:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F7301BEAC; Thu, 18 Jun 2020 11:47:25 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30086.outbound.protection.outlook.com [40.107.3.86]) by dpdk.org (Postfix) with ESMTP id 162231BE9E for ; Thu, 18 Jun 2020 11:47:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ha6+LoA7f6/M7vvCEijvqXoAMGlrpjGUW7PCUR/EUJNbLE2TOHTCS7fLGiOSmhSFjeOnjaDU58FhG9TePJyokHFM5aH33FhK3q+hohPtNYQIlNm8iF5kDk5+5rJfShVkkarBpH4ETekr7l+EZrLTF8EX0o1/Um6hbKAU1kn6UQaAAU1MbBxKWIw+BbTJdovBoic921hq3SvNqKOWJLydUy225UM5wYHromh1sgTzT9qJKi5w0HM/2ucS03uL4O/vV+IC4IL44D1wzGagbLFT3k6YA0VAK5Wf7V2jA2aLhl6uK2zrGMVclz2Byrj/zloZIZe2+uYnGOgPKTRzsZ3+QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CUDEJ1q9aLMaSP4eX4nBtaS7COlhWxhO7PHmyPY5Csk=; b=CYXxwgLzrjulHbE9Kti/qBKF6pZ2r1Ji/lAwUK2xJ/ku5/Eh7mZPmXLqItcT6Qmt4MEL+FdezDDeoxeGS0eV5wtUkYK5rpQohmxgf0vrC512z4+C8wyGnUS8TMijan23XNmKMmGOXIfY6Rk3JG35Q41LKXu7XTqnjK9pPXGEb8XmU8dorX4MCINqt4t4OZB2RMT4cX1nyEg2aHqPP7+TsOAJIQdpwN4y7PR3ZHynH8n03uM7LO0sVc78qMPIom9mQWgxUxDu4+IIsTD+y+8io5Bs1Dq7o1Pygc7NCFid+WGHwGAkrXInBa/l3LsEMXgQ74zs0Zts+1nLoNcjaXk74g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CUDEJ1q9aLMaSP4eX4nBtaS7COlhWxhO7PHmyPY5Csk=; b=qtXDH0ffanZNOoRp18D0h7yXElri55pC9ceIS8Pq4pU2zxRlEWSunSbZgdYr9v01rBvj8RHJkjapy7B1P2xHiVOHy2pjXEThb0X4/phWnJC3k6tIIFK5+LQ8l8wVG3+LtrU1WzbjBtah8NRdRhab0xepbap2TQG6YYCl2oqy3Rc= Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB4449.eurprd05.prod.outlook.com (2603:10a6:208:65::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Thu, 18 Jun 2020 09:47:22 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3109.021; Thu, 18 Jun 2020 09:47:22 +0000 From: Parav Pandit To: Thomas Monjalon , =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , Ori Kam , Matan Azrad Thread-Topic: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver Thread-Index: AQHWP0sgnAq5w4k+Xk2Dotj1MrQIfajaPkaAgAJDCQCAAar6YA== Date: Thu, 18 Jun 2020 09:47:22 +0000 Message-ID: References: <20200610171728.89-1-parav@mellanox.com> <20200610171728.89-6-parav@mellanox.com> <20200615214631.lmubncrd6xggq3hu@u256.net> <4042779.WuHiVtWF6s@thomas> In-Reply-To: <4042779.WuHiVtWF6s@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [106.51.29.68] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bc42b139-80cf-41fc-c410-08d8136c9974 x-ms-traffictypediagnostic: AM0PR05MB4449: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 0438F90F17 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B6ZVoimQp4NuEjZtp5VMrm2gbo/Fh+yD2oOx0mAUhM9P3FcqvHzfH70yqEZrnDalM/A8zMvhDjWOvKB/d8GnFkfu6T8OAamSs+QhdZXQez06fwUf7DJO9PL4GwmYbfX2MfE4p34C4lYSQlrcnaCRMc1UJuy6gY0M8Z3QzzLqAQx1WppTc/YVtlg/WFxqxvUxVWeJ09WeH+zTUhyiuU8wqA3jAC9FIeZAS+LIm22tOzcgsrsE96088QRxDtHBLbbTaHoBnCR/J+MjUyZcbDBJGvOPBEAoO4XjV/xE93pu9RXcxZNw0v1K09kcJWOQvhVp x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(346002)(39860400002)(396003)(366004)(66556008)(186003)(52536014)(26005)(76116006)(66476007)(66446008)(5660300002)(9686003)(2906002)(107886003)(316002)(55016002)(66574015)(71200400001)(64756008)(55236004)(53546011)(6506007)(66946007)(4744005)(33656002)(8936002)(7696005)(4326008)(478600001)(54906003)(83380400001)(110136005)(86362001)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: G2p2Pbkd9ukOjpVQ5Gy7F49/kpygeE3CE4LmgbEnFoSksKsnDYpJl+hrPLU70G5ntjv77QF0RIH70HeT5zYyv60ro8+Co9y3tCdCP9Rk1JSsLXQvE6zSNjC3zFaNSBEmAGW8Ah4P586W+0UmsfZvipgfcIAfIZobl3yuOMm7Gq+XTB0/1WY6XN9UEnKqvh+jPdCr1+XhQtvxELzDbyH2/8C//e82KQz8yZzuKNH7x6FIOg4XJ8bWg3hoW6y7VHJ8ZU6aTrm3qRTiICG6deOWyrgbry92UyuogdNWn2IHtFHYJcPOB45mH3NHyMrIkZGYO6PI/sMJZcRcsU4AJoRCs4//h6ici6BGytTeE/kAeqmYuc000TxZYe4fGuxTZno/8OqYtjr4mizkSdrFKFF+QC1rgujfUrq8eoUhJy6FPu69CB8/+/SiZvV2Wh12NBQlKNpUgihlXnuYXagITN22RhMi3cyV5h6ml0/yUFsymqc= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc42b139-80cf-41fc-c410-08d8136c9974 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 09:47:22.3708 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9hel+fkm5QSrnASrR2XJRbPFuQOcsplw3iOX42mNVmpM76s2hV9kxU7srsJkntlmLlafGyYzmPE6FIr3+2W8Bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4449 Subject: Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Thomas Monjalon > Sent: Wednesday, June 17, 2020 1:49 PM > To: Parav Pandit ; Ga=EBtan Rivet > Cc: dev@dpdk.org; ferruh.yigit@intel.com; Ori Kam ; > Matan Azrad > Subject: Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driv= er >=20 > 15/06/2020 23:46, Ga=EBtan Rivet: > > On 10/06/20 17:17 +0000, Parav Pandit wrote: > > > + DRV_LOG(ERR, "Invalid mlx5 classes %s. Maybe typo in > device" > > > + " class argument setting?", value); > > > > Error message should not be cut in half, it makes it difficult to grep. > > If you differentiate between typo in name and invalid combo you could > > directly warn the user about the proper error. > > > > (You can ignore the warning from checkpatch.sh about the long lines on > > a string if there is one.) >=20 > The best is to cut the message after variable placeholder. > Here you can cut at the end of the first sentence "%s. " >=20 o.k.