From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B35BDA0527; Fri, 24 Jul 2020 17:17:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F36B1C02A; Fri, 24 Jul 2020 17:17:41 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2076.outbound.protection.outlook.com [40.107.22.76]) by dpdk.org (Postfix) with ESMTP id EEFB41C027 for ; Fri, 24 Jul 2020 17:17:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mdfH2CenOq602xn/ilVUEZ8U6nXjnzr+n70vVryHBlTUOhD8aTX+Fhq548lPs7l2L8zBYu5CwnHSLk15KhcbjnAmLddgbAo2VwNgEcS4cPBYpAmSlcgf3PNt/R9hp/Rt9ddnKdKBUoRYqmoR0Xk5tvlrbenmF8HmCFjfA3e/A9C6HdOndOevPspPcautkx/Tnc8X/7WFQE2W3qMijj26D+uVVxT/xp8QiFl5v74y6H4TFOpjKR52Uq99VyU156dsgYgp1VSiuJQuMpGBLZEVVgETO/BuZPNy5NdjKXAITJaPC6FGGcVk3hqN6trgNQ+puZ8wpzCPHw6AEzxAi1u0Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mSKBMaMlQ72LjwEvlwgMucZB8noIvWLEX5d1n8DmEX0=; b=GiGAIongO0AVFjNSdAzYB2XJmt9eyV3EmrQdjktrW4S45QTvJSVgqjCYkCX7QZF7oAJYduwlijzoKwWuwG+ru0ks74lTX6lReOOpdmMfDqEPZ2JXNXWxkKqdW6QbtnSwXBdWCBmHxN9WoTyV8cG0j2wbtF7utJlDkigs+MsBQW4wzPTe2XHWIQlH9gDVqUjL+rRFUyLvv18I+5fXV0Nmm/5wP4X9l5mhMwWmuq7M2/0VcyygVNoiBmBJPrBS8w9bNcjRvixbmO5BTOLdoahqWIDD9EtCpAYwpAZtOiCTH55IPRxBcrtB2hqyMAiERvza8jzjae41rcid6yWuGD2o/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mSKBMaMlQ72LjwEvlwgMucZB8noIvWLEX5d1n8DmEX0=; b=BQNbeo2jnjN4IgDjT6Mjb0IBPAYpcD50jehwvQKDKHF8EDWiml8SaqBr5/OJ4vfY5fzTp7uPEXf7dmoKRzqQFdToSuG6bvF50Of2061OO9HLGXuUZR0r7hXhbOiFDM86jSzj92SnibUIYyZAjLfokwMJgATQJ9Tp3TSZ/WJ5m9k= Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB4210.eurprd05.prod.outlook.com (2603:10a6:208:63::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21; Fri, 24 Jul 2020 15:17:38 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::eccf:72b3:bacb:f09d]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::eccf:72b3:bacb:f09d%5]) with mapi id 15.20.3216.024; Fri, 24 Jul 2020 15:17:38 +0000 From: Parav Pandit To: Bruce Richardson , Thomas Monjalon CC: "dev@dpdk.org" , "grive@u256.net" , "ferruh.yigit@intel.com" , Raslan Darawsheh , Ori Kam , Matan Azrad , "joyce.kong@arm.com" Thread-Topic: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order Thread-Index: AQHWYS0v/wbmxgA1t0ybPTrTM2yq66kWktYAgAAsyOCAAAHygIAAD4eAgAAHbkA= Date: Fri, 24 Jul 2020 15:17:38 +0000 Message-ID: References: <20200610171728.89-2-parav@mellanox.com> <20200724110718.GB2305@bricha3-MOBL.ger.corp.intel.com> <4937496.TfPSyrM900@thomas> <20200724145007.GC2305@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200724145007.GC2305@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [106.51.108.81] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d5b3e46f-63e0-4584-18dd-08d82fe4b3ac x-ms-traffictypediagnostic: AM0PR05MB4210: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +GMK8zKAx7GxRxRS1ToaZGsc9+Tmb3eFYNZM/TAIP47zK8DSDekDkeG5QAXkMG1yxMeoxx2zmvcUKFgIQqaQP3RONiAny06bm5uRCO+lX7rLXoyls5G8rm2eecqzw/XsdtUsQHUIMtkmUMUdvIrhOuxuBEKdE559aGM3C73u0hPnDAM3sIlOHLuy4mb0TwzgnLDGTvtGiSu/yPnOwU5zKbGXqI2HfFq6jmN8qM0j/aphtkTQQVJtVt944t3XmvxXg3d+dynMtZCNVtxXBiOsKjje1CBzMJb06v0xYHMWPxCnjPw3LehCbX7n2z3Ng+kwcJUVHepw/x9A0VXexWMU5A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(316002)(8676002)(5660300002)(86362001)(71200400001)(52536014)(26005)(33656002)(186003)(8936002)(2906002)(66946007)(55016002)(66556008)(76116006)(66476007)(110136005)(4326008)(9686003)(54906003)(478600001)(7696005)(64756008)(55236004)(6506007)(66446008)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 3eoHQaflsRinSuC2076XtNf2MefGEUaNSlMl0SJR0Ulikt351tLKr5wfJWA42W0UxJ1+CTWfsIYA6TG1ZZDSApjWfH3lmGBMjC/YtV0t4aAJIOTMz/stnvlMkXmqnFLFrf4OQlQTn+Ak7eK4+URilTvi16ktgwfjPxm9dSc1BAu0k5m2hAPVsTALXPv4mdg/x0Fc7Z3hGkbI4Dk0IcDWK9L7EtWHkCkp8G/0GenoBNfJZqqoL1cKXUtvDxEvlIAr2qiv9HiZ7WliLfWwNNDEa8ogjERFOKMW+EghkiRMhSpDZ6+6fC0nMmisW3uo9oYFZi1hRzHOKnoV1I0QncgLbfpmYopJcgbiD2Z681A8nDQVll+BfmN8Uk+cbQY8S0p/iqPNcEqdZfDITK6XBy/ad6mSd7RgdoN/hT7UqROLP242u3pNC4iZk8XaJ7hMSDYLIZ65/7ZSRhXB+yuUMzZp+MhIuqbA/ajIjDiTKQTU6xmX6p7s/w4LcvFVspuHyr7W Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5b3e46f-63e0-4584-18dd-08d82fe4b3ac X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2020 15:17:38.5265 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3zq/0crSp6tFQ+K4IRevw6t6ixWz52t3aZKbTsoN7slruNtBf828HsDqWLI9fflCB5qHlonMlPs6WsPt3AtknQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4210 Subject: Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Bruce Richardson > Sent: Friday, July 24, 2020 8:20 PM >=20 > On Fri, Jul 24, 2020 at 03:54:33PM +0200, Thomas Monjalon wrote: > > 24/07/2020 15:48, Parav Pandit: > > > Hi Bruce, > > > > > > > From: Bruce Richardson > > > > Sent: Friday, July 24, 2020 4:37 PM > > > > > > > > On Thu, Jul 23, 2020 at 11:09:03PM +0300, Parav Pandit wrote: > > > > > From: Thomas Monjalon > > > > > > > > > > Drivers dependencies are evaluated in the order defined per > > > > > their parent directory (also called class). > > > > > This strict ordering prevent from having 2 different drivers of > > > > > the same class with different dependencies ordering. > > > > > This problem occurs if drivers/common/mlx5 depends on > > > > > drivers/bus/pci, while drivers/bus/dpaa depends on > drivers/common/dpaax. > > > > > Having a strict ordering between directories bus and common is > > > > > too much restrictive. > > > > > > > > > > That's why it is made possible to have a more fine-grain > > > > > directory list, adding a driver sub-directory in the list. > > > > > In this case, the isolated driver must be removed from its class > > > > > list, and added directly in drivers/meson.build. > > > > > Also, the per-class variables must be duplicated in the isolated > > > > > driver, because the call "subdir(class)" is skipped in the isolat= ed driver > case. > > > > > > > > > > Signed-off-by: Thomas Monjalon > > > > > > > > The commit log above has some strange word-wrapping, and > > > > occasionally strange phrasing. I think it could be slightly reworde= d, > perhaps as: > > > > > > > I updated the commit log as you suggested below along with RB, ack ta= g. > > > Thank you. > > > > > > > Drivers dependencies are evaluated in the order defined per their > parent > > > > directory (also called class). This strict ordering prevents > > > > from us > > > > Is "from us" too much? >=20 > The word "from" is incorrect, anyway, it should just be "prevents us". > Evidently I didn't proofread my own text well enough. :-( In v10 I rephase it as "strict ordering prevents from having pairs of drive= rs...".