From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4E24A0350; Sun, 21 Jun 2020 07:49:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EBAC1BFC0; Sun, 21 Jun 2020 07:49:12 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2068.outbound.protection.outlook.com [40.107.21.68]) by dpdk.org (Postfix) with ESMTP id 444101BFBB for ; Sun, 21 Jun 2020 07:49:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L5gnmQTwkExATJS/0kAiFgLglchWJsaNf23z4RUR+E77cssFdBWHhsTXyMq3PjecQKEXNT4gWbSes6QQUHrQrHVI9gkeX/mOdhXrMxfo9de7H+g6s7wnaTgUSSI6PQdqQWK5WzgCskb6ZW7IIJQC8f2gdyD4YFn9bwFIj6fjMqnr6dtyNY0avkJWweyS5Ebqdp91k11YQKZqsR5V2Oh8V4MSgpWToSLOCBY5oRYUNfhHkbU0lJWCWqlXIf95J//Nm5GjHd8DFOk8geHZPmhWBJi6SU29N1XanpobJdGyEyDigPWZlW3HV3B1fl5VBD8snJwMMoRzsGJyycMX9yWlpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QqjALTmm210ZfYgRe4NcqR9M1g8jfIp1oeQ143aShDg=; b=BzS8LF1mkx762ERuP94jCDt57ZCTfUmFAr5z/Fxu3T3iLBTfCpLdvOwSWQ/f/hDAPVmtYcRAfnOf/q+nIYka8EZqI3w8gf8V/KzpRVjD2rTEw69eutoREjlGEqRfmmfdIZ0R8eK3CFHdd/yr2YObERRX8bAQ73fEiCJhIfqkZOwT6HnGSnSJK0TBaekV8t4pVWGKG4HPAgEEy6NKxGval3O29ZXXN6ew9tB7nBNfGwEzjd92BqRvrgm+4fqNbPpZp229/xvnMkhhDR1guxLLHcLVZrTkWfIGyzKoWBKw4xbX6nrRnuGKkwm+cILwm54KFOWmPdrGQk+zcdJ1WN+8Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QqjALTmm210ZfYgRe4NcqR9M1g8jfIp1oeQ143aShDg=; b=VH3mJRgq3cy6YWSoMLFQMMLdxhRFbPZw0OtrfToGIDSYbFxetzPGW5oGZRc5U1tl8E5VkLJj6kgsS2GWif0f1GTNgYpqxvoamyAoqZdwY5YrO+NNHQBbbkk7HLWO1C0irCTv8NiBxnKsawLMKDDQQ7NRm1wyEnGFbfNQWGk9xwU= Received: from AM0PR05MB5313.eurprd05.prod.outlook.com (2603:10a6:208:f2::28) by AM0PR05MB6644.eurprd05.prod.outlook.com (2603:10a6:20b:151::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Sun, 21 Jun 2020 05:49:09 +0000 Received: from AM0PR05MB5313.eurprd05.prod.outlook.com ([fe80::3069:d8f4:fadc:4d7]) by AM0PR05MB5313.eurprd05.prod.outlook.com ([fe80::3069:d8f4:fadc:4d7%5]) with mapi id 15.20.3109.025; Sun, 21 Jun 2020 05:49:09 +0000 From: Tal Shnaiderman To: Dmitry Kozlyuk CC: "dev@dpdk.org" , Thomas Monjalon , "pallavi.kadam@intel.com" , "david.marchand@redhat.com" , "grive@u256.net" , "ranjit.menon@intel.com" , "navasile@linux.microsoft.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "anatoly.burakov@intel.com" , Fady Bader , "bruce.richardson@intel.com" Thread-Topic: [PATCH v6 9/9] build: generate version.map file for MingW on Windows Thread-Index: AQHWRbXR4kVhff+++E++ue2GqfF6gajh3Q4AgAC155A= Date: Sun, 21 Jun 2020 05:49:09 +0000 Message-ID: References: <20200609103139.22168-2-talshn@mellanox.com> <20200618211546.24496-1-talshn@mellanox.com> <20200618211546.24496-10-talshn@mellanox.com> <20200620215434.31802ab4@sovereign> In-Reply-To: <20200620215434.31802ab4@sovereign> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [37.142.1.17] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4e5c62eb-74ce-457e-74fa-08d815a6d174 x-ms-traffictypediagnostic: AM0PR05MB6644: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 04410E544A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XHy4ETY3GIq2BJup0/eRVBFCWLDYAAXUXGv86iHRCVJIKxeFaIcGsWEGnJiNE0Ump7ajm1kYbEKQpk2SJIjKPGxqmdbG+g8Dz+hOZYWqW/SzGZye8zGJXoJJ0WBJfbQPLUGjn+/TXilaHPQQ0sdiAIZzOqUCK1yEeC1z8ug8D2rh9T5OC4pu4Jco73on1yJw1XiVseEjBPqSzBrwhIzVgXU77J/JESRK06QW6xa9F5bNwTw+9bdzhP7v3EfVS2c94aHHhh08pFkVNIIrQo/sU8P8uFAviTxamkkeKc21GO4ye7iHTt/bLOJpCBrSp0oMkPKoKJrTRfMgNXtnDzW0Bg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB5313.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39850400004)(346002)(396003)(376002)(136003)(478600001)(6916009)(86362001)(8936002)(45080400002)(8676002)(71200400001)(2906002)(9686003)(55016002)(7416002)(54906003)(186003)(52536014)(66446008)(66476007)(7696005)(66556008)(76116006)(5660300002)(83380400001)(66946007)(316002)(64756008)(53546011)(4326008)(26005)(33656002)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: UOBaMqtAcY8pYAmmCjBqraTutp5Mx6mJteiIWB7SXKUrl4rQLjyztH2Audc4degz1vpJ8VMjAnZcl8pUCORVJ4AEv6FrfQMa52aLwZBp4qqVkELIMRYHz+PklW52iJqY+mPBeTsDLO5EsxAdxY744yg3rMsMwu8sUdj1hcee96lNm3Af8J1FmgrR2sJWBP3ejwMgNIMzjKAhEB6XwGR0pmADI1Ay60ZdUnhjvaSQlmBDKC2wyjK9eObDSlwuJqppbctWDqEDrAxl9OjuJogVh9YCS2z/ooQY9vTcGNh7uuifOvwsCkAr0vZeeajTP57UKxXiezqrlsAw6FQAXusYxAyL17yApmklpVJ0Orc9BRMKsmpTk/13q73bOzU4dEymoSjGn5poKwS1R10yiroMuh68N+IzT3JuDc8656uasy6zGgxKXdYfWYzQNJ6J/V6lV3mAKbDvN7+MsHoJNvyUPJLrJqvP7WZaKbJh2cGsioE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e5c62eb-74ce-457e-74fa-08d815a6d174 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2020 05:49:09.4640 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LUfa9W0ZhofRCHGn/z27qJly/7yMjCf6w8633IJBpgWi8sj1D60yeCPna+tOuS+7LH3UphOTAZjuIB/wikoXpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6644 Subject: Re: [dpdk-dev] [PATCH v6 9/9] build: generate version.map file for MingW on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Dmitry, Using libname is the correct way in drivers/meson.build. I'll modify lib/meson.build to use libname for consistency. > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Saturday, June 20, 2020 9:55 PM > To: Tal Shnaiderman > Cc: dev@dpdk.org; Thomas Monjalon ; > pallavi.kadam@intel.com; david.marchand@redhat.com; grive@u256.net; > ranjit.menon@intel.com; navasile@linux.microsoft.com; > harini.ramakrishnan@microsoft.com; ocardona@microsoft.com; > anatoly.burakov@intel.com; Fady Bader ; > bruce.richardson@intel.com > Subject: Re: [PATCH v6 9/9] build: generate version.map file for MingW on > Windows >=20 > [snip] > > diff --git a/drivers/meson.build b/drivers/meson.build index > > 646a7d5eb5..b25a368531 100644 > > --- a/drivers/meson.build > > +++ b/drivers/meson.build > > @@ -152,16 +152,22 @@ foreach class:dpdk_driver_classes > > implib =3D 'lib' + lib_name + '.dll.a' > > > > def_file =3D custom_target(lib_name + '_def', > > - command: [map_to_def_cmd, '@INPUT@', > '@OUTPUT@'], > > + command: [map_to_win_cmd, '@INPUT@', > '@OUTPUT@'], > > input: version_map, > > output: > '@0@_exports.def'.format(lib_name)) > > - lk_deps =3D [version_map, def_file] > > + > > + mingw_map =3D custom_target(name + '_mingw', > > + command: [map_to_win_cmd, '@INPUT@', > '@OUTPUT@'], > > + input: version_map, > > + output: '@0@_mingw.map'.format(name)) >=20 > Hit the following error while building a Linux-targeted DPDK: >=20 > drivers/meson.build:159:3: ERROR: Tried to create target "dpaa_mingw", bu= t > a target of that name already exists. >=20 > Probably you need "lib_name" instead of "name" or just to disable the tar= get > for non-Windows builds. >=20 > > + > > + lk_deps =3D [version_map, def_file, mingw_map] > > if is_windows > > if is_ms_linker > > lk_args =3D ['-Wl,/def:' + > def_file.full_path(), > > '-Wl,/implib:drivers\\' + > implib] > > else > > - lk_args =3D [] > > + lk_args =3D ['-Wl,--version-script=3D' + > mingw_map.full_path()] > > endif > > else > > lk_args =3D ['-Wl,--version-script=3D' + > version_map] diff --git > > a/lib/meson.build b/lib/meson.build index a8fd317a18..9f6c85a3e1 > > 100644 > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -150,18 +150,27 @@ foreach l:libraries > > implib =3D dir_name + '.dll.a' > > > > def_file =3D custom_target(name + '_def', > > - command: [map_to_def_cmd, '@INPUT@', > '@OUTPUT@'], > > + command: [map_to_win_cmd, '@INPUT@', > '@OUTPUT@'], > > input: version_map, > > output: > 'rte_@0@_exports.def'.format(name)) > > > > + mingw_map =3D custom_target(name + '_mingw', > > + command: [map_to_win_cmd, '@INPUT@', > '@OUTPUT@'], > > + input: version_map, > > + output: > 'rte_@0@_mingw.map'.format(name)) > > + >=20 > See above on name/lib_name. Maybe it's technically irrelevant here, but > better use consistent name generation code. >=20 > -- > Dmitry Kozlyuk