From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C8B4A0350; Thu, 25 Jun 2020 15:24:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0EBDFEB; Thu, 25 Jun 2020 15:24:10 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2086.outbound.protection.outlook.com [40.107.20.86]) by dpdk.org (Postfix) with ESMTP id 3F46723D for ; Thu, 25 Jun 2020 15:24:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QZmKewv5MJF1HuRyNjU0Xri6cfP4gtEitqshppOvSpe9j/v4ky58DDLTlguATiZPcWj8r2WjkGRmj2LeYDaXUMTmYZMv4ZOhEt1M6ITyDrFkBAErhNK/cj0TUsBIIb4lPnzugWRrwCLkj8WfElXfJcSDUs+TRbxfeMee8M+lHUmBMf3tk+RxFv9mhVbgp7QTMmjqyMv2l7K5+nW2PLDMzelmEzUTpX43hl3ws+ks23oMF4dRcweUyHTY53BNLJUQ/MAF8IjjwCw0hyRWTIIDZOV7+mCV8v8Q28ppWTUxc6U7hMJ3/gpKyLD/NhImwENSJZ4ty6VNFNd8LRr2HwmXrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b5Z7LQDKk83/z8tejpLE+MbbBU8iXcWs8C+S/iUyBQM=; b=MRbts2+7KhKRboOj+70cTMHW1wfsm1ZSroMo2ewEcqKulltQ+BmHn1Dc+Ohzhf2B2PTCTsRtSGWRg1EPG2NlsY2YY/gM+lwE1w9Anq5yRV3g/BjqdxUBowBcfOnIyGPlrXWNbuCiKC04Ohkc9j9Jfk7rEDAomLkxgMo54lHoWI6Hazazs2vQABCE8yyFLghjui9tWlFVkO+adMTDxDHq66l6rM+SFSdXGaT7x3kGe1v+60Nc4BPR8IvVgYrGJ3U98du6TVtTC7YvL7QKk09NOPsdC+xxKhihSHo+9fF5L5p3cZIf94U+LIwEbbAPPuZZlfU4i6XcBHrUnuPG/TtVYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b5Z7LQDKk83/z8tejpLE+MbbBU8iXcWs8C+S/iUyBQM=; b=HThaIw923PPipVidTTpM58Z4JvhNNDDiMsQvmYbGfQrCyBfJI7YY5UdrMqx+LPJw0wm0JJE0lMm1OIof1w45/zmNfxvDLlrOmIRd7Fp9pIq2ExQ3MjJYCvyEDPXkHZiRid7cT+lwSXZ3blynn6NMbYGZN8HYg0DKraUU8aDYS2k= Received: from AM0PR05MB5313.eurprd05.prod.outlook.com (2603:10a6:208:f2::28) by AM0PR05MB5921.eurprd05.prod.outlook.com (2603:10a6:208:124::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Thu, 25 Jun 2020 13:24:08 +0000 Received: from AM0PR05MB5313.eurprd05.prod.outlook.com ([fe80::3069:d8f4:fadc:4d7]) by AM0PR05MB5313.eurprd05.prod.outlook.com ([fe80::3069:d8f4:fadc:4d7%5]) with mapi id 15.20.3109.027; Thu, 25 Jun 2020 13:24:07 +0000 From: Tal Shnaiderman To: Thomas Monjalon CC: "dev@dpdk.org" , "pallavi.kadam@intel.com" , "dmitry.kozliuk@gmail.com" , "david.marchand@redhat.com" , "olivier.matz@6wind.com" , "ranjit.menon@intel.com" , "navasile@linux.microsoft.com" , Fady Bader , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" Thread-Topic: [dpdk-dev] [PATCH 2/4] eal: set byteorder in Windows to little endian Thread-Index: AQHWN/hz7jR6cu8aD0OoCkCHLfjt66ja9bUAgA5yU1A= Date: Thu, 25 Jun 2020 13:24:07 +0000 Message-ID: References: <20200601093818.5420-1-talshn@mellanox.com> <20200601093818.5420-3-talshn@mellanox.com> <69231367.salAEKAJ0m@thomas> In-Reply-To: <69231367.salAEKAJ0m@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [37.142.1.17] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 50b34a1d-5f27-402e-de2f-08d8190b0a2a x-ms-traffictypediagnostic: AM0PR05MB5921: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2276; x-forefront-prvs: 0445A82F82 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QBWfuFzaEP1TA8wERKgRGuLUUxRgbE2J92dLqzr+xzxgl+MeOmjIF1LXG8efUmcvSInDJVUqdulkVKUTLw6JYcGn7shr+Gjd0vxiDm/q36N/1eOitqosmWQ5rX6bsHRzr5oVpp4YaxmImUh2rMDjtfFluO+aHLKwjvjuP4icoIwInKJ0JDB7moR43Y/X169o1rhHkYi7nTU+nCCI06YWzErjSBhN7FwWkM31barJVkQZ98hkYnZEOZneJitZj031vwUabZx1wjvMG36ObrMJ/S6BKu2tqS3WuaOjrz0Fa67kcxaO4jR6RSk1AZxriqZl57aUDQewliBERSNm2ppLcA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB5313.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(39860400002)(346002)(396003)(136003)(71200400001)(66446008)(83380400001)(76116006)(4326008)(64756008)(66476007)(66946007)(7696005)(2906002)(8676002)(55016002)(478600001)(316002)(52536014)(9686003)(6506007)(7416002)(5660300002)(86362001)(66556008)(186003)(26005)(8936002)(54906003)(33656002)(6916009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 0zlhbZMaDGahAql60WiXEFn8JL5ltQxPMY31B9PMEeTGNuQvdG+/B1SgLqMKBS3PzcmK4+pPwTsNFFOhWqUHxHHAU68dBlMV0KxBbKy9ZRdDv+uKOxw6pFInIlUqGYBTMCV5Sg0xtumNFjxeAuTPiCNGgrXkBh1gYJdRHyFyVbA2uAMbYITXgAScBNcwxvgVp55EFhsjM3IkGFm+WT3AizUt9UdVEeJJHDpalcUvNyD7aFYtWQi0NhlShDDAnRUJiQUeYAQShn054NtNCuHDC0ye+FNC0Wvys5jjd5KG4jvOB3G4hdtJV+chSJDdJB6ivrm1uAF+apdSUxkWW35DPNo7oL+ipdJT4d127z5DSvkIZ/+olfIoZ1hK50EzMPmvqUyyZ+NisNY29cPeLkAnZwUK51J/Rn0j80n0dXsZ3tc5aT/JwRAVbzHwGAWseoRK5AHokgi8kV0VrNwi6MdmZTdaHIvl62CHukaTNYlGKjs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB5313.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50b34a1d-5f27-402e-de2f-08d8190b0a2a X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2020 13:24:07.7772 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8/DIhRLJOSnhe0FuDlm6h6DueK3YJF6e9lWC2Oli5cbcmGBJWY4FgnHyex13GQtJ0Xe2rRze4eGzw/GaVRGCAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5921 Subject: Re: [dpdk-dev] [PATCH 2/4] eal: set byteorder in Windows to little endian X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [dpdk-dev] [PATCH 2/4] eal: set byteorder in Windows to litt= le > endian >=20 > 01/06/2020 11:38, talshn@mellanox.com: > > From: Tal Shnaiderman > > > > Set the endianness in Windows to RTE_LITTLE_ENDIAN as support for > > Windows is limited to x86 architecture for now. > > > > Signed-off-by: Tal Shnaiderman > > --- > > --- a/lib/librte_eal/include/generic/rte_byteorder.h > > +++ b/lib/librte_eal/include/generic/rte_byteorder.h > > #ifdef RTE_EXEC_ENV_FREEBSD > > #include > > -#else > > +#elif defined RTE_EXEC_ENV_LINUX > > #include > > +#elif defined RTE_EXEC_ENV_WINDOWS && !defined RTE_BYTE_ORDER >=20 > Why "&& !defined RTE_BYTE_ORDER" ? > How can it be defined earlier? >=20 You're right, it's unneeded since it is defined later on. The entire "#elif defined RTE_EXEC_ENV_WINDOWS" section could be removed ac= tually,=20 looks like both clang and MinGW contain the predefined __BYTE_ORDER__ macro= and detect the right endianness on compile time. > > +#define RTE_BYTE_ORDER RTE_LITTLE_ENDIAN > > #endif >=20 >=20 >=20