From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7C21A0350; Tue, 30 Jun 2020 16:09:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FA9A1BEA7; Tue, 30 Jun 2020 16:09:58 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70080.outbound.protection.outlook.com [40.107.7.80]) by dpdk.org (Postfix) with ESMTP id 638281BE99 for ; Tue, 30 Jun 2020 16:09:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EQ0psPjCWJGkP3GdsZsjf1gTdSTjgo4NcFkddmYVuq38mrmRPgvjjOY2nZqRh2kQmM6gp7ZFhv2AC4pkGKojRac3shNp8AwZE5u8BI/38gMDBNS5eZJcUWoSNaNMTsk7TgCRPVaLq+sCFtA59alNpiDiaptfZUyMsqym3auTbOZv4DofZLRekDKbJw5DNBUCF80hxtEE/CygANiGqTr3IZkA83hpyklW4/6ylYTTZdbM3lT4P1PEo/W4GJZWkpq4aqzNCObubxdVrtHeQfKu8r/Iw+FpCsvZfNyo4UO3g+OjjkvjoJK3CzsUQntSqyniG37fSINo1wdUFXFa/+f1nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JviCwtVONGKrgUc/txTo6OvS5TQ3+4RgFA1uZ+er9SE=; b=io+mtc+mqJGulfH0vbdOZ4IM3ppNStYEosfp6NrZNYycHUaAg144Nm+qqIGSUKKzYB1biKmph5ZwgFtn6w6T709AcoYm0yMHH3w3jO096Rn/o3DWffFvEYmKhZGv+RUzC4QS/YftSzbZ8YLOaSpweFM2cD1k05icpkC39O113MkMsT1bJ7GjMWtJZHznkqig1ENht/a/OI2cYMD5tIB8RJQzrHBUjomLx9Az+J/jkAyE0sDmA9xWcXxBP9TqrpcGHWqdRXttopdN/9AejnnI9sWe5tBRb2gGr1DwzPufmjbXTa1o5GOw2j3BzVUbcXvE/Y/MFlLZ8F8iiETDmWIesQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JviCwtVONGKrgUc/txTo6OvS5TQ3+4RgFA1uZ+er9SE=; b=bfL26ck0QHWJR4iX81tj7kb7xKy6j6GiKqNj1KjLhL+JoWqCuVOH3lNJDiK/DtoU0h72sx/eYZdEI/aN7imHZgc4QiNGz2L4Ahzk0ByyFVo+rbC43hgDvmd55d4SLosbJU7efH+LPsBRoP6L/G0ChlRcL1dGFj9BLiwy3sz1ZBw= Received: from AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18) by AM0PR05MB4964.eurprd05.prod.outlook.com (2603:10a6:208:c6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Tue, 30 Jun 2020 14:09:55 +0000 Received: from AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::103:d46f:87df:6525]) by AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::103:d46f:87df:6525%7]) with mapi id 15.20.3131.028; Tue, 30 Jun 2020 14:09:55 +0000 From: Wisam Monther To: Lijun Ou , "dev@dpdk.org" , "ferruh.yigit@intel.com" CC: "linuxarm@huawei.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: update uninitialized member when set fwd mode Thread-Index: AQHWTuIk179KAR5xYUiieSUhf2ecVKjxMZCQ Date: Tue, 30 Jun 2020 14:09:54 +0000 Message-ID: References: <1593523512-18096-1-git-send-email-oulijun@huawei.com> In-Reply-To: <1593523512-18096-1-git-send-email-oulijun@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b1666778-e78e-46fb-5897-08d81cff43a6 x-ms-traffictypediagnostic: AM0PR05MB4964: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:608; x-forefront-prvs: 0450A714CB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jAc+iIfjd947wgHiJRkXrbwLvlBp//HNM0eSR7i2YypFYOl0e7VhDkjqWvAXegjhaqXkLv9KHLBkePLpyPuCrzsZ6P9e/u1gJr/f1X2yEKZdDoRaTBqcgGPMuYy1sC5eHazu5hvIgosMpL331jbfWTESoNtnO6e6hF2y5zkmKoyBxoLzG0IAWT0JyaZLkkocTjgu8FqPomu4DN02q0/61vlmITzw9R+2E3MfXeNvidKhQkTY5hvXQzpeZDJMBndzXFMI5K2pA6jbxU6pfZN3jfe09u0yx/D9/oVq0FmqdCM2DmXbw/O8bAicev4kj9ahp9GMsZBzCjmAaiikqNL3SISRDcAGGlqKir225Gq6kDTrP4lDQewFagt2wYfiEVSo x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6610.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(346002)(396003)(376002)(136003)(366004)(7696005)(8936002)(316002)(478600001)(2906002)(66476007)(66556008)(64756008)(66446008)(9686003)(15650500001)(33656002)(55016002)(66946007)(76116006)(86362001)(110136005)(26005)(5660300002)(83380400001)(52536014)(4326008)(186003)(71200400001)(6506007)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: PopPz4Bp3NRBdMHe3lT4lTCFJl5BUgAwIQUFA1YW+Z/LjZ77f+8N9OqRFOnPRxHwTntOWay436FsSJ3RdnaCZaZIfD6vP2xU/YLMSN0FirYFiZIT0o8hnMw20hRYgRmXIYA/7Zj1EvXamDKCTq7k1hP61CmhSKXpEJb6kvgNVE4SHBRok4YfqNMCNthndZ2oXj78uCQepT8tHbyqWaSROqyE0ED3W0QZtTa7UtM7jz5PJOIw8vXa10ZiUPuoUNOYlINZpQu6GUSfFAlmK0ujTVw2PNcm9kzyTfyyej4b7If+JRMwjlDYjSFDRjefMayFEHhugG3v+vCzhLCVVA5LzM54g0Y61vam8enLHp7vyKlsR69uEy4KoIuqfrGrMbPByxc8dHnMYMwDXzSICOM3acYlhvrZJspBVLAZGJA6xbuj6lRt4/rgnGSPFzAx4aUmx6W81ZTqV808P/2qJAu50ZjDPhoPTMGbUqRcIj6kryY= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6610.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1666778-e78e-46fb-5897-08d81cff43a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2020 14:09:54.8679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3+6GVnI2Sv0eBc/8bb7bBkBTvZm6ZVCknwtUvG9DJHzUaAkgWcbhT6T60wQneoYgXRhto66qB69wtcZUTaw7bA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4964 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: update uninitialized member when set fwd mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Lijun, >-----Original Message----- >From: dev On Behalf Of Lijun Ou >Sent: Tuesday, June 30, 2020 4:25 PM >To: dev@dpdk.org; ferruh.yigit@intel.com >Cc: linuxarm@huawei.com >Subject: [dpdk-dev] [PATCH] app/testpmd: update uninitialized member >when set fwd mode The member is actually initialized before so I think the title somehow misl= eading, What about: "fix missing set for current forward engine"=20 > >When set the forwarding mode of the pkt, it needs to update the fwd_eng >that it is the member of cur_fwd_config. Otherwise, an error will occur wh= en >executing the set command and show confg fwd. >the flows as follows: > 1. ./tespmd -w xxx -l xx -n 4 -- i > 2. set fwd mac > testpmd> set fwd mac > Set mac packet forwarding mode > > 3. show config fwd > testpmd> show config fwd > io packet forwarding - ports=3D1 - cores=3D1 - streams=3D8 -... > Logical Core 1 (socket 0) forwards packets on 8 streams: > >When run the 1 ~ 3 step, it should show the packet forwarding is mac. I think this should be consider as a fix, and you need to add the fixed com= mit and cc It's auther > >Signed-off-by: Lijun Ou >--- > app/test-pmd/config.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index >a7112c9..ee0e904 100644 >--- a/app/test-pmd/config.c >+++ b/app/test-pmd/config.c >@@ -3158,6 +3158,7 @@ set_pkt_forwarding_mode(const char >*fwd_mode_name) > fwd_mode_name, > retry_enabled =3D=3D 0 ? "" : " with retry"); > cur_fwd_eng =3D fwd_eng; >+ cur_fwd_config.fwd_eng =3D fwd_eng; > return; > } > i++; >-- >2.7.4