DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine
@ 2020-07-01  7:43 Lijun Ou
  2020-07-02  8:11 ` Wisam Monther
  2020-07-02 15:03 ` Phil Yang
  0 siblings, 2 replies; 5+ messages in thread
From: Lijun Ou @ 2020-07-01  7:43 UTC (permalink / raw)
  To: wenzhuo.lu, beilei.xing, bernard.iremonger, ferruh.yigit; +Cc: dev, linuxarm

When set the forwarding mode of the pkt, it needs to update
the fwd_eng that it is the member of cur_fwd_config. Otherwise,
an error will occur when executing the set command and show
confg fwd.
the flows as follows:
   1. ./tespmd -w xxx -l xx -n 4 -- i
   2. set fwd mac
      testpmd> set fwd mac
      Set mac packet forwarding mode

   3. show config fwd
      testpmd> show config fwd
      io packet forwarding - ports=1 - cores=1 - streams=8 -...
      Logical Core 1 (socket 0) forwards packets on 8 streams:

When run the 1 ~ 3 step, it should show the packet forwarding is
mac.

Fixes: af75078fece3 ("first public release")
Cc: wenzhuo.lu@intel.com
Cc: beilei.xing@intel.com
Cc: bernard.iremonger@intel.com
Cc: stable@dpdk.org

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
v2:
-- fix the title
-- add fixes and Cc
---
 app/test-pmd/config.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index a7112c9..ee0e904 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3158,6 +3158,7 @@ set_pkt_forwarding_mode(const char *fwd_mode_name)
 			       fwd_mode_name,
 			       retry_enabled == 0 ? "" : " with retry");
 			cur_fwd_eng = fwd_eng;
+			cur_fwd_config.fwd_eng = fwd_eng;
 			return;
 		}
 		i++;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine
  2020-07-01  7:43 [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine Lijun Ou
@ 2020-07-02  8:11 ` Wisam Monther
  2020-07-02 15:03 ` Phil Yang
  1 sibling, 0 replies; 5+ messages in thread
From: Wisam Monther @ 2020-07-02  8:11 UTC (permalink / raw)
  To: Lijun Ou, wenzhuo.lu, beilei.xing, bernard.iremonger, ferruh.yigit
  Cc: dev, linuxarm

Hi,


>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
>Sent: Wednesday, July 1, 2020 10:43 AM
>To: wenzhuo.lu@intel.com; beilei.xing@intel.com;
>bernard.iremonger@intel.com; ferruh.yigit@intel.com
>Cc: dev@dpdk.org; linuxarm@huawei.com
>Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current
>forward engine
>
>When set the forwarding mode of the pkt, it needs to update the fwd_eng that
>it is the member of cur_fwd_config. Otherwise, an error will occur when
>executing the set command and show confg fwd.
>the flows as follows:
>   1. ./tespmd -w xxx -l xx -n 4 -- i
>   2. set fwd mac
>      testpmd> set fwd mac
>      Set mac packet forwarding mode
>
>   3. show config fwd
>      testpmd> show config fwd
>      io packet forwarding - ports=1 - cores=1 - streams=8 -...
>      Logical Core 1 (socket 0) forwards packets on 8 streams:
>
>When run the 1 ~ 3 step, it should show the packet forwarding is mac.
>
>Fixes: af75078fece3 ("first public release")
>Cc: wenzhuo.lu@intel.com
>Cc: beilei.xing@intel.com
>Cc: bernard.iremonger@intel.com
>Cc: stable@dpdk.org
>
>Signed-off-by: Lijun Ou <oulijun@huawei.com>

Acked-by: Wisam Jaddo <wisamm@mellanox.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine
  2020-07-01  7:43 [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine Lijun Ou
  2020-07-02  8:11 ` Wisam Monther
@ 2020-07-02 15:03 ` Phil Yang
  2020-07-03  1:31   ` Phil Yang
  2020-07-15 10:35   ` Phil Yang
  1 sibling, 2 replies; 5+ messages in thread
From: Phil Yang @ 2020-07-02 15:03 UTC (permalink / raw)
  To: Lijun Ou, wenzhuo.lu, beilei.xing, bernard.iremonger, ferruh.yigit
  Cc: dev, linuxarm

Hi Lijun,

Some comments inline.

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
> Sent: Wednesday, July 1, 2020 3:43 PM
> To: wenzhuo.lu@intel.com; beilei.xing@intel.com;
> bernard.iremonger@intel.com; ferruh.yigit@intel.com
> Cc: dev@dpdk.org; linuxarm@huawei.com
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current
> forward engine
>
> When set the forwarding mode of the pkt, it needs to update
> the fwd_eng that it is the member of cur_fwd_config. Otherwise,
> an error will occur when executing the set command and show
> confg fwd.
> the flows as follows:
>    1. ./tespmd -w xxx -l xx -n 4 -- i
>    2. set fwd mac
>       testpmd> set fwd mac
>       Set mac packet forwarding mode
>
>    3. show config fwd
>       testpmd> show config fwd
>       io packet forwarding - ports=1 - cores=1 - streams=8 -...
>       Logical Core 1 (socket 0) forwards packets on 8 streams:

I think we need to stop the running engine then start the new engine to make the configuration work.
The Testpmd can't switch forward engine on runtime. When it is forwarding packets, the standing operating procedures should be:
1. testpmd> set fwd mac
2. testpmd> stop
3. testpmd> start

We can add a patch to document this standing operating procedure.
Or we can refactor the set_pkt_forwarding_mode API to support this feature. I prefer this approach.

>
> When run the 1 ~ 3 step, it should show the packet forwarding is
> mac.
>
> Fixes: af75078fece3 ("first public release")
> Cc: wenzhuo.lu@intel.com
> Cc: beilei.xing@intel.com
> Cc: bernard.iremonger@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
> v2:
> -- fix the title
> -- add fixes and Cc
> ---
>  app/test-pmd/config.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index a7112c9..ee0e904 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -3158,6 +3158,7 @@ set_pkt_forwarding_mode(const char
> *fwd_mode_name)
>         fwd_mode_name,
>         retry_enabled == 0 ? "" : " with retry");
>  cur_fwd_eng = fwd_eng;
> +cur_fwd_config.fwd_eng = fwd_eng;

When you stop and restart the forwarding engine, it overwrites by the old engine.

Thanks,
Phil
>  return;
>  }
>  i++;
> --
> 2.7.4

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine
  2020-07-02 15:03 ` Phil Yang
@ 2020-07-03  1:31   ` Phil Yang
  2020-07-15 10:35   ` Phil Yang
  1 sibling, 0 replies; 5+ messages in thread
From: Phil Yang @ 2020-07-03  1:31 UTC (permalink / raw)
  To: Phil Yang, Lijun Ou, wenzhuo.lu, beilei.xing, bernard.iremonger,
	ferruh.yigit
  Cc: dev, linuxarm, nd

<Sinp>
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.

My bad.
Add nd@arm.com to fix this email system issue.

Thanks,
Phil

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine
  2020-07-02 15:03 ` Phil Yang
  2020-07-03  1:31   ` Phil Yang
@ 2020-07-15 10:35   ` Phil Yang
  1 sibling, 0 replies; 5+ messages in thread
From: Phil Yang @ 2020-07-15 10:35 UTC (permalink / raw)
  To: Lijun Ou, wenzhuo.lu, beilei.xing, bernard.iremonger, ferruh.yigit
  Cc: dev, linuxarm, nd, Wisam Monther, nd

<snip>

> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
> > Sent: Wednesday, July 1, 2020 3:43 PM
> > To: wenzhuo.lu@intel.com; beilei.xing@intel.com;
> > bernard.iremonger@intel.com; ferruh.yigit@intel.com
> > Cc: dev@dpdk.org; linuxarm@huawei.com
> > Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current
> > forward engine
> >
> > When set the forwarding mode of the pkt, it needs to update
> > the fwd_eng that it is the member of cur_fwd_config. Otherwise,
> > an error will occur when executing the set command and show
> > confg fwd.
> > the flows as follows:
> >    1. ./tespmd -w xxx -l xx -n 4 -- i
> >    2. set fwd mac
> >       testpmd> set fwd mac
> >       Set mac packet forwarding mode
> >
> >    3. show config fwd
> >       testpmd> show config fwd
> >       io packet forwarding - ports=1 - cores=1 - streams=8 -...
> >       Logical Core 1 (socket 0) forwards packets on 8 streams:
> 
> I think we need to stop the running engine then start the new engine to
> make the configuration work.
> The Testpmd can't switch forward engine on runtime. When it is forwarding
> packets, the standing operating procedures should be:
> 1. testpmd> set fwd mac
> 2. testpmd> stop
> 3. testpmd> start
> 
> We can add a patch to document this standing operating procedure.
> Or we can refactor the set_pkt_forwarding_mode API to support this
> feature. I prefer this approach.
> 
> >
> > When run the 1 ~ 3 step, it should show the packet forwarding is
> > mac.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: wenzhuo.lu@intel.com
> > Cc: beilei.xing@intel.com
> > Cc: bernard.iremonger@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Lijun Ou <oulijun@huawei.com>
> > ---
> > v2:
> > -- fix the title
> > -- add fixes and Cc
> > ---
> >  app/test-pmd/config.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> > index a7112c9..ee0e904 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -3158,6 +3158,7 @@ set_pkt_forwarding_mode(const char
> > *fwd_mode_name)
> >  			       fwd_mode_name,
> >  			       retry_enabled == 0 ? "" : " with retry");
> >  			cur_fwd_eng = fwd_eng;
> > +			cur_fwd_config.fwd_eng = fwd_eng;
> 
> When you stop and restart the forwarding engine, it overwrites by the old
> engine.


Please check the code below. 

-                      cur_fwd_eng = fwd_eng;
+                      if (cur_fwd_config.fwd_eng != cur_fwd_eng) {
+                              cur_fwd_eng = fwd_eng;
+                              fwd_config_setup();
+                      }

If people like this fix, I can add a patch for it.


> >  			return;
> >  		}
> >  		i++;
> > --
> > 2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-07-15 10:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01  7:43 [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine Lijun Ou
2020-07-02  8:11 ` Wisam Monther
2020-07-02 15:03 ` Phil Yang
2020-07-03  1:31   ` Phil Yang
2020-07-15 10:35   ` Phil Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).