From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 718E6A00C4; Sun, 10 May 2020 14:48:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 02F901D505; Sun, 10 May 2020 14:48:45 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150070.outbound.protection.outlook.com [40.107.15.70]) by dpdk.org (Postfix) with ESMTP id 99F9D1D181 for ; Sun, 10 May 2020 14:48:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MIQG+OV770AhXwD7DymMkJ0cmDif8oTzjn4g4Rk9NTYxoG8OIdWRSjFWHeYm/acXndUuGNWyE6hkc+XlJMGj8ZsFv/D4IR1QpYL23tF7kZfscLKRR0hGjfWA6p/+49tHjkNjVkn5rl+Mjm+Fy5xTwegNKcuCs/PAwNFyJrdrEGRMUaG9sXtahgybf9CNe0omqHuOIC62rEW9BV7W9uZqkL+UpYUSJhMokuQLm4w+Z1BNv0KNrsgOz8wj6EJTyKAWi0FogrI/Vvlq5rt6QljhELlRDt/fnFusoBLFefe+ZI068UT1HBgNfY5vmZzCKNyNHEYaCPlkDJXFs52uuhWxYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lotAaFpWDF+UTEeG0oPVNqefOogrphBdps86j9IOWrM=; b=M/AeqQpT2U+eJanPy/c5XY9OP03gUmY3LMn3xeiZ/TNKkEB1mEEhVhecR0yxTqpxNpu1copZqu1QlVODJ3kdThTJpBG2TY4OMTfM8TZcK/BUTo6oBT+fk3eyS3VCPtqV9FjEBcQN7ALgJe87t1ooR5uJSy3+Kllm8r0GY8dOmguc7LVLchU95LJ5MaNe4r105a1klaooQejSvgEPazdOOeedfUWPddJWsut76BsnRsPlOYXhgyEg704W247S4iu+sn9kFS3ZuQ6ld7LXSIxAHEm268Jm3oimoa8oYEs9xhBRIrUTQ8TgVz68ORBSRCXOGesbGHHlsyI6non8CjYz7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lotAaFpWDF+UTEeG0oPVNqefOogrphBdps86j9IOWrM=; b=jmvR3dkCH9IbKhwqRQKGdEVjeZcVJ8eVvd/oM77F+cKv3ar8tuap2t2g5u1G8SK/iw02pq5knwQ6ExYE9iahvZ6z5CEvJGNSWeUo4VrNZZ/8rDRNN4PRBNKGfjBi26G7bFlpaUppa133lckp6xhqgQSe+kTG65psNfb5BctVFNk= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4900.eurprd05.prod.outlook.com (2603:10a6:208:cb::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.30; Sun, 10 May 2020 12:48:41 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%5]) with mapi id 15.20.2979.033; Sun, 10 May 2020 12:48:41 +0000 From: Raslan Darawsheh To: Raslan Darawsheh , "ferruh.yigit@intel.com" CC: "dev@dpdk.org" , "stephen@networkplumber.org" Thread-Topic: [PATCH] net/tap: fix compilation issue with old kernels Thread-Index: AQHWJFRULquRGz2HP0m/Y9r5yfspzKihSd9Q Date: Sun, 10 May 2020 12:48:41 +0000 Message-ID: References: <20200507094529.7117-1-rasland@mellanox.com> In-Reply-To: <20200507094529.7117-1-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.229.217] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 064dfcd2-dce2-489a-19ee-08d7f4e077d2 x-ms-traffictypediagnostic: AM0PR05MB4900:|AM0PR05MB4900: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:549; x-forefront-prvs: 039975700A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rp4E2f2y4A+qTz+fLn64w7ARf3vJTfS7e6PJDgJJH6Y31Ju0iBrBm4cRTbBWO5YIaULcBH0HZlOou4b7NHDbcBGYqqDK1NB1Quj0cF4YoCWcpx9+V01sdcA1x+QXn8ZvR92ZiiMugE8LQZUGmFD02R4KLA2HrryyutrBCN1p+lR0QJv8E1njhw0qFDNZ2daJ9eJMzaKNqZ1M2/119Cx+TFaDP0SmzJv9meESlYZGVU1EAwFe1ph71vyFDKIPel09TbOZvbDN6CbqGv2eGV5ufixGe5cTZK+YJnIMoV6sN+Pca9YE1yUHVOtrESRENolFN/taBhdBgWZ1ev0P972ZkG6XsfsvJZziFA99M4EXW+Gy/Jh45opS2fMtSauXg3QaophT4Dbyq41TO2vsYgVrx1mIinWb91R4wV5Mx3auIRhDr5cb4zWZ6xhvXbdziZSqzkMgJX/0koUUXHwe6oIuVvcLt92Nx2u7FwlJoWW6CHKkI00iIjpTDUnWdhu0ouX2gTX9i/sQshpgipUPdRZrCJL4K+pv2dAaaF0YTWzIXBT9+mOrNGx9mr0bfb4DBEuYt96gaae4SCQUv7S5zMxRC7rTtk/3oqYNy1w2HVCFKaM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(39860400002)(346002)(136003)(396003)(33430700001)(55016002)(66446008)(9686003)(53546011)(316002)(33440700001)(26005)(66556008)(52536014)(33656002)(186003)(66476007)(8936002)(2906002)(64756008)(6506007)(478600001)(110136005)(66946007)(4326008)(5660300002)(86362001)(71200400001)(54906003)(8676002)(966005)(76116006)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: JhA0fKfivilze5siIvGE480wFntNpDbxe8iR0BoMfbmX/dxKG8LAgRxti3yf1lv0LxHenF4CfRUeaYJaQkFn/qXhIbh3Fyq5F62yTw1eTagbCUyHw4MWph5q78eRH+jQg4J+rxZy39jfFjD/SeB+vPiuJaezPj9ja5PzaxsbNwk9dqpVHj83u4cnbq7qUoGCHEg+7wJON4w4kCweQszF+4BxM8s6/oLvfA+gJNZSlZL0eCJ/DsWsaVjuN2WuqiT3RTIvqDeQryj5eP5lZi0ubow8CnJpzR0axZYL69DUw2IB8xT56u4UrlIgbxO+Fa/0aXwREYhEQ9cuabNEGggTzWjwZzQcbYxc65ITKNyEfxK4ijSFWzkje9Cse+UthTtOmafLbuWjQd9SqyK44xhWTXh65oxuvGTJKRrh4ylrTeDz12G0wwKggLih8SwDBzeaoH6SmYiMLya8acDpzVKalAgxXcUgYNRjd6Te/8nCh0EN0/IKAF2vgtdSE1nWYOh5 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 064dfcd2-dce2-489a-19ee-08d7f4e077d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2020 12:48:41.5348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kAT20V9yOLJOjYvI56bZeTpY4g55BKeVmxlputNLNxPOLZreWpERJUMu//zU8gE692QRTpbG9rojQOh9waFnqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4900 Subject: Re: [dpdk-dev] [PATCH] net/tap: fix compilation issue with old kernels X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" reference to glibc which is missing from commit log: https://github.com/bminor/glibc/commit/f9b437d5efce93800b51ad2a437c8b1c9616= bf80 Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Raslan Darawsheh > Sent: Thursday, May 7, 2020 12:46 PM > To: ferruh.yigit@intel.com > Cc: dev@dpdk.org; stephen@networkplumber.org > Subject: [PATCH] net/tap: fix compilation issue with old kernels >=20 > With old kernels that don't have support for extended ack > the variable one is not used which will cause a compilation > failure: > drivers/net/tap/tap_netlink.c:48:6: > error: unused variable 'one' [-Werror=3Dunused-variable] > int one =3D 1; > ^~~ > cc1: all warnings being treated as errors > Fixes: f11e38d90980 ("net/tap: use netlink extended ack support") > Cc: stephen@networkplumber.org >=20 > Signed-off-by: Raslan Darawsheh > --- > drivers/net/tap/tap_netlink.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/tap/tap_netlink.c b/drivers/net/tap/tap_netlink.= c > index a77486d8e..b73802b51 100644 > --- a/drivers/net/tap/tap_netlink.c > +++ b/drivers/net/tap/tap_netlink.c > @@ -45,7 +45,9 @@ tap_nl_init(uint32_t nl_groups) > .nl_family =3D AF_NETLINK, > .nl_groups =3D nl_groups, > }; > +#ifdef NETLINK_EXT_ACK > int one =3D 1; > +#endif >=20 > fd =3D socket(AF_NETLINK, SOCK_RAW | SOCK_CLOEXEC, > NETLINK_ROUTE); > if (fd < 0) { > -- > 2.26.0