From: Raslan Darawsheh <rasland@mellanox.com>
To: Ali Alnubani <alialnu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Suanming Mou <suanmingm@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build
Date: Sun, 19 Jul 2020 15:17:14 +0000 [thread overview]
Message-ID: <AM0PR05MB67071153ED6B9FA5DA8D2FC8C27A0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200719115153.19586-1-alialnu@mellanox.com>
Hi,
> -----Original Message-----
> From: Ali Alnubani <alialnu@mellanox.com>
> Sent: Sunday, July 19, 2020 2:52 PM
> To: dev@dpdk.org
> Cc: Suanming Mou <suanmingm@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>
> Subject: [PATCH] common/mlx5: fix mlx5 build
>
> This fixes the following build errors by adding 2
> missing header includes:
>
> ```
> drivers/common/mlx5/linux/mlx5_glue.c: In function
> 'mlx5_glue_destroy_flow_action':
> drivers/common/mlx5/linux/mlx5_glue.c:187:2: error: implicit declaration
> of function 'mlx5_free' [-Werror=implicit-function-declaration]
> mlx5_free(action);
> ^
> ...
> drivers/common/mlx5/linux/mlx5_glue.c:620:46: error: 'SOCKET_ID_ANY'
> undeclared (first use in this function)
> action = mlx5_malloc(0, sizeof(*action), 0, SOCKET_ID_ANY);
> ...
> ```
>
> The build error reproduces on Ubuntu 16.04 with rdma-core version v22.1
> and
> with gcc version 5.4.0.
>
> Fixes: 0e25e18bfba9 ("common/mlx5: convert control path memory to
> unified malloc")
> Cc: suanmingm@mellanox.com
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
> drivers/common/mlx5/linux/mlx5_glue.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/common/mlx5/linux/mlx5_glue.c
> b/drivers/common/mlx5/linux/mlx5_glue.c
> index ea9c86b3a..fcf03e867 100644
> --- a/drivers/common/mlx5/linux/mlx5_glue.c
> +++ b/drivers/common/mlx5/linux/mlx5_glue.c
> @@ -8,6 +8,7 @@
> #include <stddef.h>
> #include <stdint.h>
> #include <stdlib.h>
> +#include <rte_memory.h>
> /*
> * Not needed by this file; included to work around the lack of off_t
> * definition for mlx5dv.h with unpatched rdma-core versions.
> @@ -15,6 +16,7 @@
> #include <sys/types.h>
>
> #include "mlx5_glue.h"
> +#include "../mlx5_malloc.h"
>
> static int
> mlx5_glue_fork_init(void)
> --
> 2.27.0
Patch squashed into relevant commit in master-net-mlx,
Kindest regards,
Raslan Darawsheh
next prev parent reply other threads:[~2020-07-19 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 11:51 Ali Alnubani
2020-07-19 15:17 ` Raslan Darawsheh [this message]
2020-07-20 8:24 ` David Marchand
2020-07-20 8:38 ` Raslan Darawsheh
2020-07-20 8:51 ` David Marchand
2020-07-20 8:59 ` Raslan Darawsheh
2020-07-20 12:23 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB67071153ED6B9FA5DA8D2FC8C27A0@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=suanmingm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).