From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CD1FA0540; Sun, 19 Jul 2020 17:17:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AECE31C10F; Sun, 19 Jul 2020 17:17:16 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80]) by dpdk.org (Postfix) with ESMTP id 29C7C1C0DC for ; Sun, 19 Jul 2020 17:17:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MX8P7MhpuEAARWHu5tALva40GKkVsy/1AwTAdT6xinQHxPtPa8pyZe9vnJm6kyXvnId2E57iTnOxxKN16yVhH6QZMfl0BbdsgSaRZu1g3nw/uEwt2dfIKuaBWnt7++CwOu81aIXwqR5HcmMSMpNXpbhyqlqkh6cUDGozTEKDfeIgxXpJE7F/eHkwXIyM4OlNwt7EewoHt9L44V1no55uP1f4FJR66Bi+TnKjgQ7mIluaracJCMg9yx0F89aSXPO2SPy2h1+D493bHBwjXs6GQVr+dpsTKy0CoxYkt0qaQca1fVAW+3Opb4O/sOLSljfL4cI/9Zd6OvEHL8OsWw680w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQBylPYe3fEk71TWkPNxVXmFlIWKzcpqA0t9S4Pdx70=; b=Knv+kIw49YZnxRh2lQzgZeUi1e8WdjsUUX8WoDA6svPiEzQdT+qUPV/uLL07t5loqzEbcnDapEIf5HxS6OVV+o043Q7M4rKKFOqoGVCaxaB3TLSzI8k4vMn0okg9DZ1X0n91p8JxP8Tn4eQwzJVRCYv1ULJCP2Vuvb5RMCEElgymYZ41KCberCtERYTjmkrw6RKjz+i3K7562xv1p4iX4tmm/hbVGkwBvrivB5zvmJJM3wkdhaEA2/QkL5N/pWrjacHxT1vlphLw68jBKVtwwReHZy55QZDrHb2tG8578UjPQskNaQgqbYZQuwboE9ryyMebs42gbtWBeDFrOYAXBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQBylPYe3fEk71TWkPNxVXmFlIWKzcpqA0t9S4Pdx70=; b=MLboydJ7jigzE9yGzOUlGNK1FTwPCU6CWBtkxaWcPY3Y7z82uBG0FTSUKHy1SWo35zWMLGsSmT05WcSPdeykFb2swP+H+cC18fVdOwbGj3Fv+NwHTq/169biaWEcmrpFDxPGFC5HZi5RJ4KuvodhYdaQWxeqWNll51BFO7rE5hM= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5362.eurprd05.prod.outlook.com (2603:10a6:208:ea::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Sun, 19 Jul 2020 15:17:14 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.024; Sun, 19 Jul 2020 15:17:14 +0000 From: Raslan Darawsheh To: Ali Alnubani , "dev@dpdk.org" CC: Suanming Mou Thread-Topic: [PATCH] common/mlx5: fix mlx5 build Thread-Index: AQHWXcMSZvfWRr8U9kaH+WiHEzhhLqkPAuFQ Date: Sun, 19 Jul 2020 15:17:14 +0000 Message-ID: References: <20200719115153.19586-1-alialnu@mellanox.com> In-Reply-To: <20200719115153.19586-1-alialnu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c301a830-f8ba-4a5a-45bd-08d82bf6d156 x-ms-traffictypediagnostic: AM0PR05MB5362: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:299; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SZsMHFeGch1CPKtqNIyuZkoD5UUbizjDD9V0EBqFvCr7tzPkxH+yz0JwdxkKaSM98th5EinNng6CoJnEAtD7lFLdJ4JJX8943IECssLciSv3F4Rn4xhrZ0uZa30MbKWy8j8XFt0VQt5lVN5HXa3j5qd+t79vcCD4OD7mWO7JBluhZHYL4CX4dWI8fY6h6aTQBfGfMvED5jwoZZzvt4xRlu+fAomMcXfhXtw6Jf0zJknDX/O+46gGTioWGsv1Vk2RE6BXKfOrkvQ+IiTYMVnORMOP3MDBTXadN+raZTnC5gce+t0PxHvLwZy8aA8qMNM+MdO1tJGl1Er5Y3Yx4tpycw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(366004)(376002)(396003)(39860400002)(52536014)(83380400001)(55016002)(8936002)(186003)(9686003)(316002)(107886003)(5660300002)(110136005)(33656002)(2906002)(8676002)(76116006)(86362001)(7696005)(66556008)(66476007)(66946007)(66446008)(64756008)(478600001)(71200400001)(4326008)(6506007)(53546011)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: nQlJ5RKQ291477OxupLOz/1epYUQKecRCj17GbdFqdpIpQU6Vch4MN+UJvcRV6ydRYbGuY8KdNlil9h9et6ouZ9nUx38VQd9nXUxQAea2zp9f4uEsCCQJR5ZBLFY2ZAV+3/h9nQDHSXfreHK6inTE6E6G0tq8enu1pEa8VwZCFHmFj6HBfO03XoBn/6URaJZwFyB1FF4nuYpGAqcvBDWyoWzYtHIP9WIHlExs44HUeo1xhapiR436i5efKHYU7IKRnZqdC4X6QwBGZHhvkTtlCxGAKUGuiMkFFf3bnm0xz3aIAn14V6cliPGU4AxIhcSFmnQIpg8edarH19M3kpmHlMKCxsndET3abkFqCyUwk0BdLW3wZIADMf2WTRlegNN4qqqfKTlKT7q7oXjmM5wOr1BOBuchr02RCnR5fnADmvgvFUxl69AUTo6eVpBdhhyn2VpjD87quKjDir21uwsctu+gAFTyK/wljdoB7SCfBkM25wZeqpI+T2JmPj9JmUw Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c301a830-f8ba-4a5a-45bd-08d82bf6d156 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2020 15:17:14.4467 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5+BAKlAdXkNHIxFF5+mEMqRT4milnHzZCWrBHXm78+hf4K2MRyPDpOqCNpa3wYW1YegdAGdnvFAg3YV55d0+7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5362 Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix mlx5 build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Ali Alnubani > Sent: Sunday, July 19, 2020 2:52 PM > To: dev@dpdk.org > Cc: Suanming Mou ; Raslan Darawsheh > > Subject: [PATCH] common/mlx5: fix mlx5 build >=20 > This fixes the following build errors by adding 2 > missing header includes: >=20 > ``` > drivers/common/mlx5/linux/mlx5_glue.c: In function > 'mlx5_glue_destroy_flow_action': > drivers/common/mlx5/linux/mlx5_glue.c:187:2: error: implicit declaration > of function 'mlx5_free' [-Werror=3Dimplicit-function-declaration] > mlx5_free(action); > ^ > ... > drivers/common/mlx5/linux/mlx5_glue.c:620:46: error: 'SOCKET_ID_ANY' > undeclared (first use in this function) > action =3D mlx5_malloc(0, sizeof(*action), 0, SOCKET_ID_ANY); > ... > ``` >=20 > The build error reproduces on Ubuntu 16.04 with rdma-core version v22.1 > and > with gcc version 5.4.0. >=20 > Fixes: 0e25e18bfba9 ("common/mlx5: convert control path memory to > unified malloc") > Cc: suanmingm@mellanox.com >=20 > Signed-off-by: Ali Alnubani > Signed-off-by: Raslan Darawsheh > --- > drivers/common/mlx5/linux/mlx5_glue.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/common/mlx5/linux/mlx5_glue.c > b/drivers/common/mlx5/linux/mlx5_glue.c > index ea9c86b3a..fcf03e867 100644 > --- a/drivers/common/mlx5/linux/mlx5_glue.c > +++ b/drivers/common/mlx5/linux/mlx5_glue.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > /* > * Not needed by this file; included to work around the lack of off_t > * definition for mlx5dv.h with unpatched rdma-core versions. > @@ -15,6 +16,7 @@ > #include >=20 > #include "mlx5_glue.h" > +#include "../mlx5_malloc.h" >=20 > static int > mlx5_glue_fork_init(void) > -- > 2.27.0 Patch squashed into relevant commit in master-net-mlx, Kindest regards, Raslan Darawsheh