From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B90CBA0521; Thu, 23 Jul 2020 15:34:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5318A1BFD7; Thu, 23 Jul 2020 15:34:15 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30061.outbound.protection.outlook.com [40.107.3.61]) by dpdk.org (Postfix) with ESMTP id B8FDE2C6E; Thu, 23 Jul 2020 15:34:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nQNAehE4otp2QpjwNS/yPcRzBli3Am3mvRHKxYAQfjzUnBpVF8bnFmlm7UbLRaDLkVPEH/7TaYp68umvV7RncuDbZSjvq+N/inQ06OKuSPW3OvqvO74aabbOIm8wafhwH8Or17aKAQCaARoj1+EiuxGh/WQ0LFvFNjNxQ6QF5NBV5I42ITmIrHBZNTd2f6iAuVaKcZzwzseIuWx0smXO3YYF4+MiJMoIxptj0HRSQ2MCWkP2A/36SXQPuK225n7qMCRWAHIcYW1PonuNfaQNGqj0tx1O4lJfEa0R5BgScWG7qzQSzJxp80nSH8pxoKD2SKDrJmFmTBDZXBu9wseJDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZqLSgPOyiKUSow49OiYzObFAfTBdxuKOjq7xTE0zHJg=; b=OmQj0CfrAOILWMsrox3kv/GysjjBH3giTyX9VL2t6B8O9MIKq0FJdsnjHrR5jOZzLPmkLufCX0IcC8YCi5Eeb7ioWgV10Z1i+a9VYlTkBgVD+o59LaW+RduqAHZR7sZDATW8oagnwME+dVtsjG/VDbeM8YKdGfd/JKQ3tarItE7Hg1RccLDzcVC6mUlpMEi1FLaa+V5rzJglsnkTkfgfAkjtggC//ZijLx4fuRfk0PzOBNb1Agi5XTMdgsQC+seWvoe1nreV6lnoKuUvuJp5WfXenbY7aIBK0qBgqWdgvsA5k1kGdABwTCmaKFC23CTrvRn28iiDVwQc9K53K/WgOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZqLSgPOyiKUSow49OiYzObFAfTBdxuKOjq7xTE0zHJg=; b=lYuHViy5HByI0wZQc3Fr51QAj0XZcVrgr8bDPbtDU5kQ18dJZDWuNw8gPCiWNeOqz92H40Z3/SHOzJa5A8uM/bDpQYdsdsgztuJhhnGUda7/PlD5NKb7Sg/S571b/v7ZETdzdibrP/KeadveVBbJbQjB50QYFDDq2PvSRsFkQMw= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM4PR0501MB2722.eurprd05.prod.outlook.com (2603:10a6:200:5a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Thu, 23 Jul 2020 13:34:12 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Thu, 23 Jul 2020 13:34:12 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Alexander Kozyrev , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix metadata storing for NEON vectorized Rx burst Thread-Index: AQHWYN+TX7Glkl8hm064p6aPxvwcm6kVKYEA Date: Thu, 23 Jul 2020 13:34:12 +0000 Message-ID: References: <1595501612-21309-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1595501612-21309-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5ad493d4-3ea7-4aaf-c9a9-08d82f0d162f x-ms-traffictypediagnostic: AM4PR0501MB2722: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KnzJvUXml2wGtI8m2DW9bmDGnPgFA8nDOawoM7/TPNQsVJF37ZR6mykuWF/qBkwBmtiIeQkj//BfwpbNB3XFsbaE00MRlPKW50TYpVyfum7c594ZIBzH85an/ZdRRINPu1AnwMknf+tXglVvEZdpjcDrWAjz15kEuZrdGm+NqhCRehAHqhqpBSZRFo5yMTRZdIcCKbS3M43ccRAqE/8RlG6eFhGIEcZqGGy+bsiGr7BTAIyb5XkIPKbO505PvdwYDKpDDwJ+bWehGrT+xLmKNaNIIH90ktJMFjKrCPqVH2nwHyTcnE/i50URvuX5IC31hfAAyqKNqjmZdAcRl+UXkw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(39860400002)(376002)(136003)(366004)(33656002)(86362001)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(5660300002)(52536014)(83380400001)(478600001)(8936002)(8676002)(450100002)(4326008)(71200400001)(2906002)(26005)(55016002)(9686003)(186003)(53546011)(7696005)(316002)(110136005)(54906003)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: somS0r8281a3WYq1a7+Vg3JKdNq86MOroJTvkCIkgUyobD8yLFWAbE6SgxxbEfCxx8K/yJogpzEobReupDOfCjx+cC9sYW5jT6Cupk/TpP+bDlNRBv1ClSzNpfVb+gRug15b3LG3dTydd6If+oKDKrDOILg7iQQ1Wad8GWeN3S3/k+MIKVKk3Tfj6PYd9St16pA2Tug6HO5b3/ZigXfTIllEvLX5aIXVEtmk+7ckIEGTtXKVetIYTPBv8UPU2nEYusieFuyiD8Eiqt0YVtCkO2bj+gya5hkGDXiKTJOauL8Sgdqbu6C+0feM5LdrKgzpG7YwOdduIg9UtBFEgiLomCNZk8WneUclmTL3rtvxioJN44FvvIy08eZGEv/xCbsyx/CjVoBAA9kgzF+YWSDklBKin9NB90jVMHZ89SuMUmN+XGGJnng8HI0oSFjYXqfGMfgMu8yL7owJmWI0omGHxCjegVuKBhE0/SBXVOSPGNQKBr4nX1f8Vc+HVKcVqnGW Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ad493d4-3ea7-4aaf-c9a9-08d82f0d162f X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2020 13:34:12.5101 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /5Q4/VMJlSpVCEyMu/kvQ2lpifv/n0QuAniZXsBL5VnZEubfvs0xcWYyn6MGbvsqKXtTk0A1fR3T+Ax1sdma/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2722 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix metadata storing for NEON vectorized Rx burst X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Thursday, July 23, 2020 1:54 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Alexander Kozyrev ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix metadata storing for NEON vectorized Rx > burst >=20 > There was the typo introducing the bug, affected the mlx5 vectorized > rx_burst on ARM architectures in case if CQE compression was enabled. >=20 > Fixes: 6c55b622a956 ("net/mlx5: set dynamic flow metadata in Rx queues") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > index 6c31495..af924b7 100644 > --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > @@ -736,20 +736,20 @@ > pkt_info)->timestamp); > } > } > - if (!!rxq->flow_meta_mask) { > + if (rxq->dynf_meta) { > /* This code is subject for futher optimization. */ > int32_t offs =3D rxq->flow_meta_offset; >=20 > *RTE_MBUF_DYNFIELD(pkts[pos], offs, uint32_t *) =3D > container_of(p0, struct mlx5_cqe, > pkt_info)->flow_table_metadata; > - *RTE_MBUF_DYNFIELD(pkts[pos], offs, uint32_t *) =3D > + *RTE_MBUF_DYNFIELD(pkts[pos + 1], offs, uint32_t > *) =3D > container_of(p1, struct mlx5_cqe, > pkt_info)->flow_table_metadata; > - *RTE_MBUF_DYNFIELD(pkts[pos], offs, uint32_t *) =3D > + *RTE_MBUF_DYNFIELD(pkts[pos + 2], offs, uint32_t > *) =3D > container_of(p2, struct mlx5_cqe, > pkt_info)->flow_table_metadata; > - *RTE_MBUF_DYNFIELD(pkts[pos], offs, uint32_t *) =3D > + *RTE_MBUF_DYNFIELD(pkts[pos + 3], offs, uint32_t > *) =3D > container_of(p3, struct mlx5_cqe, > pkt_info)->flow_table_metadata; > if (*RTE_MBUF_DYNFIELD(pkts[pos], offs, uint32_t > *)) > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh