From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74487A0093; Mon, 18 May 2020 11:33:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 384821D410; Mon, 18 May 2020 11:33:15 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2042.outbound.protection.outlook.com [40.107.21.42]) by dpdk.org (Postfix) with ESMTP id E30821C1FB for ; Mon, 18 May 2020 11:33:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O3eXa1MRYJ7c1QqbPz5SoEg9yw/vS8Mjhc2M3QevG7vrtYH2VqyIq2fz13xMMWM0UuyuALmDiiAxwUL2Q3axRyhjfiBfUwDOC9RZ1dYtyFxM1vTQKb3lc2J2XE5uieeTGg7tLLP4al6BePqEhss2MGL3nEcDzeimpHkpHUla+zDW/b9X6O+ExDPV+G1xXTtvM4VpeqbnPCidkrJmncE8PlUzcvttZgdNFhjPWCwMV4O5MJgqX9KB7AEOQ3De9EsxwD+Z5vGTp5tF4uHLXY+BoNLQ8IcRgD22LAigVhDwb0CzvWMG14horHczAZjNQaY4DKH4SxpzTsDYMFajnYQnVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6nL0d++wmL6tjQKH8lHiCvxV50roN1z3JZEs3MvEJBc=; b=bA38bjQWK+2UWjY9DSBPl/VajpasTqVdOl+73PnJbxPiQfV/IQWtXPQBwNgzFAeGbxKu2OuqIJCTen1D+5lchVr7cZoOJMDNYmOCGOjgERetldYzCIo/tH3v3uENgdGDJJVTzaac7zTm6pwgptj4l/ioCT+NoqFo61EWD2ISok0rTF5N4sQ4Ds2UXckhZvyfy/+cIDgBRxNyADKEBhody4zbX5e4kLtCUbSWS1183xOmn2VZJ1EVbWN2NCMEz7LoksZ2T9Txpn8aP51fsGZEeW03ZUpTJROprlK8ihMTlDTjPKRs4LvgRvCB3wzTQifd4RyXN3ppfwEAsfmUij0/jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6nL0d++wmL6tjQKH8lHiCvxV50roN1z3JZEs3MvEJBc=; b=J1GKs2CUQhTTdJGvmaitD/dP1q2nZuPjHxbsuN8g2HZDH7H01CxvOU5bzFBWTfbM3ZHRmnEOOl9k1an+ihppfvcTjElmfdXqrPHbGXan2n0sdIcBLnwPWf1sAE0qhBP5pEbmOY25miTxBW7P8zDFageYz23xfWSrdt1C4g9pgaU= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5668.eurprd05.prod.outlook.com (2603:10a6:208:120::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25; Mon, 18 May 2020 09:33:12 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%6]) with mapi id 15.20.3000.034; Mon, 18 May 2020 09:33:12 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko CC: Ori Kam , Matan Azrad , "dev@dpdk.org" , Suanming Mou Thread-Topic: [PATCH 1/2] net/mlx5: fix port action assert timing Thread-Index: AQHWKq5BtXR2/NSDuUGDFazqJ80RbqitmUUQ Date: Mon, 18 May 2020 09:33:12 +0000 Message-ID: References: <1589543084-113804-1-git-send-email-bingz@mellanox.com> In-Reply-To: <1589543084-113804-1-git-send-email-bingz@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.229.217] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ce8f9e35-aeef-4c9b-7af7-08d7fb0e7c3a x-ms-traffictypediagnostic: AM0PR05MB5668: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04073E895A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D7+mZxGWhIRHYWXDC3SR8EA8h4t3Vp1K/N9lOZ21g2KGETtftTvOp6Sl/U9ARKZzynaiM3WIkXJC5DGJ7+W1L+DfFOzvwlKMdAEM7+PMryajFDoxI4zX3xayAtPE634aQ6Q8btl7PtrTRVD92Sa7mzGP+1Efb+6hZghuEOBG5c5GZQ7PKWLzwyWZUO/2t4qRaOYX/9WCFAi7R8SD4xuMvFRRw+wf2R9GQda1AyLpADdp551iPdUs6u5Zhax6Qxb2spZ7u98lV7Iphc7m64LsaBG9rMp6WeQWk5LvBAakkKmkJsvw+fFyH8bbeKq3bLzdoNck+Gshu4SdffjG2X971ScdLRJ9ZDsdHgncI9WXgWZUhcsRBs1HmJijhdDjUKsIigE25sGbVhPDZM14HPUpwFL0B8hPreUvT6ko+VjaxHoxU8uFqOg0ibPj17CBO+Lx x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(396003)(366004)(39860400002)(136003)(71200400001)(8936002)(5660300002)(8676002)(52536014)(186003)(2906002)(86362001)(76116006)(66946007)(6636002)(55016002)(66556008)(64756008)(66476007)(66446008)(9686003)(107886003)(6506007)(478600001)(53546011)(316002)(7696005)(110136005)(54906003)(26005)(33656002)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: auEV5jw9e7LSXoDVYm0gCf5X2g+Wt6ZSRVWip+Yg81aT9rDd084Qu/y6tLLzJKp+UtDmLVJRugoj+Rklsh9tL+rSlhYfcn0b2ix8h5hJzzrPp0F4F/Ps60+VUDCUkUnYwAQsoifs3DrS9vMr3iBuej2WeEvlQxes6TMWenmLa3PxR2G6cwKaraXOogepKKKwPyzosBArvsoma5ygldZz2+qREwi9FyWQJnqolTJ48lvIRTaxYJnBXXw280G0sy379lRMapvZGIJvADI0ArxAw6c+oqDVwXxCxvU09Xki8Xd4PoiWyM9rAvcx7cG3k9Yz7MX2r2J9XBVzhLoAaYxgAIrCMt5tCQykuIqKwVTmLUPSSLts+ikdzQuKS7YOdp13V9XsbK960NUIrdWbLE3nysvpwaJGKmvseJBOV3y3bwtyxpAwe3BaeiLzgb7AvHymvYQ1+eWM6HZkPMQuT4L0Fdzays54hYNoAMSyVySpKEX9q2USPIEeIJYkNf+gBCdS Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce8f9e35-aeef-4c9b-7af7-08d7fb0e7c3a X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2020 09:33:12.7739 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s6bpr2KEJGGSRrTmV5tPB2eCicnj8Zm9Od+OJMalY0wLoSd/ImEQnYTxrN8jfhZuJDGc6mjNwlFbZp4KHnmjvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5668 Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix port action assert timing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Bing Zhao > Sent: Friday, May 15, 2020 2:45 PM > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: Ori Kam ; Matan Azrad ; > dev@dpdk.org; Suanming Mou > Subject: [PATCH 1/2] net/mlx5: fix port action assert timing >=20 > After memory optimization, some action object handles are changed to > index to save the overhead. Assertion in debug mode will be helpful > for trouble shooting. > In the current implementation, only one port action is supported in > switchdev mode for one device flow. In debug mode, an assertion will > be used to check the if the port action is none, and it should > locate before the port action resource registration but not after > it. The action index in the handle should be 0 before registration. > Or else it will always cause a failure because the port action is > registered and the index is not 0. >=20 > Fixes: f3faf9e ("net/mlx5: convert port id action to indexed") > Cc: suanmingm@mellanox.com >=20 > Signed-off-by: Bing Zhao > Reviewed-by: Matan Azrad > Reviewed-by: Suanming Mou > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 71da5fb..45fa60c 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -7834,10 +7834,10 @@ struct field_modify_info modify_tcp[] =3D { > return -rte_errno; > memset(&port_id_resource, 0, > sizeof(port_id_resource)); > port_id_resource.port_id =3D port_id; > + MLX5_ASSERT(!handle->rix_port_id_action); > if (flow_dv_port_id_action_resource_register > (dev, &port_id_resource, dev_flow, error)) > return -rte_errno; > - MLX5_ASSERT(!handle->rix_port_id_action); > dev_flow->dv.actions[actions_n++] =3D > dev_flow->dv.port_id_action- > >action; > action_flags |=3D MLX5_FLOW_ACTION_PORT_ID; > -- > 1.8.3.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh