From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8D2AA00C2; Sun, 17 May 2020 11:59:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 584A71D647; Sun, 17 May 2020 11:59:27 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10065.outbound.protection.outlook.com [40.107.1.65]) by dpdk.org (Postfix) with ESMTP id 5DBD41D646 for ; Sun, 17 May 2020 11:59:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mp1oJ68MFezxUxdJ5Z9xty/uqmo27yc6WQpz2UP073X/Di1cnz84MSdGbXKPitbKb20KH5c/ARfD+OGsbgZ867s+3KW9CsV+cwvx1PwkDCkE4eDKSvTsgpa8OyKwUno/+Krxjv4PCq9OBuiHGWBliOSb9qnExo4pnUXmWes8K0MLtl963dXNfYtL4FnS+idAu4bvAt1+B8bpEo32oDzT+IYpTjW5QWeVIyTYFop29oX7wDHc973Ir3RPyihLYci7aDnfqwjIDQb8NWafhgQkSipoONGZbdY+b1qUvLxTSrf6u3AJu1DUOfWRMuG+OykClHiaHPfI5WMMx5rD8pSuDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zVwctery8haJuCJYD2vSSXi3e+xTyCuoFBh7gvtUNLA=; b=aj+lfjZ9XI2J9Ki8R6ih076b+S2aEF2lCakJ6xSAEozhYSgzsdnn2h3mSf4PKUZCsiemxyrSwy84Emlton3/uGZXJogNtoOsNX4pk0oZtpZ/+hDHZusi2crHpXdSxMkJWEZugCnyupsbjleS1e51Le7AgvKax+kGzLcLz+ZX/AWnFhXLM7VqgyGQdxAik1x4/mmVexwta1CG7rCFzsg8PuQEf6QnJrUaQnnKH8olFjQTp8ie0J1puvFk2pUXiwdRS7J4xpQAYVALVUvH1UkBV0nN1ozPf0ZS9UF1XC7A1cx6jUjdtO2qyHCoew4V36g3+vQlJ7t8Gd//+25JAYZh2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zVwctery8haJuCJYD2vSSXi3e+xTyCuoFBh7gvtUNLA=; b=tvRnL+QC5w55zWlS5eyOMRFfZgDrhTDhjKb4XV+Ms/e9PGXKxpkxl+Xh5TI2yODCyeszeDnb61QsLaVUt0M5XWxRvBSx6zY2iTVs0XrscBkXILne/JYV4+AH4s+X5BkfsunvhxA26JfGVMJ2im7hw7LINdDZrAkkuiKWxW0hKSw= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5873.eurprd05.prod.outlook.com (2603:10a6:208:125::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25; Sun, 17 May 2020 09:59:24 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%6]) with mapi id 15.20.3000.022; Sun, 17 May 2020 09:59:24 +0000 From: Raslan Darawsheh To: Suanming Mou , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix shared counter search with nested index Thread-Index: AQHWKpPjYMx9PntvM0ytBDGHjcplO6isDl4A Date: Sun, 17 May 2020 09:59:23 +0000 Message-ID: References: <1589531763-320086-1-git-send-email-suanmingm@mellanox.com> In-Reply-To: <1589531763-320086-1-git-send-email-suanmingm@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.229.217] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9700e02f-930a-417e-92ca-08d7fa48fa5f x-ms-traffictypediagnostic: AM0PR05MB5873: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:913; x-forefront-prvs: 040655413E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +FSj/hzNn8Ao/0Qxj7Y670YN9vKKfbGMnWoJ4oMlR5co5QjpPSLp6EqgfxVBGQZUys+8QdU02y6PFgfoDLxwIIyeSZ3eHxflKqp8qfEQTRPsEOR2QXPy5uNgYICR0bPhyblNk9+XZY4F0n/cbdu3K6JTZy8Fo5peeqB9AED1kWyhC8YIVIh5xjMbPplER0hxnGINUJmZ3GPira85kk8TGyRuDAKlTFmK07Fs+71/hA7ug9Sa7KA9XcdfzP/VwHhV0yuuLkOJL+Y8fYmfH/t4cnKMWZ6GfeVsMNrr8OznPvGHuIUCWda7aHiOOqULT/cajFgyn/FtBEwTnCnqNbQvVBh14QvPYRL9H/erDIQdOwmQUmQn3hCLfS1uvgHvt/FUX8yNL6BLm1pHTQGKRTt3Rvw0HFyc2hg1E1+y4VA7NTHwCQPGp4AauZmnLMzu9RdE x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(4326008)(6636002)(55016002)(9686003)(33656002)(8936002)(86362001)(8676002)(5660300002)(478600001)(26005)(186003)(71200400001)(52536014)(53546011)(6506007)(316002)(110136005)(2906002)(7696005)(66446008)(64756008)(66556008)(66476007)(66946007)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: KtqI65n/Q/yyulwYyg0IPONcNWRvFd02+QEbQAVm888UWG2/kdb9/LeDKj2WSAgPSUxrRuddV41knUh+6Z8r5ah4luBya+jd7HNkjfUGWtK2t5dHBjvJmcIOLwgZHcL9CNcYUm2wW7QTR+2JdLGNX4fiDMLMkFrvHVUHRJ41PMwgeC4hGPH4Hq4SMec4fWyiDikCgHBHuX5HM+cuiFmGz0AorQKPvTrvbrgg6iOZ6YEARn1w0IZQYreJGtWmAN2NJaD8AFYmWN7vPN+/KJmWduZdifv1sz1sXjs94mlB/LuoxD3LYoR7aZ9Qs5N+/ooFCzw/JZun5qlMVy6FpGqfnTRDKqzKsKq8CUqh7KRKHY+cYZAqGoXcD/5f4CHb/qXve/91vYcjs6zIarH+jCTY8BXU2NN13zZJIWugPfd0hwTpeINoszwNF+ntrvZ8QU5TlIfkFcz8U+pDDTsJO+TPEZzxQGLSkaRPuT3QtZ11NdGkE0gK1+0EizD8Sg1ZkDla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9700e02f-930a-417e-92ca-08d7fa48fa5f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2020 09:59:24.0126 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6VjYHxSk0VOTw/X8QYElB4829cCUTqJCsy3is25TnbeVKAFGZmMGmnh1F0FyNb6DeC6xGr/+KPvZgM5Tt7YJlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5873 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix shared counter search with nested index X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Suanming Mou > Sent: Friday, May 15, 2020 11:36 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: fix shared counter search with nested index >=20 > Currently, the shared counter search uses the wrong nested index which > is used by the pool index. The incorrect nested index using causes the > search go to incorrect counter pool is not existed. >=20 > Add the counter index to fix the incorrect nested use case. >=20 > Fixes: 4001d7ad26d4 ("net/mlx5: change Direct Verbs counter to indexed") >=20 > Signed-off-by: Suanming Mou > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 71da5fb..deb4469 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -4467,15 +4467,15 @@ struct field_modify_info modify_tcp[] =3D { > flow_dv_counter_shared_search(struct mlx5_pools_container *cont, > uint32_t id, > struct mlx5_flow_counter_pool **ppool) > { > - static struct mlx5_flow_counter_ext *cnt; > + struct mlx5_flow_counter_ext *cnt; > struct mlx5_flow_counter_pool *pool; > - uint32_t i; > + uint32_t i, j; > uint32_t n_valid =3D rte_atomic16_read(&cont->n_valid); >=20 > for (i =3D 0; i < n_valid; i++) { > pool =3D cont->pools[i]; > - for (i =3D 0; i < MLX5_COUNTERS_PER_POOL; ++i) { > - cnt =3D MLX5_GET_POOL_CNT_EXT(pool, i); > + for (j =3D 0; j < MLX5_COUNTERS_PER_POOL; ++j) { > + cnt =3D MLX5_GET_POOL_CNT_EXT(pool, j); > if (cnt->ref_cnt && cnt->shared && cnt->id =3D=3D id) { > if (ppool) > *ppool =3D cont->pools[i]; > -- > 1.8.3.1 Title changed to: net/mlx5: fix shared counter lookup Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh