[dpdk-dev] [PATCH] common/mlx5: support more fields in DevX CQ create

[dpdk-dev] [PATCH] common/mlx5: support more fields in DevX CQ create

[Dekel Peled]

Update CQ create operation using DevX API, support additional fields.

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++
 drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index e5acfa3..2fe3ac5 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -1437,6 +1437,9 @@ struct mlx5_devx_obj *
 		 MLX5_ADAPTER_PAGE_SHIFT);
 	MLX5_SET(cqc, cqctx, c_eqn, attr->eqn);
 	MLX5_SET(cqc, cqctx, uar_page, attr->uar_page_id);
+	MLX5_SET(cqc, cqctx, cqe_comp_en, attr->cqe_comp_en);
+	MLX5_SET(cqc, cqctx, mini_cqe_res_format, attr->mini_cqe_res_format);
+	MLX5_SET(cqc, cqctx, cqe_sz, attr->cqe_size);
 	if (attr->q_umem_valid) {
 		MLX5_SET(create_cq_in, in, cq_umem_valid, attr->q_umem_valid);
 		MLX5_SET(create_cq_in, in, cq_umem_id, attr->q_umem_id);
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h
index 2b39ad2..d4af01b 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.h
+++ b/drivers/common/mlx5/mlx5_devx_cmds.h
@@ -240,6 +240,8 @@ struct mlx5_devx_cq_attr {
 	uint32_t db_umem_valid:1;
 	uint32_t use_first_only:1;
 	uint32_t overrun_ignore:1;
+	uint32_t cqe_comp_en:1;
+	uint32_t mini_cqe_res_format:2;
 	uint32_t cqe_size:3;
 	uint32_t log_cq_size:5;
 	uint32_t log_page_size:5;
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] common/mlx5: support more fields in DevX CQ create

[Slava Ovsiienko]

> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Sunday, July 19, 2020 14:11
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Raslan Darawsheh <rasland@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] common/mlx5: support more fields in DevX CQ create
> 
> Update CQ create operation using DevX API, support additional fields.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

Re: [dpdk-dev] [PATCH] common/mlx5: support more fields in DevX CQ create

[Raslan Darawsheh]

Hi,

> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Sunday, July 19, 2020 2:11 PM
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Raslan Darawsheh <rasland@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] common/mlx5: support more fields in DevX CQ create
> 
> Update CQ create operation using DevX API, support additional fields.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++
>  drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c
> b/drivers/common/mlx5/mlx5_devx_cmds.c
> index e5acfa3..2fe3ac5 100644
> --- a/drivers/common/mlx5/mlx5_devx_cmds.c
> +++ b/drivers/common/mlx5/mlx5_devx_cmds.c
> @@ -1437,6 +1437,9 @@ struct mlx5_devx_obj *
>  		 MLX5_ADAPTER_PAGE_SHIFT);
>  	MLX5_SET(cqc, cqctx, c_eqn, attr->eqn);
>  	MLX5_SET(cqc, cqctx, uar_page, attr->uar_page_id);
> +	MLX5_SET(cqc, cqctx, cqe_comp_en, attr->cqe_comp_en);
> +	MLX5_SET(cqc, cqctx, mini_cqe_res_format, attr-
> >mini_cqe_res_format);
> +	MLX5_SET(cqc, cqctx, cqe_sz, attr->cqe_size);
>  	if (attr->q_umem_valid) {
>  		MLX5_SET(create_cq_in, in, cq_umem_valid, attr-
> >q_umem_valid);
>  		MLX5_SET(create_cq_in, in, cq_umem_id, attr-
> >q_umem_id);
> diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h
> b/drivers/common/mlx5/mlx5_devx_cmds.h
> index 2b39ad2..d4af01b 100644
> --- a/drivers/common/mlx5/mlx5_devx_cmds.h
> +++ b/drivers/common/mlx5/mlx5_devx_cmds.h
> @@ -240,6 +240,8 @@ struct mlx5_devx_cq_attr {
>  	uint32_t db_umem_valid:1;
>  	uint32_t use_first_only:1;
>  	uint32_t overrun_ignore:1;
> +	uint32_t cqe_comp_en:1;
> +	uint32_t mini_cqe_res_format:2;
>  	uint32_t cqe_size:3;
>  	uint32_t log_cq_size:5;
>  	uint32_t log_page_size:5;
> --
> 1.8.3.1



Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh