From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1156A0526; Wed, 22 Jul 2020 17:31:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AEA081BFE7; Wed, 22 Jul 2020 17:30:55 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51]) by dpdk.org (Postfix) with ESMTP id 3721B2C6E; Wed, 22 Jul 2020 17:30:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WaHNrap5hA7goAFW9O730BOUwyA8Lot9ExHShgzaCKhdJPT9jrOzL3lPZ/ak/XcJxNVkRsKGRj98P6aIjRPupGsSAwi5udLjfv4n5eRg85jtBpAFlvJe+XBQvTtk51AvsQY+Ja3KKiz8dinQdm5kp5QQSkUEt65i6yWt03M+Jvwjubouv7Gs6hXMpmtGvxcVILgtTdIZgBk0OS+Z94iheXBegPbYm9vu+GmTnmWMV+EgWmgZ+ed1QG96UqSlw/ggcr2F+qbddh0668muvN0uWCEJXebHadF8hBRhh8IRHH3QIAXhZY5nnOifiswsvz6mgK7oQNZm46WcZamzmPjtuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lP+S9JkbccUeUfyio0P4XtzH3l6QvbYpSD7OL6BwnpQ=; b=ScJ3U7A9/MqNL2++sXHdifgt+svgv+mp4X5oriV1vgCACOunpSbF+avKY7boHOY0AaMZYMfgZ1d9PnBNPyYU6YfR23YBowLZ0O0Wpmi6k95KXYK+2C1FnHru7KSybN3RcqJMv6WFs/bRExvBODAj2zyF0yEU/3/s5M3+Qot3zCrFoCWKEaJVAje3hmWe/PAWkabWdtJjb3vA//D7ft/Nqy8eGh3BVBjvkAIKTaX2vbAK16sVGf8stxBQsD5dnY0fvVp0SW/r3HQz2weKXhEjC+mqF9j7QnfYCXOYw63ejoNNv0e57vSbpyUMbm4xt3ucT04jmOrmzDxtKZvm5ZbcFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lP+S9JkbccUeUfyio0P4XtzH3l6QvbYpSD7OL6BwnpQ=; b=eRR+2jRwzKBkXVQpeQXODC+vDtPHnYIYpoxQ3UT4lfxrT++SdnjB5CNg8hup5VQZnNxvWfwsvlbY1mUkUzkIgOEN4SAyjMSX4sVSSERstojjNA3tTSd6a3P70I0xAnj4ZOVJs+Aim/prwJS4sXFiSayGZyhH8tDWr3kllckhcLs= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul 2020 15:30:49 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020 15:30:49 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx4: optimize stuck memory size in probe Thread-Index: AQHWX1arTDhOiTaZd0alelRM7Hpi1qkTuuFA Date: Wed, 22 Jul 2020 15:30:49 +0000 Message-ID: References: <1595332869-6942-1-git-send-email-michaelba@mellanox.com> In-Reply-To: <1595332869-6942-1-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9e4e2384-4c3e-44ac-9fcc-08d82e54365c x-ms-traffictypediagnostic: AM0PR05MB4401: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rIwFrr5xVIPIgqtiPFigIitJh/8WVYYa+xaajrkL1Z9I3GbFdtv00dsgVzFFkTmEj2/wJJ6PIaLC8dMzhHy+tNW1y3QTcNebmSMmruVERy80YgmGhYaA9DSXDwooP8z+RzJ8znnV5zZKxTEoGsm75YxZEmisgfc+AzmYIiJ6YFbvBPZhoNJ2x9vaayey4/v5Kqm3M/oi8udm5Ttfh7EL4yTkDY/GmapH8BGn9OHkgLCFXUDNy0ikJwYbJrSPO89lGK1eg5dIZMR/1NPhd1+IPmHOt1hWEQ0x76scvo0cXg+bMI7ais84ybnMS7i3K7D3e4cwrGmj3f+GT9mvDTMvyg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(316002)(8936002)(6506007)(26005)(4326008)(7696005)(53546011)(450100002)(478600001)(8676002)(54906003)(110136005)(186003)(86362001)(2906002)(52536014)(5660300002)(55016002)(83380400001)(33656002)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(9686003)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: SwU4VTyYUeYB+qJFjdS1d5HScsiAFjQpj236vlRbU9sZrhlQ51EajOMUY2GdBbe5xBuri0YOpW1NUy+AaVZem1S0QFrJ6OU061UZYn+lXrQwMDLSdoplIi9txWjh8rsFGjySd/VHJhThDg9nTXcxT4nkipLNT8S6iqtQ41KRCWBdsuffFFcomgJpk0iLFjsnsJSPJtaaPMLT0FFk2+9pMqcIZor1zEkRK9tUe5uS0iqGOsVw5xkfJRDSG6TTLHVdolvYvZQvOpGFCody2u31VkOUOVb0G30C74KR21AF495vLw3ZqRj/+E3WjlFyH139kucBKTIWAwT+16rTbIdXZ1l33I7KUV7TnMwL0A+d++6C+Av6tVFi3QMbfQb1mevjV5CCpu5sewexxkAwKRzUy/RiDK7mZlHTEusrn5W7zkp+uCQV5ak69Vgd2rMZN6O9b5srEZvKNIy4IaQbC2GK43MB9A9qJvhiewJI6grKcsXRcNR0piAo0ZW/hhoA7c2m Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e4e2384-4c3e-44ac-9fcc-08d82e54365c X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 15:30:49.6478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qCCvbElkUUybMhgc4MXQTF7N24aC27DEAKadYG/jYO4blQS9BvfISvRE85iZjWuIG7zkjMD+J1K+SVkbElThWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4401 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: optimize stuck memory size in probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, July 21, 2020 3:01 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx4: optimize stuck memory size in probe >=20 > The mlx4_pci_probe function sets a pointer to the mlx4_priv structure, > and during that function fills its fields one by one with relevant > values. >=20 > It wants to put a value in the intr_handle field that has all its fields > zero except 2. To do so, it initializes a local struct rte_intr_handle > type variable and updates it only 2 fields and assigns it into the > appropriate field. However, it initializes a very large structure on the > stack while not at all certain that this place exists and in any case it > is very wasteful. >=20 > Reset all fields directly to the pointer by memset, then format the 2 > fields to the relevant values. >=20 > Fixes: 63c2f23c852a ("net/mlx4: use a single interrupt handle") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx4/mlx4.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index e619a74..71061a7 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -1029,10 +1029,9 @@ struct mlx4_conf { > eth_dev->device =3D &pci_dev->device; > rte_eth_copy_pci_info(eth_dev, pci_dev); > /* Initialize local interrupt handle for current port. */ > - priv->intr_handle =3D (struct rte_intr_handle){ > - .fd =3D -1, > - .type =3D RTE_INTR_HANDLE_EXT, > - }; > + memset(&priv->intr_handle, 0, sizeof(struct > rte_intr_handle)); > + priv->intr_handle.fd =3D -1; > + priv->intr_handle.type =3D RTE_INTR_HANDLE_EXT; > /* > * Override ethdev interrupt handle pointer with private > * handle instead of that of the parent PCI device used by > -- > 1.8.3.1 Patch applied to next-net-mlx Kindest regards, Raslan Darawsheh