From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB4B4A04EF; Sun, 31 May 2020 16:04:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 307871C235; Sun, 31 May 2020 16:04:03 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140059.outbound.protection.outlook.com [40.107.14.59]) by dpdk.org (Postfix) with ESMTP id 6B6D61C0D9; Sun, 31 May 2020 16:04:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=INjjUSZ9EwfLTi7/MhrKYEpmeJdHp9F3Ly5gHTX94McYuBxk1EF16/smzGnmT6MYSkEH+/2vOO8dUFNF2l78KfMzZtQe6uJ9KVmWZoK8vB4adrdhSDWG/oZAtkqLGsuHHyAX1ElnnTGwH697aimXwwD5JJ7a+KLsl4/DOK47f6gVvDwHkhQGftmGE6HtMSpfk6/Ek90Rxs8jj/mW3vtNfmuBXXzsH54ZdMZrcSjO5jquX39m9gH6MrBIeNp+UyviG1HYupjJUpe22wFln44WQiz3iDRZWacshQZ1DkiSmYkOZi8PhtgX9YMTeSl+QLXk8yOqwZ2aBwiVWwb1Xfx0bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TBWnirBKkbr1zj2pJL820vDGtsgpxxTPt3vEH31I5Us=; b=hpAX66mIanjHtNcI6onZ52xKfaDEUb0WNDXbzehToyN+RBIX5GHOyHp9t3xQyCJd0uTRzsy8NDTkuky5pbU7Ud9/bTskz+g/h7zahFogLwyPIbr1b2WG9Y1X43zJt8K/huEkthwOKH+96LiyWYMnLxA0gNCLVOGXBe5ZddCvM7vUJwAnlcdzHRCNb4iCr+xAEjwES6ML+QkKTig8w5dPJciphv+YUv6/PYoxpK9lQYIAnqBsFMl4a8yQVaQsI2Z/ZUT8VhwMzaF2eVYtkiCo9PXNOp6kE3qWYdcyH835oAZOeMbjXvd9CeG+zW2szVrAu2+xsbZfd2wfCLBC6woCnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TBWnirBKkbr1zj2pJL820vDGtsgpxxTPt3vEH31I5Us=; b=E/GUCcb5mhZb73fzru7Lvj2XdgGwSVFdxTSjay0ri1aiM37MPa8LFNmUAhYDlnaH2AuTGUUjgq2YBEvPFxbbiepuITm4qLs/+vp6YsSPHfeIiXE2sAIpvp81bIB3nuTmB/v/xDw271tmW1GCBR0voOTAel501FbN9GJgmXOZwkw= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB6145.eurprd05.prod.outlook.com (2603:10a6:208:117::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Sun, 31 May 2020 14:03:59 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%7]) with mapi id 15.20.3045.024; Sun, 31 May 2020 14:03:59 +0000 From: Raslan Darawsheh To: Suanming Mou , Slava Ovsiienko , Matan Azrad , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix secondary process resources release Thread-Index: AQHWNL2a7/M7iijmqU6Jyt/jtqY2Z6jCPxXw Date: Sun, 31 May 2020 14:03:59 +0000 Message-ID: References: <1589532130-321429-1-git-send-email-suanmingm@mellanox.com> <1590649189-240187-1-git-send-email-suanmingm@mellanox.com> In-Reply-To: <1590649189-240187-1-git-send-email-suanmingm@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d74475f4-ee09-4adb-7017-08d8056b7767 x-ms-traffictypediagnostic: AM0PR05MB6145: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1060; x-forefront-prvs: 0420213CCD x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +34o5mjBTz/axs12JPlWhrNyzkOIGkDnsPPs2WsdcMrlbW7bXTrBRCKHe/leHJnhJM8IlT1gZWS4mQWjMfJd19VJ1DJMvn2VxzzCUIFTNrqEJXObAe70QrzmxisDd020jsIU9logzrgPdqY12qgU0/hIzLiJjvjDaM4+MndyN3GAp4L4mqWgW7UkU9/oOyAsE5DW2g40zK8kJt60JkB7MWDQDsITFtlklXSHyaY1ir0frAuf9eimkTGfSHkx1B8FdmT7UrPkL5Xwr4nBFWVOVgj0vPiXJ1UfRCOtqZZ2ENCIMr3SKTz3T5XAjzuwL+J1mHgffpx6x5npza9axinsRA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(83380400001)(9686003)(66556008)(76116006)(66946007)(86362001)(66446008)(64756008)(71200400001)(66476007)(55016002)(4326008)(450100002)(26005)(6506007)(53546011)(52536014)(2906002)(186003)(33656002)(316002)(7696005)(110136005)(5660300002)(8936002)(8676002)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 6WDRpZDUFi+pdOSuh9mMzLUFlMlhVw4iE+uRNRzQsmn7184ebR1zCN6IHhp2D/eUinFgevDshH/L3VOIUrS4My1VNRuEcMVTL5l3sBjUDXROc7eq9acq+Y0fdDMmGKr9MieIWrgnaDkBxazeMYGn4vwpw/qoJ/H5D0zaU7nAz1/hysWDyLzilG9D0XM1HEMljRO2odgg6UEhSUoUlc9KX5qQMg9qQz8ULUCe2VpNC9BD3YYSivrEWg1xkTJqMVC+GCA38hdVgUcFnb5uNY0PHKyMREcbfVYUfNtdT761sAY0pehCXv8jugCkIOHpiBIaMewtqoKQheBsbhTVKB4H5Lu1Kk2my4ZE2lnDumsPVXEaFZJzsXf3PJhjIOuQVmATv+wpeVVDG+0lCyQ+pVIZ1xOz68VHhgpQ3z5qNLiH2gcwaTQFeGwMSqhEwJzecSDh95vrjQju53x0LgOCXAaN5z3K0314raBU1QexpOUzZ1E= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d74475f4-ee09-4adb-7017-08d8056b7767 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2020 14:03:59.4458 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uLs+qJ3lbsXQIdewBEKl9XRIy+aAe8aR6RHJkDj89oZ0kqK9AqXe1JRRD3KCDbGl2WU3R7EFxEegzNBOltOQww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6145 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix secondary process resources release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Suanming Mou > Sent: Thursday, May 28, 2020 10:00 AM > To: Slava Ovsiienko ; Matan Azrad > ; dev@dpdk.org > Cc: Raslan Darawsheh ; stable@dpdk.org > Subject: [PATCH v2] net/mlx5: fix secondary process resources release >=20 > When secondary process starts, it will allocate its own process private > data, and also does remap to UAR register of the Tx queue. Once the > secondary process exits, these resources should be released accordingly. > And the shared resources owned by primary should not be touched. >=20 > Currently, once one port in the secondary process spawn failed, all the > other spawned ports will also be released during process exits. However, > the mlx5_dev_close() function does not add the cases for secondary > process, it means call the mlx5_dev_close() function directly in > secondary process releases the resources it should not touch. >=20 > Add the case for secondary process release to its own resources in > mlx5_dev_close() function to help it quits gracefully. >=20 > Fixes: 942d13e6e7d1 ("net/mlx5: fix sharing context destroy order") > Fixes: 3a8207423a0f ("net/mlx5: close all ports on remove") > Cc: stable@dpdk.org >=20 > Signed-off-by: Suanming Mou > Acked-by: Matan Azrad > --- > v2: fix more issues in secondary process. > --- > drivers/net/mlx5/mlx5.c | 47 +++++++++++++++++++++++++++++++----- > -------- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh