From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92980A0350; Mon, 29 Jun 2020 10:44:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1313D1BDAC; Mon, 29 Jun 2020 10:44:50 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2086.outbound.protection.outlook.com [40.107.22.86]) by dpdk.org (Postfix) with ESMTP id EB0D71B9BF for ; Mon, 29 Jun 2020 10:44:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VYGvfm40I2gS4zpdnVqLyzCMGyMC6HWACnrS1WWjdaHLfqkwDQ+Qi4uzT7eXsdKs0gTD4sk2zIpg/s/G6Guh8QnMFfWgAlWXYU4MJGG6JA8HHohc/Te7lzfuvoTaGJcFLOTOa6+QSse5okhSg+tSp2eAhErwOrqCk9yl1mBwqZQWMBGBbRrxPS4OE5Bbxz4hfZXkfKaOsSPmHWGjO36/lKNDXSbMaOs/7sPTpkYm8OfG6Ya5H4ul+8WROS1XmKzuaC5C/Nui8MHooE4BbF/V6Thi2xzFV5MyMgVNMibPPn1hoVQ5V8aHrkNb1WQ9Ox9Vq03RjelGRrz5pHBhswVF9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DKplPzVZKUrBzrz3CLvOv07aZuhmMVkAeAuwIilAers=; b=LunXO+KhCVBBh7vX4zmP5NpPNvH2xrWjSz7f9Kt7YUUE1wcttbM1So2enviEHWkWfEO5ivVFg1PbGEQfgVZHZ+i17zZLJIXzckYUGXo8RpQoA6dfEuEVdv6/wUZ/4B+coE+AaXn+MZwmbg4fx5GvVFs8HNrTKe/0OpeLeoBNpJIAPt+yggENGYdAxFOBNjeMYwPVefLBZ2bb2mgmQPluh2PAI/+Br1OFoC8mpEvmSKBB576O8sCEZd97FVJlt2oZSaHa6bez62hC5ZalIIZRYOwu9dx5PO7hrL8X+vjpQSUEbt1TfxRR9oGwh+VEghvh5qyt7ueMKp7Gc81QVePllA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DKplPzVZKUrBzrz3CLvOv07aZuhmMVkAeAuwIilAers=; b=rBFTfZzn9YSAgXCJyIXGH0I2Ksr3Z24qmYPj9TyWW7ceYVsxXyY1EbOkB9FxPzkVwGENBeicPJzR+VIz48a7nesJq+cdLeuJtrVSAFT0k8RbBpnKNLsTUgxr9ucWF2mKb44RdH2gH5PJF0qeb2Cb2IZrK4WSLy5QyetYdbx9qP8= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4851.eurprd05.prod.outlook.com (2603:10a6:208:c1::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.23; Mon, 29 Jun 2020 08:44:43 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%4]) with mapi id 15.20.3131.027; Mon, 29 Jun 2020 08:44:43 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko Thread-Topic: [dpdk-dev] [PATCH] net/mlx4: remove useless assignment Thread-Index: AQHWSjGOvT9RxzFhz0qrEzehNLz+NKjvTm4g Date: Mon, 29 Jun 2020 08:44:43 +0000 Message-ID: References: <1593005476-5504-1-git-send-email-michaelba@mellanox.com> In-Reply-To: <1593005476-5504-1-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ea38b0b8-f476-4bdf-27e2-08d81c08ab4a x-ms-traffictypediagnostic: AM0PR05MB4851: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-forefront-prvs: 044968D9E1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ugWCTAC2swnyki+xwYmrnbzGJd+GlEsTh7HpM1TzJBbWlAuW71cwPX1xfQHaN0kjAFjvPQJDFlj8vEpYbHB05M3W6AJQ9EJdPnF6fqGbxAa32HS8GBJ2XgUa5pFgvsZh0DfI47t+tD2VvbcVrNJ17ATN9zyXTBKdVcJMb8mhmGvBk3rH6SZegfnVDD7b3yExr0XYkq0xDGQjTwOzRDBfifzBiaU4cJ1h95ldIREfiKBlGI4pPk95rema70zAPZWpZduYii7LMVmx/axPly1mm/nUE3iGsvqub2hwAt4JWwIGpZ2QBgq4kpiLxpWCalfz6roQxOkuenWTrs2/ad/hrw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(346002)(366004)(39860400002)(376002)(54906003)(26005)(6506007)(478600001)(186003)(7696005)(2906002)(316002)(33656002)(110136005)(53546011)(52536014)(4326008)(66556008)(86362001)(107886003)(66476007)(8936002)(64756008)(66446008)(71200400001)(5660300002)(8676002)(55016002)(9686003)(66946007)(76116006)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 0AmmJOAMMJJhgx3aKTLQ2/tWOV8+yHhV53SGPgsqQMcKVcsS2oTeTx4cDwJcMGSF8BGn8GpGiKiN6/rQn5XpMMXlSrBQf0vGikzfs6VFuGV83CI+q4NgnUAL6K3ddc7bDkYsPkEdNo+M4YJdhfUWjEM9CCe+njMcm/JrnOL4DCTenJri25afX9tLbnHDzjcEZFUQ0u7BaQSkyAcdiMkOgqoItDaUiziybSU9kFBax1LSyID81WvyRfldqluZ4F/YkV1Jgv6gwL72xzCXjkJr/VBLmllnQyUrSt0JARWfhg2rDUIrxRoTf47HLtU7tZWGTuQ4WhvZNI+V/UWD5HBgS5VXJSyygzuelwmGDIH8E7/2rjrz8tQY2f0XLjLRiJxZ4JkXYBYRF95LyDnDljTYLDiaibtEAeMKt0NXf99cQolsvAb2h47uoLIuzD/cpOlMQRDg2EtyO3IvuziNDd+BOzN27Nk6cbezqmKepCTJqP9fMyrLwrDfy1EUUILf2l6i Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea38b0b8-f476-4bdf-27e2-08d81c08ab4a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2020 08:44:43.0680 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zr8ZJ1nwJebSG1F4l4P2c8w+tnqhJQZpwWlk/eOK8zQqeq6h+RjHAk2Qw1yUIuD/ELmJZFUQNCmy3ziF3hr6vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4851 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: remove useless assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 4:31 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH] net/mlx4: remove useless assignment >=20 > The mlx4_ibv_device_to_pci_addr function defines a variable called ret > inside a loop and uses it. >=20 > During the loop, the function assigns a value within the variable and > breaks from the loop, so that this assigning has done nothing and is > actually unnecessary. >=20 > Remove the unnecessary assigning. >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx4/mlx4.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index ff270b4..1657ea3 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -492,7 +492,6 @@ struct mlx4_conf { > &pci_addr->bus, > &pci_addr->devid, > &pci_addr->function) =3D=3D 4) { > - ret =3D 0; > break; > } > } > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh