From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6D0AA0556; Thu, 20 Feb 2020 16:26:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C4E11BF98; Thu, 20 Feb 2020 16:26:47 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150040.outbound.protection.outlook.com [40.107.15.40]) by dpdk.org (Postfix) with ESMTP id C9ED958C4; Thu, 20 Feb 2020 16:26:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l8/aE1NjyltebZTd/ftjCe+Zd5t8jGFUKQ//e6G3X/gtrADSJG0MAptjSqj10HfobC9Y6Ltc3FCv9a8nJ2XgRryr8F/Irg0x/wLzkVUBySn1FRwcYcA9RtzUFzV0kGj/tJR+ZiqRp+tuv+0ti9T50wptFCO5+YeRlY+0TaTkKUjZMIYaoA3iWET+CW4WYiCWXugtoWVW46zj/aAKtiKps64EpZDz0b0Oj6rAxQmHs8BmuML+pQotSneeXOCp2+CQ4XeJILKpcm4UaVhRd8SSOUOJf4xb+vjGQa2czpE3T8IfX+aDHmOs9XgHznc2sNT7qGgcaNAOGPtuN1JDYw1jgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aOzyLv25rX5dkvRcgjkQQd/ZeYayPco8k8lVXUf0knw=; b=YJRSz97SYg3FPRi8NCRa31FljewXLlJKUKrQ/9EW2xDia6p8/RF8wdyWL+l5lX7uUMxdUCB/hvUcsCnLaWRNohZgdx/vNNDA1XInEhsWY2jAfZv82Hiy4NkimTYVxgdXAbJQMNeL15FauMEPQw3yzhbG9GhaQTASN7HySoweggPjsW9Pto9IhDvjeBpxvmYwTpM1J4RIuyKmqVYejXwD3W+c6RyA5ynk8O3XFMaMCU19dWLx0k9HZroGmpnFYnP5kodg4H10JFqvctnxeDo7VOXevyKSiC2z2mIX2x/KyBQwgop39CDvOTZJn0J9FFlqeAVCsgkM2d4bC6fnM2CgfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aOzyLv25rX5dkvRcgjkQQd/ZeYayPco8k8lVXUf0knw=; b=epiFKpBYCtA9DbqrHK0id1/IsplK2HgE7biEmdrjR5FXDsCWc5fIhB3UbChjtH60m+IbbbiKFIHd1RpTg4vQV4VsPwMsJdCuwwBBVaxBxZNKDHBhajAWrOusoLCu0StxuooB0FekLEyEFUrdA0k4n5Q6StZHI3HaTej2CdXJrPc= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB5684.eurprd05.prod.outlook.com (20.178.115.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Thu, 20 Feb 2020 15:26:45 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9%7]) with mapi id 15.20.2750.016; Thu, 20 Feb 2020 15:26:44 +0000 From: Raslan Darawsheh To: Shiri Kuzin , "dev@dpdk.org" , "srn@nexatech.fr" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix running without rxq Thread-Index: AQHV5/v4KMeDbzamUUmK0pSEKZ9n9agkM0pQ Date: Thu, 20 Feb 2020 15:26:44 +0000 Message-ID: References: <1582209716-26527-1-git-send-email-shirik@mellanox.com> In-Reply-To: <1582209716-26527-1-git-send-email-shirik@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 92de3065-96f0-4853-a9d2-08d7b6194b43 x-ms-traffictypediagnostic: AM0PR05MB5684:|AM0PR05MB5684: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:457; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(376002)(346002)(39850400004)(396003)(189003)(199004)(9686003)(53546011)(71200400001)(55016002)(186003)(26005)(4326008)(6506007)(33656002)(7696005)(2906002)(8676002)(81166006)(8936002)(81156014)(478600001)(66476007)(54906003)(110136005)(52536014)(66556008)(86362001)(316002)(64756008)(76116006)(66446008)(5660300002)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5684; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FbI8Cx2U4o0lPtF0DLk6zIMTrxh3uNcSlny1ZljMCYbldkQ0DEzH0bIXaJsr32q6wbsUZHbkBYkHcH2YqeRMj9dHELLbiV21g1UCvsBe0wW5gTVwArJtyg5wvGOP8ioJzIoHRv86baOtIH4YOOp0NhUgmY5UcSPKQC909SNSWKDLq0NGgZ8TDRtwxnQYKanlAa7vutBllCZteNeeXeCWGzTkfuTEZBUwQlTNUsJ/0uJVSfRRhRPvgI53+vnpL9eYj2yZ1Rd57GpT7pe9mYbBjF95+AihoCdmI9kAe05EN2stZu1eFfZda93Z+jqYVURye959zry6kPW/Xj7CF+9Bm5qnoIih2acrFPLm5Gs6XGQcuBBi77sUL5e8RRBF/DZgDczz6PUz330cqaf8kFWv3MF1QtKEmrmYzPdqqs67bF0SfP9ew2AUc+NONMSJ/e5l x-ms-exchange-antispam-messagedata: fkCjP99Zft/ykSZiGMY4GyO2g1E1FHgTXet8H2jg+q/72yUZ6ypfwOlxLZpIpvDEJL4/SgOcq1jSi6CD8j4kbuw/kCY0z4FL1immmXTw+rRicYUXR01vHL6Y6eD2QaroPR6FYGem4rPk/TI/8MA42g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92de3065-96f0-4853-a9d2-08d7b6194b43 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 15:26:44.8352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4XsbRhD0+gG1uKlwE6LczPCmI3U0B7KlU2js1v1DzKC/kWKtVVFKQZ7H+k0EKW6Ds6CtJXVtK8U3zl06zLwaHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5684 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix running without rxq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Shiri Kuzin > Sent: Thursday, February 20, 2020 4:42 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix running without rxq >=20 > When running mlx5_dev_start in mlx5_ethdev the function calls > mlx5_dev_configure_rss_reta in order to configure the rxq's. >=20 > Before mlx5_dev_configure_rss_reta there isn't a check whether > there are rxq's and if rxq's are 0 the function fails. > For example, this command: > /build/app/test-pmd/testpmd -n 4 -w 0000:08:00.0,rx_vec_en=3D0 > -- --burst=3D64 --mbcache=3D512 -i --nb-cores=3D27 --txd=3D2048 --rxd= =3D2048 > --vxlan-gpe-port=3D6081 --mp-alloc=3Dxbuf --rxq 0 --forward-mode=3Dtxonly > would fail. >=20 > In order to fix this issue, we should call mlx5_dev_configure_rss_reta > only if we have rxq's. >=20 > Fixes: 63bd16292c3a ("net/mlx5: support RSS on hairpin") > Cc: stable@dpdk.org >=20 Reported-by: Sylvain > Signed-off-by: Shiri Kuzin > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_trigger.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_trigger.c > b/drivers/net/mlx5/mlx5_trigger.c > index be47df5..571b7a0 100644 > --- a/drivers/net/mlx5/mlx5_trigger.c > +++ b/drivers/net/mlx5/mlx5_trigger.c > @@ -280,11 +280,13 @@ > rte_net_mlx5_dynf_inline_mask =3D 1UL << fine_inline; > else > rte_net_mlx5_dynf_inline_mask =3D 0; > - ret =3D mlx5_dev_configure_rss_reta(dev); > - if (ret) { > - DRV_LOG(ERR, "port %u reta config failed: %s", > - dev->data->port_id, strerror(rte_errno)); > - return -rte_errno; > + if (dev->data->nb_rx_queues > 0) { > + ret =3D mlx5_dev_configure_rss_reta(dev); > + if (ret) { > + DRV_LOG(ERR, "port %u reta config failed: %s", > + dev->data->port_id, strerror(rte_errno)); > + return -rte_errno; > + } > } > ret =3D mlx5_txq_start(dev); > if (ret) { > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh