From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F06EDA0350; Mon, 29 Jun 2020 10:44:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A3E382C01; Mon, 29 Jun 2020 10:44:45 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072.outbound.protection.outlook.com [40.107.22.72]) by dpdk.org (Postfix) with ESMTP id 3AF0A1150 for ; Mon, 29 Jun 2020 10:44:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZoEj1gaNAdq2pAVel+I+lc5AE6hxsPoaJFpzr7uXz4wk1+HK7Sx04phurSTvxds5vOIiGDQNPdnfYe5fW/sX8Fq7FnaKcrna4fLXvVhUxhfIsNYyPOU89ITM8N6vF+e8xCKAvudcvIQImvOEfMSVatgartDERPeQgA892qZ1ZB4WvM8n7w35eXHFDzuKquJwiNQiu2639oSqwpV93p/LM4Ofb45D3IlJKWHUFb9dfkOBQEKsMoJALHHulMmvmmXjB15wKRbHtbZLa23mN4r3h7wE0blUtxpYD7cRQ3U18f4dIRFuP1+nJ2bUHNmYDJw+ykct56DJ1l8g7x7qTpykjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BOkwEmTrnfPaPhgKInSibwaj9XA2bujkMwm3MxcucRk=; b=boh+ZhEhPF0N2ujC9GO0vKpGE9nCqKFvYVz9eVjem0IMe9rfivtUQl2rOYAf5z0/kBZoZeCUViDMFAsmlJBvMKtEU9Dlm6awMnTmIMElWf7kIg5HSff1HXABdEKYI09o/UmU4dA5b4m8FDfOa0QQ52tSmcJLbIv8AenX2g+XA67dnECQjqHX7XDSZVGKNZ4BHUFKRR8JsO32EWVq5goet0XumBXNAYwqlG7sJcuagi4qh9hyumNUu37V073L/xXZ9GgxQEONvChdukF6JN4aV61myAR6Vt42NV889cisgclt/eyqlyvTP8fnIbw1scn91/xUO0PUNAHaWo3X4eGhXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BOkwEmTrnfPaPhgKInSibwaj9XA2bujkMwm3MxcucRk=; b=ORFzOnGZOk8vPdL5EWae082Q0RVtPNicXcfdfKRESasR2Bj+W1EhQCUPVaZy99azIeSAPjng8lvx/GawakgMXo/gcteiHaeNJlDz8QN3G9YMWxuWuvbbONWI7Czieun3h/o26+P8/pTDgGvata59g+WbSKILoTTZZYXKD1PlEbk= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4851.eurprd05.prod.outlook.com (2603:10a6:208:c1::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.23; Mon, 29 Jun 2020 08:44:42 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%4]) with mapi id 15.20.3131.027; Mon, 29 Jun 2020 08:44:41 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko Thread-Topic: [dpdk-dev] [PATCH 6/7] common/mlx5: remove useless assignment Thread-Index: AQHWShujjBTUAhPTfE6i3pxnqE8nFKjvTm9g Date: Mon, 29 Jun 2020 08:44:41 +0000 Message-ID: References: <1592998387-28181-1-git-send-email-michaelba@mellanox.com> <1592998387-28181-6-git-send-email-michaelba@mellanox.com> In-Reply-To: <1592998387-28181-6-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 837de7ac-59dc-4660-b2f6-08d81c08aa87 x-ms-traffictypediagnostic: AM0PR05MB4851: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-forefront-prvs: 044968D9E1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VkQ53XdleQDt4gf2UAypPpmQKkmsSCVqXXDq/IeatENAFKcotwlHaHP5nvf8LdoH/urchc9dj6xdWlEnIKFAnH/HBP4xVcTZdUZ2j+rYWeKPrtC6+AsVC1ZHYS+3FnBjoDVm/P5tOByX+kFXG1nQQL0o9sUoNjyEoVk3A8FQbSD7gAqyF6xYj/2XgBX8fdQ2piGcpF7RkKh/1ghr9cVO6NTh6Begvkx7WMI1/N9ZnmmlsYXnCi6SD+YaORBKWfPFKBW7shs+XA9XMCsRBZ0xt7nAnjN636EfqL+DgG5PvOsDhmhWYImE68F0Lw5ZLBw//YVby++ysv3e1k+RKxM69A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(346002)(366004)(39860400002)(376002)(54906003)(26005)(6506007)(478600001)(186003)(7696005)(2906002)(316002)(33656002)(110136005)(53546011)(52536014)(4326008)(66556008)(86362001)(107886003)(66476007)(8936002)(64756008)(66446008)(71200400001)(5660300002)(8676002)(55016002)(9686003)(66946007)(76116006)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: VXC3eNqKprNQdNf+ZDGu1zjeLRlNGGpQgYH+FErgmIdQ0YN3f/rLfDoKCZYVJRJOn7lBmWfvW/T4u2dzAVJMEfGyXxtPh2Vfau8ZKuYk7QWnVQ2rpED2wnflD2UXhjT00CI32U+5mSLcBTmw4+5jCRsR3H55gSpT4fVgNDlpilVZnT4QheJkWDHkgtDDM2qiqUvvPs0gc9LGR9x+WuqC9B5a3Qyrw9JQAm4H9m1OabOFDbGiDqjNRxMolR4TQAoafH3E0sKZN5R3HG/amUXN5tqZZ/clnHu/xYliR4X91fMMw3qif9zsmB35Nh/6kzwptuJc2N3brXzU8rFCWvm5BjzUe9DIb2pETFEx3o/7hcAvO6/SnzHNFc2zn9tDp9dG1kQaByCU1NLAtNzWWkHIMfOqZ5GunH6BGnU7wbKysYrzqJH1mHZEu/kcTQghFqI+FvDcwP8ViBi4F3k4rymLUolyFzePJDJXyFZc1wQVZQuDtqPp/ferkd7rM9ksmcbZ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 837de7ac-59dc-4660-b2f6-08d81c08aa87 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2020 08:44:41.8195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c7ZGNUmLczUzxpkfJcZsDZGoImJLdY2Xq82A0NvkPbTIgHhS/hL1ijG5MCFSJnyln/TlophIWt1eOnsM/JGlaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4851 Subject: Re: [dpdk-dev] [PATCH 6/7] common/mlx5: remove useless assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 2:33 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH 6/7] common/mlx5: remove useless assignment >=20 > The mlx5_dev_to_pci_addr function defines a variable called ret inside a > loop and uses it. >=20 > During the loop, the function assigns a value within the variable and > breaks from the loop, so that this assigning has done nothing and is > actually unnecessary. >=20 > Remove the unnecessary assigning. >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/common/mlx5/linux/mlx5_common_os.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c > b/drivers/common/mlx5/linux/mlx5_common_os.c > index e422e95..e74aa89 100644 > --- a/drivers/common/mlx5/linux/mlx5_common_os.c > +++ b/drivers/common/mlx5/linux/mlx5_common_os.c > @@ -66,7 +66,6 @@ > &pci_addr->bus, > &pci_addr->devid, > &pci_addr->function) =3D=3D 4) { > - ret =3D 0; > break; > } > } > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh