From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29E85A00C5; Thu, 30 Apr 2020 11:16:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F91F1DA2F; Thu, 30 Apr 2020 11:16:22 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130088.outbound.protection.outlook.com [40.107.13.88]) by dpdk.org (Postfix) with ESMTP id 9B7541D979; Thu, 30 Apr 2020 11:16:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M05/F9F55tiK+ZCner6xcTPdXMzWBKUUhKd75Iz3PI1BlSY73bruWUfbe1uw0qv2My1jKIAzDOIgGs0Bfh5xQiUwsHzXwc7pklj5bDU9Ynj6F4HCFLbhn71u+hN4NS35oaQ3Pe0q8ZauXJWfYgmPIW/vRTfbbWQKc61baY2SQBf+8XbQz4qfZIlnlRY+m+yHfbGiMNhu4TVbxkdPPFVe4U8n5uaod1NKsu0XEwZFKQV5A6XH3t9RKTnbGLjsyjlYAJX2WNHutY0Uy9NIhvOA03ZWGbKgjKjD9aKcECx6DMoJ3oXbqzXOP51WfrOIPPqHJ2yWvSbRjj28C6mS9y6IIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PfWKhf4nLAs5iRek3e7QPPp2C3wkbCg/F9GM2+ueZHM=; b=EHPXu4roOeC091HPDdYWUuY1tSaYRAFBOeXVFnrDSVomWEiqoiQYoD/HDvsnVUCrb+Tug4LeKZr4qWuMvgcgSOJ3VfVCE5kOZXsTRMKTDAp0MQqt/CiCYOmqd7B2Btv0baqhE/LzpIXELn7+WYbNnY0pJjB77oOQjrIsXxGWaNkVknFuZJQoIsdKjQCRARJnxcsVj7oAtJPfMLLZeCR0d7YOM5K3GUhbtWnzqMxmFjRYV93yUxt1iN0FRfrSSr+O0vlkbfqYmVx/U+TMyALRURFwIdv5qbN1yhstw9CW8F4pZfhPHJYyN6k9V+BgIGwB6V+FNM6Vn9UVipi7JhfmpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PfWKhf4nLAs5iRek3e7QPPp2C3wkbCg/F9GM2+ueZHM=; b=TYJC/OxPVU3wE4WsyF3tpukCqcP55jIOMS0cvh3sldaGtU9e57KuwybFmkuR2bYzvVb20MrxsjoJxfpeLl/EvX9TKovy7tUpcmtmA4xlfOibE4fZlTQ7dse1QESkON0ZGOonNlU8yoZyIuzo3wSvRhA0AEcHCJwi1Db4NnQdseE= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB6787.eurprd05.prod.outlook.com (2603:10a6:20b:15a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Thu, 30 Apr 2020 09:16:19 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%5]) with mapi id 15.20.2958.020; Thu, 30 Apr 2020 09:16:19 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko Thread-Topic: [PATCH] net/mlx5: fix assert in dynamic metadata handling Thread-Index: AQHWHMCCrCQoFZZ890KuIowEZh90MqiRZmtw Date: Thu, 30 Apr 2020 09:16:19 +0000 Message-ID: References: <1588011611-16935-1-git-send-email-akozyrev@mellanox.com> In-Reply-To: <1588011611-16935-1-git-send-email-akozyrev@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.230.216] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c65ff16b-f86b-4287-e277-08d7ece724f9 x-ms-traffictypediagnostic: AM0PR05MB6787:|AM0PR05MB6787: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(396003)(136003)(39860400002)(376002)(66556008)(4744005)(52536014)(64756008)(66946007)(66446008)(66476007)(2906002)(53546011)(76116006)(86362001)(26005)(7696005)(478600001)(5660300002)(186003)(6506007)(71200400001)(107886003)(316002)(8936002)(8676002)(54906003)(110136005)(9686003)(55016002)(4326008)(450100002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NQUqFVHKZFSMktZU75MmZrY8DKmmQS6j8C1VvuioOnP6UfV25h+N5bfyc3HBe4tPtdJ4ZaeEex+rCysoxDSbL/DGBXa5PFbpZYLyimkLCU7G0NClClwY090lMNmmeqlSu7BrBSSGmJiAG/PU+meosqFyqm8bnZr5OKe7XAyi0ccrtjYycOYosqQNIOZeo3Ut8xoMoGh3ZusZ2NZkK17DNlyZulAYblpr7Pz1Bwlal9z7tL3BTd6iLl15txkNRAUWGHQmsBAi7cL4w1ijLcgoyfH0QTIikhMmD52nRfaqql/26rDQPDr2W3pN8yfOD1O/UnZ8pIL7gF1fjEXLPbZPBEjFjJFsPTgp+Mj/HsMnJu6vOG9PAJZGBTqqAwHvfztxYvZXWu7DXKJhO/qQvtR5uEj2w1cXlQr2YdTQZ196vLHdJ6OAyBRWKYZ4vJRsL9EK x-ms-exchange-antispam-messagedata: fuit3TxsbKW0Rhfh2Cs1PN1YjSeH08ZzWk3t3TqSRTVEWvumhCI8ZxiHB0VKqH+VolH3ap2uubFB3uAG7f43kh3HfNH5qY7fd5pi4VzR7AZnRWcVbU9nxChHTGaIRoEv4+hTYPLIMZmRLFPgCD8t9grY3MCbOxZwp9AJABZq7HlWwn/1LIXxLyJm+0UX8ACDMc+pmJx6qjZUesM6IDMXa2yu0vwtjeSK9zVqKNMxuq0umkCjPyropN34vYKmlAa5GdXCr5n02I93NH8AFEB/FZ8HD8+zBk5VQpJuByERjdCHIvXrAZOVirzNSi5cGc6ZtogX2S88wm46WMjSyM8wJpijTfPik5EIStBkA0qQROxcq0Cq0cgVlnxfObUKTrwJadn8ehRC82awljd63wolr9mLjWjGELzDKr7G26O/MljWMaB5TYNi5uGa3xL2ymYIRnCar8AjYxmPPKdDSt4SuZbZRjHpcGywQ2Jq6mQeZI7bb2iNe7xCjT1JMw0yfkdcULX/NZoZ80wCm0UF1OWtItaDlqSnwBKU9Du44PPxH0Le7+FSxeQ4jt7FGqi3nJ/2E59wPCa2gzFnaf3ZsEN5D/r+qnjhGMdbiFJHzcskWNQDm+ooqipcADCvttctVFq86hB/gFIwDls6u+v88a5Rfi0zo7Pg2jijLta78SeKUPfYrUw63lRFpBnkrUPqByCCYOaY+5JYN5O+KjZJc9RtMszqjZ0CU5b8mp708y7ithmalbhheTQRUXYzt2kiLM080Nu2Zj93l9KtQEEA5IKC3PAox4SJEcB37SIbakiRuM+Mrz1JYUP7ttC8A7mitu0c Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c65ff16b-f86b-4287-e277-08d7ece724f9 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 09:16:19.6468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eenEcHbcy42m0jgGA3UR35ZqvOk7zEhk3l8BXBJjGs5fe50AXaGGmVVX8jZBf6Lua5AXYD2kByd4kQV8K9GRlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6787 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix assert in dynamic metadata handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Monday, April 27, 2020 9:20 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: fix assert in dynamic metadata handling >=20 > The assert in dynamic flow metadata handling is wrong after the > fix for the performance degradation. The assert meant to check > the metadata mask but was updated with the metadata offset instead. > Fix this assert and restore proper metadata mask checking. >=20 > Fixes: 6c55b62 ("net/mlx5: set dynamic flow metadata in Rx queues") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 7 ++++--- > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 5 +++-- > drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 3 ++- > 3 files changed, 9 insertions(+), 6 deletions(-) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh