From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75828A0555; Wed, 19 Feb 2020 12:52:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18B921B13C; Wed, 19 Feb 2020 12:52:53 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2046.outbound.protection.outlook.com [40.107.21.46]) by dpdk.org (Postfix) with ESMTP id 44D0B3B5; Wed, 19 Feb 2020 12:52:52 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RQkPKnzoeJvhSK3E+ckCgD76syKa/i/msrZIlT1NSRO+Ahyy3kGn+VRNWJSMSE4S9fFrugZpDoKXNsBv1yhnc1vJQQD9QUpkkFozyNmSyhlZ/HgndG8J7bnTBJvXoVkW+urVGj1q1UNpqicIce1w+Ftk4gJsGbQdJ/jCBcPkBh+0hEjHDI5kYIqjwotsfBW+7bV4Sa8IRjwdC1SV2dubMkOk7WS5LmjEDpGRDEWsXTq6KXqps0PpJH06kkviwq0x522+U+8PJkQUKtTRDb62EBy5hTLVo/VdvDvhh6kslxQVOrwVzTUKuA49VA/LEmz2i2qZRAdH8CMtaGvs9OJTMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zn4bZmflqGOja0PmOgH5M2QjTOeJp8MY1+pFnl1cPsA=; b=VKG/6dScW7iztX/J5ODetWHb3u0LF3DjDmwBjNrWwYCmWocwRvFWTs10sjgEdH7UHAsIGbMGOYoCSlNsbMKWFoaYa4a+6CF4ndvrnP8viJqNhpVHDTGTNAmwaXAmr0CBR/irX/0WMZSeOTGAw6kpm8nGR3jeGuOktoj1Qpi/xzvkroTtxLfDp3QB1uPGsKqGvOZSu5c8GRRBATt4yB+xgAQ3mn8hfJ9ofH6kaCosTZU2AQqedg7InHJ4fzMNHfwTIUJzhEQFhFXNWXXsERvwzwhd1/+9WDvNla6EYoCDmhtpg/eYoOKJnzhljkovxtePUEefA7uwaNVrTHNzPzfKYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zn4bZmflqGOja0PmOgH5M2QjTOeJp8MY1+pFnl1cPsA=; b=tfzVafObEVwN3slEBhrOOphZWQxZTDJ5OzeVHlvO84j3IM4KS2zLf1ChicCw2pmaAnx9XDXO+mVHyCJMOh1y0LrrB2uyGyjxYunTT9aNxgDpylfVvCKx70cgEtoyboPD+vhvYhmJKHWhPDmJOeKs0Sahb7SLuwnaT4NlUO2Pshg= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB4788.eurprd05.prod.outlook.com (52.133.56.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.24; Wed, 19 Feb 2020 11:52:51 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9%7]) with mapi id 15.20.2750.016; Wed, 19 Feb 2020 11:52:51 +0000 From: Raslan Darawsheh To: Shiri Kuzin , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix ipv6 type icmp6 header rewrite actions Thread-Index: AQHV5lI+yqR8wuzGLk+c6hYBWKAj+qgiaX+w Date: Wed, 19 Feb 2020 11:52:51 +0000 Message-ID: References: <1582026774-10127-1-git-send-email-shirik@mellanox.com> In-Reply-To: <1582026774-10127-1-git-send-email-shirik@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ef28bf9e-646e-433a-a381-08d7b5323f8f x-ms-traffictypediagnostic: AM0PR05MB4788:|AM0PR05MB4788: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1079; x-forefront-prvs: 0318501FAE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(396003)(366004)(136003)(346002)(199004)(189003)(6506007)(53546011)(450100002)(66556008)(86362001)(66446008)(478600001)(2906002)(186003)(26005)(4326008)(7696005)(54906003)(81166006)(52536014)(8676002)(9686003)(110136005)(64756008)(81156014)(8936002)(316002)(66476007)(76116006)(66946007)(71200400001)(5660300002)(33656002)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4788; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6V/RfujyPvNcX8T9XubghGj6guF2xYPVfpk9lEFoZmczUPd2h9z4mc6PjDfSiTnZJlMSUHEdSsUxFdQy+7zKSzw0QWQh729UZ8hi2/W9eOED47fN7JEnU7a0goPJT/KAS5a5OHD6e2xLzqXrqrgnrndMUo25BAMiQkuu2y6WhvGSHnju0cOy5h/7lolKr5KDiCqTdJrNN+kvx/IvEC5F1Vy+d8nscnudHMtB9lS1SJ+Xv1B+oD91ty/zX0W6RVGl3++5TSFXyXdMCrDdXNlpjaoH5iEGVzY3tvowETrEctli9RUIZ//sey3liv4V/F5N4T/ZxZN8sb+pkrthHt5gsCz+xZRDg2J7EdB9L00NSRufXqbz3o+JjMF6Jq/r3HbNoeAGwyL5zz/n9eJSQ6/rCm1epABQCIPue530BBgDjIqwJo8mfmmEAMEi3uKk+E+M x-ms-exchange-antispam-messagedata: +u1BCAE4DcRppXYzcpPXVZXJ1mUTH+NGWKt5jXZQHMNC3Ln5KWvTbFj1wy8uq8XcJizUN9TPyKhE4UcL8fY4OHpd2IJaX3QJUb5apztUKJ0jQp+2Q5jVRHtRCtDGh5ssO3uQgegWhyrfDshmzmfXfQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef28bf9e-646e-433a-a381-08d7b5323f8f X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2020 11:52:51.4390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RNpB5gGhRiJ1P4sPVI5GhvhDgJdQL59ZFUBZRZ5k2httnZtfg2s7vCMEyW4tpPwBkWBep9z0QNMo78aBnxj7Ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4788 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix ipv6 type icmp6 header rewrite actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Shiri Kuzin > Sent: Tuesday, February 18, 2020 1:53 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix ipv6 type icmp6 header rewrite actions >=20 > ICMPv6 header contains the checksum field, that includes the IP > addresses from IP header. >=20 > The ConnectX-5 hardware does not support ICMPv6 checksum calculation > and in case of IP header modification the checksum will contain > the wrong value. >=20 > The patch rejects the header modification actions related to IP > addresses if ICMPv6 protocol is detected in pattern. > This issue was also partly fixed in commit [1] which rejects > flows with the pattern "ipv6 proto is 58". >=20 > [1] commit b1632bd0c1e3 ("net/mlx5: fix ICMPv6 header rewrite actions") >=20 > Fixes: 4bb14c83df95 ("net/mlx5: support modify header using Direct Verbs"= ) > Cc: stable@dpdk.org >=20 > Signed-off-by: Shiri Kuzin > Acked-by: Viacheslav Ovsiienko > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow_dv.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index a9bb0b4..e5862bd 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -4621,6 +4621,7 @@ struct field_modify_info modify_tcp[] =3D { > error); > if (ret < 0) > return ret; > + item_ipv6_proto =3D IPPROTO_ICMPV6; > last_item =3D MLX5_FLOW_LAYER_ICMP6; > break; > case RTE_FLOW_ITEM_TYPE_TAG: > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh