From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91D90A053A; Mon, 27 Jul 2020 15:42:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCC2A1BFCF; Mon, 27 Jul 2020 15:42:20 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40055.outbound.protection.outlook.com [40.107.4.55]) by dpdk.org (Postfix) with ESMTP id DDD361BFC9 for ; Mon, 27 Jul 2020 15:42:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LKs8oSAGpAuYl8euyhQHcqYn19n/JfpGGBE9didAvH+sC3XpnLOhXUBnFQkc4HrGQD/9+cejeQtiM8zgUGyaMdTsclsRqzDw62l2aa2wHwAw7V9YTBNDcwDpN1RVDjsQDMY1p46GmumGzWj+e/S8XRTKoyEVZaMf8sPNj9lhEgcQkDWRk7F5qxw+1HjM2mhFB2vXiLsDtl4fJ82UXUWdaGsqhxhboSGojNb4Z/ihvfDIDvpq4vU81P28b2uTTQZAlIrVhuDN8XvJeLZ03bU4JmD4EQutbNeuod2UksHYilsEVEKh6QGvsz/th7yOrPUy4sGRNgOmGzJcUWjOzGDngg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uaS7Aypf9+7QzE6wa7okD+2cg3xLdW9w0P2Fz2MdIlI=; b=IiJbbsVgl3VPzQQR0bsvCjWBTxBLalWc8UWeAuzt/rbGswYqjfZIMNIME8HsfwdYmlw8ITAR4nFawC+eKwcv/l72dZQuWnPnjntkroi/uvs6kSyNojJ7VvJgwwAR6w4wyMatdW6sWe/ZIAcyYHo5sk4G7PPVn2Lu8OUnGhqICjJ/Lw4MhC13l/5fDIZYV090XchrDXfuHz4c6NivJ8Qs4K4cdU5my9JlQhxFWhWy7YYaunv+x+Dq02whsOdB90XgB5gkyg6lc8GjqAgk1Nr6itcM82yLyon6p4qpmRPYSKw0MN607lI+sPFdWVJxNd6Rocrd3LTKuj6lKhT30hS0EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uaS7Aypf9+7QzE6wa7okD+2cg3xLdW9w0P2Fz2MdIlI=; b=sZt2M+VSqubm+gS5rLICHxY4XFmS5OX6dcmK3C8Pg1KTMS1codK1m6GQm1db4xfB8pB2lQsth8HWXZHPOqN/q40hsywBwxNXWkjhfFoyx0wKuL83AuVB7i3S2IAfiwMNhykeWLi8QgMz92uxti2Ot9k/lQdWjRLL/vo4YO08Fm8= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4850.eurprd05.prod.outlook.com (2603:10a6:208:cb::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Mon, 27 Jul 2020 13:42:19 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3216.033; Mon, 27 Jul 2020 13:42:19 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix CQ interrupt handling and cleanup Thread-Index: AQHWY/N7niGztEEXR0uW9sgyOPDkkqkbbcFw Date: Mon, 27 Jul 2020 13:42:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 70731e87-3085-4a77-b4c3-08d83232e1c1 x-ms-traffictypediagnostic: AM0PR05MB4850: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1201; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JjqRpNzxPfXiY2mpYjKZE0Lzhgwg6hzjTSDeOr0oSkyFNX5tGtNcHgdFb73asjlkqtz59J2i9U28M2By5C9z4pKCj04lJOabr9VyyfF5rshve0Inn1CgZTEvJneff00Cs0dmrLqrcXmNM/vLst0nN16kS9kc9wneTt1RD5HbY1nVQzvaqR1Fz8u7oPYVuMHnODu9xtLRkAGFLuKsAnuwq4CeTBQ7g/49bMDtDhRsLKLZ+YlSt/2RZbiaXycyTwY8IRUIJrkJpbu6LpiPMyyTrreAQuypzDcWUvXjSL4tXNmw6sTnIdz3aXEzTvEEBTtTIwmaUcz7pt0dWYe1Rmifcw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(76116006)(4326008)(66946007)(66556008)(6636002)(66446008)(7696005)(64756008)(8936002)(33656002)(66476007)(71200400001)(9686003)(55016002)(2906002)(5660300002)(53546011)(52536014)(86362001)(478600001)(83380400001)(8676002)(186003)(110136005)(6506007)(26005)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: yFTmGnDBI2YekbOG0CkWgLsS4xoB/qXuyguEFE9nIyEQ5SczmKUO/RdijYYp0nAaE4Gkc+NHTrq6Ff9OSKerFvNCr8aELTARGM3q3cpHq+ssqvLnAxqcicp94DNlXgw8hFuEQMn+qfTYDZlL8NDMkXLcn4bftVpUfTVThvvPHjXesgOXHAOX9xZKCQ9c+YFVDjnYxHRA6B96Axi74mp/XOVlgmam7klvK3PxeFyZPP3aYmZNBv/RRGW/GM11/5c2sS7GSZWK5T0vqfAkjIQ4fSicYPJmVUXT7UBDVwLLnNmYpQmJcUuYY56OLQf9JcJ70XtxvztSvmKxLHPvy9zQWg1SPxPT8xnlfByiv6fWNKnGZlAUgGFRu9A9AZ8yqTMwEFHCXIFi2LMBUrWBp9Ca8LDLlhSkA5rhlGDg/FuKz5W/r7nR8g+b4USLTrcVLmdnlBl63DLHY2s8htLEmGHHbIrktv/be/n9COx8IQUc720= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70731e87-3085-4a77-b4c3-08d83232e1c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2020 13:42:18.8962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R8BAxHqEukodEZ5P8w/fxhchlqADLi/aYWZsilDFPGiazZJNOvyTltjCBn9Jrvc8nGNBiTBUkkaNJbOGoIHWIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4850 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix CQ interrupt handling and cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Dekel Peled > Sent: Monday, July 27, 2020 11:51 AM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: fix CQ interrupt handling and cleanup >=20 > Recent patch added creation of Rx CQ using DevX API. > The reading of events from DevX channel was not done correctly. > This patch fixes the event reading, using the correct data structure. > Cleanup after CQ creation, in case of error, is also updated. >=20 > Fixes: 08d1838f645a ("net/mlx5: implement CQ for Rx using DevX API") >=20 > Signed-off-by: Dekel Peled > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxq.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index c78e522..79eb8f8 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1193,12 +1193,16 @@ > mlx5_glue->ack_cq_events(rxq_obj->ibv_cq, 1); > } else if (rxq_obj->type =3D=3D MLX5_RXQ_OBJ_TYPE_DEVX_RQ) { > #ifdef HAVE_IBV_DEVX_EVENT > - struct mlx5dv_devx_async_event_hdr *event_data =3D NULL; > + union { > + struct mlx5dv_devx_async_event_hdr event_resp; > + uint8_t buf[sizeof(struct > mlx5dv_devx_async_event_hdr) > + + 128]; > + } out; >=20 > ret =3D mlx5_glue->devx_get_event > - (rxq_obj->devx_channel, event_data, > - sizeof(struct > mlx5dv_devx_async_event_hdr)); > - if (ret < 0 || event_data->cookie !=3D > + (rxq_obj->devx_channel, &out.event_resp, > + sizeof(out.buf)); > + if (ret < 0 || out.event_resp.cookie !=3D > (uint64_t)(uintptr_t)rxq_obj->devx_cq) > goto exit; > #endif /* HAVE_IBV_DEVX_EVENT */ > @@ -1646,6 +1650,8 @@ > memset((void *)(uintptr_t)rxq_data->cqes, 0xFF, cq_size); > return cq_obj; > error: > + if (cq_obj) > + mlx5_devx_cmd_destroy(cq_obj); > rxq_release_devx_cq_resources(rxq_ctrl); > return NULL; > } > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh