From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77989A052F; Sun, 26 Jan 2020 22:44:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 110064C74; Sun, 26 Jan 2020 22:44:07 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80049.outbound.protection.outlook.com [40.107.8.49]) by dpdk.org (Postfix) with ESMTP id 84F20397D for ; Sun, 26 Jan 2020 22:44:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jEcpb0xU5MzWLdt0MzC835TwpEwJLYvTok1avQ6udexX3X5MNZfYjWpj+VEoQETj5Uc2u9KF7MY8peZ9jXSzvb77CVKcbLGTk6+8SuuIOavFPe7es2RR6V7SnqWwn8/a1TvSv/26XHxoHqL6hOMPdxAeJnjg9RolZ0YhNQ/C3WioaQc0PZUYVNyIuwKOpJaOJfLf0yi7Zzz10KU5v3KKDP76mcvIAaPzWiYBTOnrxT9fckP1xgQnuR9kw84H2ZAwxhSwEPT5QAxerbx74aolAiG0lRJCqcS3AEkBDSz+lJyebei5dgCDqNe2SXsL577cg6uy9ALY6A5O/KNRtXJkew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6Mhpyu80Vh2Bj9+yNStTOqcG9tzx/Ff79gvSm30yKo=; b=KutVP5+phBbiOhfyCMX0Mutl/1NlxULgesB+FbPv7RDtmwJjaK++K8WsNhzRu0WoTPBYioVSbLsEb7xqjN8PKD05lHscOen8MtVSIC0C7uEU0MP3IopP5qZ/53FLSENNqcYvf4xnMRpc02QAs28zuu8ytOdKD+A65P2oOXjCYbHlUpC8yFnC/7RoOXroqHA0AAPkO/0FiWYu7KUNMm9UwKrnJUPdN0wZZuQFQz0Y1hdmJRq682xL/VWJgQXAtVD2ne8rF6W/JbmOYk9Lay8umqbWBKxZ1Fnjt0SDb5xweh4Zg796Jg934McX0b/eaIlVBEmzWNWCIQNenHpVqlDAIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6Mhpyu80Vh2Bj9+yNStTOqcG9tzx/Ff79gvSm30yKo=; b=MOidDw2v6taviC96pGqNN78LL1p3I6epz/Y2e1jp7+G56mgdKzzuTLBPqJ0ZqkHtfMBmWbuGGy3GVaze4X2xP9cvsXt4xYPizfdkoZXgXUn0Qn4ws8qIwWzm1lTWPkq4YGjjyG1pKV7iZpB2WjQ0GcXorJRGMAP/VfGYYk4IY7g= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB6162.eurprd05.prod.outlook.com (20.178.112.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.23; Sun, 26 Jan 2020 21:44:03 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::f0b7:a92b:aeb5:5761]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::f0b7:a92b:aeb5:5761%5]) with mapi id 15.20.2665.017; Sun, 26 Jan 2020 21:44:03 +0000 From: Raslan Darawsheh To: Suanming Mou , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/mlx5: support maximum id in id allocate Thread-Index: AQHV0bKSEBo0DzDqQ0W01sn0u461taf9f/tA Date: Sun, 26 Jan 2020 21:44:03 +0000 Message-ID: References: <1579759262-189720-1-git-send-email-suanmingm@mellanox.com> <1579759262-189720-2-git-send-email-suanmingm@mellanox.com> In-Reply-To: <1579759262-189720-2-git-send-email-suanmingm@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [188.161.228.203] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: abd46bbd-11d1-4898-5def-08d7a2a8dcbe x-ms-traffictypediagnostic: AM0PR05MB6162:|AM0PR05MB6162: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 02945962BD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(39860400002)(396003)(346002)(376002)(199004)(189003)(4326008)(76116006)(478600001)(66476007)(66946007)(64756008)(66556008)(66446008)(2906002)(81156014)(71200400001)(186003)(86362001)(8676002)(26005)(5660300002)(316002)(53546011)(6506007)(81166006)(9686003)(55016002)(52536014)(8936002)(7696005)(33656002)(110136005)(6636002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB6162; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OIc9ubYOf+c6ucqiLGH8KIlfwTWdI/PHJ72ejOq7Kx1HRU6xRdqHzD4eD16BGOeAWCAbrzeUdeHtzvSu4NUQE3Ea/PwoMPW41SBgaAYMKzt1dBMh0gBDYCXgV5rZ48UpLrgtgYO06IDySBo3gmqq/VS6hTPG8UjAz/QvUkRMZMupKUt8Yy0S1o9E0mQBBzSX0zYogzVzWRwwqkDMwaSKF2acgI4/yccwigcAE+ODOLn+2eoESxKWDUCCdOkTTXX0f9343zWQOmjxbYIxD4GY24RGgG+lkWbbvgOaAiB2hBZhI+O3y545hpz3h4TcrGCbEgcrhN11TrojH3UKvAq+euQcUCpvfWAifzgnBNIeKyw+U/N870LjiaRNaygo3apdV6VAO/HK6l2ZvmbeslsG2ePlpU8agLxHcMvmnjBGKUNPEbekh/d94R5R/mffL7Ij x-ms-exchange-antispam-messagedata: GybAtyeJNlf1a9SEHVFEA8Vv/q7M/QJD73PJKP2WosWqObmGBgrQYyxgfYew61YpwMNwGV7Q/buyb3cy1WWOiU6U8TzvD5ToCSdnjnruKBkAOjK1iE67ycQdDE0RW9AKZC5Y21W1O64mcdv2X/+CMw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: abd46bbd-11d1-4898-5def-08d7a2a8dcbe X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2020 21:44:03.6160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KQlie6kmGReQtxjPFfm6EELy3nHhab/5eWJJPDdpmGoS8Csj4vi9N3cchZ038X1qKjOGZikiN1drJXUZSXWHSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6162 Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: support maximum id in id allocate X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Suanming Mou > Sent: Thursday, January 23, 2020 8:01 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: support maximum id in id alloca= te >=20 > The id allocated is for the register unique id match. Some registers may = not > use the full 32 bits. Add the maximum id to avoid allocate id over the re= gister > restriction. >=20 > Signed-off-by: Suanming Mou > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.c | 12 ++++++++---- > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/mlx5/mlx5_flow.h | 2 +- > 3 files changed, 10 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > ffee39c..2c9f705 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -196,11 +196,14 @@ struct mlx5_dev_spawn_data { > /** > * Allocate ID pool structure. > * > + * @param[in] max_id > + * The maximum id can be allocated from the pool. > + * > * @return > * Pointer to pool object, NULL value otherwise. > */ > struct mlx5_flow_id_pool * > -mlx5_flow_id_pool_alloc(void) > +mlx5_flow_id_pool_alloc(uint32_t max_id) > { > struct mlx5_flow_id_pool *pool; > void *mem; > @@ -223,6 +226,7 @@ struct mlx5_flow_id_pool * > pool->curr =3D pool->free_arr; > pool->last =3D pool->free_arr + MLX5_FLOW_MIN_ID_POOL_SIZE; > pool->base_index =3D 0; > + pool->max_id =3D max_id; > return pool; > error: > rte_free(pool); > @@ -257,7 +261,7 @@ struct mlx5_flow_id_pool * mlx5_flow_id_get(struct > mlx5_flow_id_pool *pool, uint32_t *id) { > if (pool->curr =3D=3D pool->free_arr) { > - if (pool->base_index =3D=3D UINT32_MAX) { > + if (pool->base_index =3D=3D pool->max_id) { > rte_errno =3D ENOMEM; > DRV_LOG(ERR, "no free id"); > return -rte_errno; > @@ -590,7 +594,7 @@ struct mlx5_flow_id_pool * > goto error; > } > } > - sh->flow_id_pool =3D mlx5_flow_id_pool_alloc(); > + sh->flow_id_pool =3D mlx5_flow_id_pool_alloc(UINT32_MAX); > if (!sh->flow_id_pool) { > DRV_LOG(ERR, "can't create flow id pool"); > err =3D ENOMEM; > @@ -2680,7 +2684,7 @@ struct mlx5_flow_id_pool * > err =3D mlx5_alloc_shared_dr(priv); > if (err) > goto error; > - priv->qrss_id_pool =3D mlx5_flow_id_pool_alloc(); > + priv->qrss_id_pool =3D > mlx5_flow_id_pool_alloc(UINT32_MAX); > if (!priv->qrss_id_pool) { > DRV_LOG(ERR, "can't create flow id pool"); > err =3D ENOMEM; > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > 01542e7..ac86c19 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -630,6 +630,7 @@ struct mlx5_flow_id_pool { > /**< The next index that can be used without any free elements. */ > uint32_t *curr; /**< Pointer to the index to pop. */ > uint32_t *last; /**< Pointer to the last element in the empty arrray. > */ > + uint32_t max_id; /**< Maximum id can be allocated from the pool. > */ > }; >=20 > /* > diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h > index 9832542..d9f1761 100644 > --- a/drivers/net/mlx5/mlx5_flow.h > +++ b/drivers/net/mlx5/mlx5_flow.h > @@ -749,7 +749,7 @@ struct mlx5_flow_driver_ops { >=20 > /* mlx5_flow.c */ >=20 > -struct mlx5_flow_id_pool *mlx5_flow_id_pool_alloc(void); > +struct mlx5_flow_id_pool *mlx5_flow_id_pool_alloc(uint32_t max_id); > void mlx5_flow_id_pool_release(struct mlx5_flow_id_pool *pool); uint32_= t > mlx5_flow_id_get(struct mlx5_flow_id_pool *pool, uint32_t *id); uint32_t > mlx5_flow_id_release(struct mlx5_flow_id_pool *pool, > -- > 1.8.3.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh