From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F730A0534; Wed, 12 Feb 2020 13:52:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC7601D9E; Wed, 12 Feb 2020 13:52:15 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30052.outbound.protection.outlook.com [40.107.3.52]) by dpdk.org (Postfix) with ESMTP id 1F8B3137D; Wed, 12 Feb 2020 13:52:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UhdPjyCaevP3c/Xgs3qFA/Y+g7ji/+YAgzmUrqr61nE0rCAMeVrzjqnhM/DhFZJ3XHzfQXruwcnxFFl1m05IDLEDhgTpoJMER1K1oN2MwUQ4ReK5WKu2H4rwgSxjFxWJDy7+F3y+c0UmlC7aXUuHbkRlu3HWYep4mtu3sWEodMi6qhe5r1SYzVep0HENfSEtHHtKY8Mu6ihwPZkaKCFpSuiXdDq31VJES8in3qc7MDD04ONBhuG4VnDYMbTjKAdG+unMxchHS0ISz6lXK5egGXvLNLoUVWSOwgqqha5mjVQSmMs/uOiLm7inqSfeDxwuk5vUh8s8TR6i3FqvKDC3jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HtMcklnek+Z0fO/fw6dHnFyq1lNbs930YIBeDWivKA8=; b=BsLTcxP5W7YzOLBeE6UPGHaWzLeMdOkwTSZv2dDDwT1ug6ZtBSNYUZ1uHOnVncPnXOZ79+ylKUOhuu0/hBUraXGLcU08gNPLJQTFkTt1FOBN5YdHDDEzY0Bt7jhzA+2eppaPu/xS+i+VFZtuP91GHe44wP5yk76pi+iJeAPV5UTnK6/eDiHDUQCPEJJWYpd7vj0AQ7ff2/Zlk5/5/65EVlry2Jjfb9LRT1akZRGz3SQvApK1zdVQOWLdBTUMt3F9b/lQbzjUAOtDvHETV5sCGe3tFOH5VtpB7Ny/X3f3M9Q/IGmkYhjAk24119KsbMBsyovf3mvN58yUVy1Ib+VFRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HtMcklnek+Z0fO/fw6dHnFyq1lNbs930YIBeDWivKA8=; b=odEY1KINxHmY9o7CuWvl9wyOhvUHWq3O557ebtuAXVtL2QQahrNCeI5PdKVUSR6pHGEYK4VaohKIq8ZajZlnT5tBlVqqmANH9mN4abkhVvWACVfHWItunqaaqO+AyQLYR+Gtl3rB8kZvOAL+uU3XyvU8TZVPj7kSWsptoxH0qA4= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB5315.eurprd05.prod.outlook.com (20.178.19.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22; Wed, 12 Feb 2020 12:52:14 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9%7]) with mapi id 15.20.2729.021; Wed, 12 Feb 2020 12:52:14 +0000 From: Raslan Darawsheh To: Wisam Monther , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , Dekel Peled , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path Thread-Index: AQHV4N4A8QoZ/+YT2Eep6cGeP4EeU6gXhG0g Date: Wed, 12 Feb 2020 12:52:13 +0000 Message-ID: References: <1581427206-3434-1-git-send-email-wisamm@mellanox.com> In-Reply-To: <1581427206-3434-1-git-send-email-wisamm@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [82.213.2.186] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a2a57084-79cc-4bf8-1ff7-08d7afba6215 x-ms-traffictypediagnostic: AM0PR05MB5315:|AM0PR05MB5315: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 0311124FA9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(366004)(136003)(346002)(396003)(199004)(189003)(55016002)(2906002)(66946007)(66556008)(66446008)(66476007)(64756008)(450100002)(4326008)(71200400001)(9686003)(6636002)(8936002)(76116006)(8676002)(478600001)(54906003)(110136005)(316002)(52536014)(5660300002)(81156014)(81166006)(86362001)(186003)(6506007)(33656002)(26005)(7696005)(53546011); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5315; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nJH0f5E88P38ngRb1w7klRQKX+4t1mKA23Dzf+891frx/+fpMshKvKi1uz/KvS+99ee6EEiSkp7BOR5+sZGJqofZWKdE+65ihVSS+yyYDl+zMgJD4Ejx66w3ymNxIYi0R1jHUYPdbckeuOvMw/j0A1xZNWu17IT0HR8P24yj85WcFZEhAVZUvcNmFZhmjF8YJc/L22JpCjx/J4iqnrqTOS/NZiu4ooCFr7rpsIUnNkpTet7/XRRycUgRujOo/He8tQZ6MvQxIwuFfhmx3B4/MUf/JjiXZ0vRowTCCOlZ2MUAG/J1Y0m9dywaRhtXmHwlWjQMGCZt35OS+wX3dbKnIRxqMAQXKdpIn+42BHJf7nVwpGAQd4DEwv8F0u1AwGdkvatjfujXzOmtP7+nPDjLXgXMBtfctuA2G2i57GsavfrFgdbQmmZ7dz6zaYfV8/82 x-ms-exchange-antispam-messagedata: Ma5pRSdNYXPv2uTXsC0PNT/2/p1wdOWFvwP5d3DE+UAi0ayT5KV0u9GRPxjKE1Up8jBN5nAuiKEvtvjCSIWHMd+8I4myE5ky5w8Wb8mxgX0XJKbcs0uu5SpChjTiRnfeX539AbeD9Y/JIXDH2I4FTA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2a57084-79cc-4bf8-1ff7-08d7afba6215 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2020 12:52:13.9478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: REsUuTqfu1oBiv88tWtaQg41BSoIxhwYQ1JvO+lng6+MMXECaPR+VcgisloRO8Ms0Paa5ebUcBuCOn0YAExlEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5315 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, =20 > -----Original Message----- > From: Wisam Monther > Sent: Tuesday, February 11, 2020 3:20 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; Dekel Peled > Subject: [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path >=20 > The blocker should take FDB into consideration, since FDB all directions > have transfer ingress in it. >=20 > Fixes: 55060e62e4d2 ("net/mlx5: block push VLAN action on Rx") > Cc: dekelp@mellanox.com Removed Cc: Dekel,=20 Added Cc: stable@dpdk.org >=20 > Signed-off-by: Wisam Jaddo Acked-by: Raslan Darawsheh > --- > drivers/net/mlx5/mlx5_flow_dv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index e71b3b5..c986f25 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1746,7 +1746,7 @@ flow_dv_validate_action_push_vlan(uint64_t > action_flags, > { > const struct rte_flow_action_of_push_vlan *push_vlan =3D action- > >conf; >=20 > - if (attr->ingress) > + if (!attr->transfer && attr->ingress) > return rte_flow_error_set(error, ENOTSUP, >=20 > RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, > NULL, > -- > 2.7.4 Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh