From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82E07A0521; Thu, 23 Jul 2020 13:25:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD2281C02D; Thu, 23 Jul 2020 13:25:11 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80085.outbound.protection.outlook.com [40.107.8.85]) by dpdk.org (Postfix) with ESMTP id 00C461BF94; Thu, 23 Jul 2020 13:25:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lRvJMtOYcU23Qnsz5zDbXUm9sWkl1fDahkHE14p01eXKjl6kNvFizkpbho0ErMF/KoRwaJT73bMjjFQFS9+mWyXutRgQQeoBh0BvCP25C2t4CQ3shv0jOeyE8QjWR8GaPcw1Fm3pUAsZ7gqeQO70AZ28KxPW2AEZb9T5pGAUuxQjUB3u6Tr8Dq96kdc+eP4ArKt7yqgHCJECJfKMaqbblIJ7BLNdLseRQbhuL+F9znfWbW2ZDqTW66Z3Rogv8T24RgKapRM3O+oiMGaU4civRFYs6kKwUYDY/4MVHtgtug8XsmdHNmwT8EzfvswZJdQnRmGax46Y0mCE2i6xLklfDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCTebCCX2fq9t8EDE7PX6OppgNEwM6dtnbGoeJluXps=; b=X+SLHUKdwECJRU8Nz0i2i9IlNZUpb755qH8FTPGoFqbj2gDFv0P2Hq0u9P40GqHHyC/YXlij3HXo8XkqidKIyoP9LWrvgnwXm7mm1RpCIXpuNvvOEN7O6dZy9C3kqbjZz1JwPHNaMAeIpIl1vgAlJSEOq7PlCaQYpdJumFA+OZrpzKkJWa7VMoM+rT4IaDhAD7ewZlURKJP/aRagkMUxw2oXmqmCive9kZtt5m03dJODShf/O4fDmWjS+LOe7XbJEZCFtD3WbXr1BIk/wGnRrmkXAc2qizOm1vYe5hrS1nYzmjpxU80V+MkJ1Ff0B1p5XwdK25twe10/3jRKWmsjYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCTebCCX2fq9t8EDE7PX6OppgNEwM6dtnbGoeJluXps=; b=qxehg+uckNeGZu4HS0ZmpwDIKlbD07DHcvR8qKC/x92W7iTfsa42WMYhd02Oa2qowaBWXB+mCl1K7DYfKysepfqhIbn3kt/b1eTqbBekWmpEnQEfFU3FIWIlBfNsNvMME8cInw7QQ+oJMcEOR1OErkWgjcY+5Hp4c0BgRFvemwU= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5795.eurprd05.prod.outlook.com (2603:10a6:208:111::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.25; Thu, 23 Jul 2020 11:25:09 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Thu, 23 Jul 2020 11:25:09 +0000 From: Raslan Darawsheh To: Raslan Darawsheh , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , "stable@dpdk.org" , Slava Ovsiienko Thread-Topic: [dpdk-dev] [PATCH v2] net/mlx5: fix VF MAC address set over Bluefield Thread-Index: AQHWYOPshPsFh3UFtE6TDsXq0a7iKA== Date: Thu, 23 Jul 2020 11:25:08 +0000 Message-ID: References: <20200722090755.26103-1-rasland@mellanox.com> <20200723110613.8363-1-rasland@mellanox.com> In-Reply-To: <20200723110613.8363-1-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 166eeac7-9224-4705-686a-08d82efb0ea2 x-ms-traffictypediagnostic: AM0PR05MB5795: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nMxtolaRG2wv6FSjQfwtqdzn9FZytUTeizahsxkmBtMosqVQAYBbuffOmfPqnly78J3UcRpBszh/EPdC9PoGdzs3LvTPPnWtHCmUi4jksuiik/2Mu0Ngudp1+LtZHZ3r2/PoWURVtEY8lQ6O1kaGF2qo8ufu6gZgXbvxS9FRayX/NrltpDp4k0AKERZVMkw7PnpH9ehC5ZNF/orOtfXyzFnYHKdNb2C7Fw0ak0oXb4czzHS5F3wan+O8yt5NT7sMSOo0z6IXOpq0SOz6mqu/QQqmynGVvHSqr6arMWEwWb3T82JsuggwD2r3yxXT2t5KWYu6kXlUIHMAAXAZxSnE5Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(346002)(396003)(366004)(376002)(76116006)(33656002)(66946007)(66446008)(64756008)(107886003)(66476007)(66556008)(26005)(186003)(86362001)(83380400001)(6506007)(53546011)(2906002)(478600001)(7696005)(9686003)(4326008)(8936002)(55016002)(5660300002)(316002)(54906003)(110136005)(71200400001)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: SOMP9LQ/30x3ZGBTiNp0d/N3iBp5RwOEWfenYUa0kim9Lqv4x8gVGSkmYCGjP/zmz95gHky+ybO8VSaqUEc6nYTFnnjIE4lDHXZJaFsN20MZOD83ppritp/AXIlO0vLuphwP//vlHdm0KaFsdXC0841KgKzS+riQ/wZKRKajtIKSLuQZjMvnGIiRotUtKpRib2xVchVgLFISSc1qWjqP4xU3kuhdDm5c/k7o0H/bjLwSOcgA/aeU9iMQ71yUs6QC8Aqv8lWUMiUesnieA7S54iK8WU0oXZAItIoHtwzWl87xGPZm7ycEb29WgNQxHAEGjkxYl+HxasE2NF1CyYhg7Xvbjf7ccb4+xOBrFJOV1gLbBY6gcg54MQCZ6PaRFidX5EsLD557uO/i73UnyzkKzbAKW43iqYIA0d5dKU4EFBFwI4QrUiQnwlVq12IhIErzggAY8CqxF8W4IC/abW8r5eAYLUJOQXWSFSuZg8JgaMJPXeMTdo9id7w/rPv5HEO4 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 166eeac7-9224-4705-686a-08d82efb0ea2 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2020 11:25:08.9451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: K3aKFFvLsUkHGEwehCD9cxWOpf11olTywGMj0hHeeCE0myB1Kork64nG4rIYs1rYgRoiaPkj/xxnE6VofXEIEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5795 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix VF MAC address set over Bluefield X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Raslan Darawsheh > Sent: Thursday, July 23, 2020 2:06 PM > To: dev@dpdk.org > Cc: ferruh.yigit@intel.com; stable@dpdk.org; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix VF MAC address set over > Bluefield >=20 > When trying to set MAC address of an ethethet device and if it was > a representor, PMD sets the MAC over the corresponding VF instead. >=20 > For the case of HPF (Host PF representor on BluueField), PMD shouldn't > attempt to set it, since it doesn't have any corresponding VF and fails. >=20 > This will fix the issue by setting the MAC on the dev directly. >=20 > Fixes: 0d1d73170820 ("net/mlx5: set VF MAC address from host") > Cc: stable@dpdk.org >=20 > Signed-off-by: Raslan Darawsheh > Acked-by: Viacheslav Ovsiienko > --- > v2: fix the use of representor bit to use the representor id instead > --- > drivers/net/mlx5/mlx5_mac.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c > index 2d808d629..88c52b29f 100644 > --- a/drivers/net/mlx5/mlx5_mac.c > +++ b/drivers/net/mlx5/mlx5_mac.c > @@ -157,8 +157,11 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct > rte_ether_addr *mac_addr) > uint16_t port_id; > struct mlx5_priv *priv =3D dev->data->dev_private; >=20 > - /* Configuring the VF instead of its representor. */ > - if (priv->representor) { > + /* > + * Configuring the VF instead of its representor, > + * need to skip the special case of HPF on Bluefield. > + */ > + if (priv->representor && priv->representor_id >=3D 0) { > DRV_LOG(DEBUG, "VF represented by port %u setting > primary MAC address", > dev->data->port_id); > RTE_ETH_FOREACH_DEV_SIBLING(port_id, dev->data- > >port_id) { > -- > 2.27.0 Removed V1 from next-net-mlx,=20 And V2 is applied with the fix. Kindest regards Raslan Darawsheh