DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix incorrect set VLAN ID action offset
@ 2020-02-19 14:15 Suanming Mou
  2020-02-20  8:57 ` Matan Azrad
  2020-02-20 11:25 ` Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Suanming Mou @ 2020-02-19 14:15 UTC (permalink / raw)
  To: viacheslavo, matan, dekelp; +Cc: dev, rasland, stable

Currently, the set VLAN ID header modify action has already got the
action pointer with offset from the header modify action array, but
the configuration saves the detail to the memory of action with the
offset again. It causes double offset to set the VLAN ID action to
the wrong place in the header modify array.

Remove the offset when get the action pointer to fix that issue.

Fixes: 5f163d520cff ("net/mlx5: support modify VLAN ID on existing VLAN header")
Cc: stable@dpdk.org

Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
Acked-by: Dekel Peled <dekelp@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 359a037..5950274 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -637,7 +637,7 @@ struct field_modify_info modify_tcp[] = {
 	const struct rte_flow_action_of_set_vlan_vid *conf =
 		(const struct rte_flow_action_of_set_vlan_vid *)(action->conf);
 	int i = resource->actions_num;
-	struct mlx5_modification_cmd *actions = &resource->actions[i];
+	struct mlx5_modification_cmd *actions = resource->actions;
 	struct field_modify_info *field = modify_vlan_out_first_vid;
 
 	if (i >= MLX5_MAX_MODIFY_NUM)
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect set VLAN ID action offset
  2020-02-19 14:15 [dpdk-dev] [PATCH] net/mlx5: fix incorrect set VLAN ID action offset Suanming Mou
@ 2020-02-20  8:57 ` Matan Azrad
  2020-02-20 11:25 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Matan Azrad @ 2020-02-20  8:57 UTC (permalink / raw)
  To: Suanming Mou, Slava Ovsiienko, Dekel Peled; +Cc: dev, Raslan Darawsheh, stable



From: Suanming Mou
> Currently, the set VLAN ID header modify action has already got the action
> pointer with offset from the header modify action array, but the
> configuration saves the detail to the memory of action with the offset again.
> It causes double offset to set the VLAN ID action to the wrong place in the
> header modify array.
> 
> Remove the offset when get the action pointer to fix that issue.
> 
> Fixes: 5f163d520cff ("net/mlx5: support modify VLAN ID on existing VLAN
> header")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> Acked-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect set VLAN ID action offset
  2020-02-19 14:15 [dpdk-dev] [PATCH] net/mlx5: fix incorrect set VLAN ID action offset Suanming Mou
  2020-02-20  8:57 ` Matan Azrad
@ 2020-02-20 11:25 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2020-02-20 11:25 UTC (permalink / raw)
  To: Suanming Mou, Slava Ovsiienko, Matan Azrad, Dekel Peled; +Cc: dev, stable

Hi,

> -----Original Message-----
> From: Suanming Mou <suanmingm@mellanox.com>
> Sent: Wednesday, February 19, 2020 4:15 PM
> To: Slava Ovsiienko <viacheslavo@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; Dekel Peled <dekelp@mellanox.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix incorrect set VLAN ID action offset
> 
> Currently, the set VLAN ID header modify action has already got the
> action pointer with offset from the header modify action array, but
> the configuration saves the detail to the memory of action with the
> offset again. It causes double offset to set the VLAN ID action to
> the wrong place in the header modify array.
> 
> Remove the offset when get the action pointer to fix that issue.
> 
> Fixes: 5f163d520cff ("net/mlx5: support modify VLAN ID on existing VLAN
> header")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> Acked-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index 359a037..5950274 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -637,7 +637,7 @@ struct field_modify_info modify_tcp[] = {
>  	const struct rte_flow_action_of_set_vlan_vid *conf =
>  		(const struct rte_flow_action_of_set_vlan_vid *)(action-
> >conf);
>  	int i = resource->actions_num;
> -	struct mlx5_modification_cmd *actions = &resource->actions[i];
> +	struct mlx5_modification_cmd *actions = resource->actions;
>  	struct field_modify_info *field = modify_vlan_out_first_vid;
> 
>  	if (i >= MLX5_MAX_MODIFY_NUM)
> --
> 1.8.3.1


Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-20 11:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 14:15 [dpdk-dev] [PATCH] net/mlx5: fix incorrect set VLAN ID action offset Suanming Mou
2020-02-20  8:57 ` Matan Azrad
2020-02-20 11:25 ` Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).