From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA577A04A2; Tue, 12 May 2020 13:15:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E82B1BFB9; Tue, 12 May 2020 13:15:06 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80075.outbound.protection.outlook.com [40.107.8.75]) by dpdk.org (Postfix) with ESMTP id 7802B1BFAB for ; Tue, 12 May 2020 13:15:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AOgIsP4F3boNXconz5wpI/Lm5EWF3beUY6P67ONntTS6yLiz8LhQ+lX3VR4PgYs1VvMNbu3QFEMAP2cECctf4RqYugqZSWRDYIgfWj8xjjPZTuOxkgCFOilstViBaZLOef70BJn2t7v77XccQmWS2AEpPgGUWI35c48GD4Yc5NaGL7FoJcmdNCDlBChqCXV370HbVuTZuMgjZeTbtiVvfNz9SJzhGYpBLDtCcU8xFtHeBi4nXK4bz5lKb22FcAatgKiQMctD1/Sfb5c+4mhdaKtVLMd1/AaKawQTbr9vMUGCo0l0S6xRA6VGA+0AEHsWNjZN8ssNy/taqWXKA7gAGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IwDMYWH6ONSwK61+f8dtGOfkGEpR+Qof4PNyupPbHmU=; b=WrjIx+wcpoPyvMyHzCpONvmOVLV0wVHFHHhcUB/m1lFiSihX0WOA5/AeGEPi/wnt7uEbVuq0ekvfD1Z0eJdrLseDadFUXlvZzQSgsth5gyPJptxMOpWN+MImyAc1/iJTKdWUFtIeGXvJMlt43l/4Uwjl5MJRmUrMGlguloi8tta4ENkhQRgDMZdIjc4w8pZKOuMt+dEyHWd45a+lxOHjuDZZ5BZt7+QwVeZqcTfC2nCptVHYE3PwS5by1BVfheK+1o4rssBBrG0fKEqs3fAd4ztsU+DNnnd7trGf2Bd4PBlNZ6tsRwEPyiU7dTtWIgw85ZQYz540FxagmrHa7NoP4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IwDMYWH6ONSwK61+f8dtGOfkGEpR+Qof4PNyupPbHmU=; b=t19VSmRHAl/IPVVpcIZyfiXqw+7ytrlELJOdgLZYaFPhUGWwarUXS9nFYQxqWCkd7VCGm0c3H9GOnvu9upygoOM9q161BWzjcKF3gEOpTH0qEoulduddV25kQnoVaBsvTMKXu+vu/B/g0PqbKEfhPoVnePnOiXAeoFLe7dHw4Og= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5697.eurprd05.prod.outlook.com (2603:10a6:208:11c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Tue, 12 May 2020 11:15:03 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%5]) with mapi id 15.20.2979.033; Tue, 12 May 2020 11:15:03 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: prefer DevX API to create Rx objects Thread-Index: AQHWJrzPNLMfnaC4oUW3em1GDYSSuKikT52Q Date: Tue, 12 May 2020 11:15:03 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.229.217] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: dc9f467f-79c1-417c-d575-08d7f665b806 x-ms-traffictypediagnostic: AM0PR05MB5697:|AM0PR05MB5697: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9kAvgGFLS0ycpouXw1pNnPjq0N8qa6Occ4NZmpu7c+bCVQ4cNzaenSSG5XwbtwNw5JTUkpukB6ehPcvRO7r1pss7HnYdXey/R/TddF/VsyAgSrs1PDSvI4XSI76vXYMO8/GI1nNln6a4eUsvy82xY5ua4+ds2OwCtNaJC0nZNeb5cMGVNtUwZxoId0BuRvjSDWrUDLM0WMPvB9t21bDOCLvVjqS8nHMSowdlz8sLQySutIa3DwlhteB+wI79AB0y1kq65XKDM8kl0O3qcxb8ZaMpkp6OwSCT0oQR1GX+nelJwz7sAW7o/lHc8sF32keNniRXPjnXsElMHmLCnsXs+nxr+G3qzy9eGEahfMGQaQ5xcEMvgB4WUbcqnPkR9tmdVrYKlAt2hRwLjpD71ibjmr2d6QzxeE2TM03wqX2d4X9RshyXEA3f2VJ9QDLFYrFmzOi6vHrc4Vx5QabeRXMae0k9xOZiqjSYaOjOrBhgab0F7dQbLdGKylNmP4Tia7Wurzz1IXS6sEaepdoKHnPl1Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(366004)(396003)(376002)(136003)(39860400002)(33430700001)(66556008)(110136005)(53546011)(71200400001)(7696005)(316002)(478600001)(26005)(2906002)(9686003)(6506007)(76116006)(8936002)(66946007)(55016002)(4326008)(6636002)(66446008)(5660300002)(33440700001)(186003)(86362001)(66476007)(33656002)(8676002)(64756008)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: LCxzyLFPyEZZKsPIj6fWXzT3vUPhK6UsHw4t+TSd0WWgDHLJghw2gzOEkcjkYbv98nb5X6oqHArifoKIEqj4W2nBItEURcw71bUVtWY9gG9n7vD+8gAI/Vpr0rVhXVzXXVdZ+DUycuGTar4AsPoKUjY+7UP2mZLynPXGLMp1Vp+jUSK7x/XXpBzxHgn82ZHvU6qgwK+ngA5QHMT1LpcVJ3wEp00uUUP7KtTTTOqNQiEamp8Alpm4fvlPwx7n6C6exjv6eW1/JIn5l8ggu+d4wPEuT6Wuua+wrq69ylEweY4XMq1T5DHsGwyK5jMbsHRYjvPZAmHBPgDsK2YrGWe6PviO1idZfxQqN8zeBnD//lgy5xn4MnkJNEBKsEAmy1NivfIffaTwIm456lpp/5D7wm+rtD1UB5Z1dbdXflwnK+J0SruUKasy+pjnit4xls3vsoxnfVueHWCRQ5BUR+UBZJOZ06Z0vqoMl+FOCJtdCEhLVoZMVRphN8ZPFEjwvgMr Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc9f467f-79c1-417c-d575-08d7f665b806 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 11:15:03.5023 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IZXY8SInm31xxBK+fgZbs1RKaqhQgmIHfYoVvmw6QQ3IUKg3ES7kw6krT6dBFrT/i6HAqUMNQwMys/M+0SmqvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5697 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: prefer DevX API to create Rx objects X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Dekel Peled > Sent: Sunday, May 10, 2020 2:19 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: prefer DevX API to create Rx objects >=20 > Currently, DevX API is used to create Rx objects (RQ, RQT, TIR) only > if LRO or hairpin features are enabled on this RQ. >=20 > This patch uses DevX API by default, if DevX is supported and can be > used. Otherwise, Verbs API is used. >=20 > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_trigger.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_trigger.c > b/drivers/net/mlx5/mlx5_trigger.c > index feb9154..8d53648 100644 > --- a/drivers/net/mlx5/mlx5_trigger.c > +++ b/drivers/net/mlx5/mlx5_trigger.c > @@ -107,17 +107,11 @@ > struct mlx5_priv *priv =3D dev->data->dev_private; > unsigned int i; > int ret =3D 0; > - enum mlx5_rxq_obj_type obj_type =3D MLX5_RXQ_OBJ_TYPE_IBV; > - struct mlx5_rxq_data *rxq =3D NULL; > + enum mlx5_rxq_obj_type obj_type =3D > + priv->config.dv_flow_en && priv->config.devx && > + priv->config.dest_tir ? > + MLX5_RXQ_OBJ_TYPE_DEVX_RQ : > MLX5_RXQ_OBJ_TYPE_IBV; >=20 > - for (i =3D 0; i < priv->rxqs_n; ++i) { > - rxq =3D (*priv->rxqs)[i]; > - > - if (rxq && rxq->lro) { > - obj_type =3D MLX5_RXQ_OBJ_TYPE_DEVX_RQ; > - break; > - } > - } > /* Allocate/reuse/resize mempool for Multi-Packet RQ. */ > if (mlx5_mprq_alloc_mp(dev)) { > /* Should not release Rx queues but return immediately. */ > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh