From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD248A0528; Sat, 18 Jul 2020 15:34:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA4411BFB6; Sat, 18 Jul 2020 15:34:39 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2081.outbound.protection.outlook.com [40.107.20.81]) by dpdk.org (Postfix) with ESMTP id EB50F1BED7 for ; Sat, 18 Jul 2020 15:34:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J8SXJuxOId/0NFws/reo65fWWePdSjmmOuq9VVXZmcCyTlLFngNBtmqlE2xooctlfkPzuiE/27M+Ea0ay3XBgrNWNLF5FioTJLbf4YJlW7e6N2FJcO+fOTw7hL8/uoYIdFHfxfB/STpM8amRNcJ02t58umHGvJwsLqiVJwrT6WeY3M6pA6OWsNnbRxAJPpRS22PKBXbye6PzYAFA8OJzTBFV3Om1I9P+6MJRFgZBHGJAJslR2vWyKCVMHqq1+tkQho862YAd74gzABvAUVHZnQ1VU7Wi1K7sPJXWiBRIH7f0bV90exR1Ibz8aXZ8ZyspfXcj8cDC87oyq1PTjQPorQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B8X9iTMsziRmrfIl3gnmaoVmPXnQU2oGaWTxbkv3T5I=; b=HQhii5YBaa+YXGdNpIofXfUJuT+/6pq0Z2QbgHx56DBXHtQY33JIhzSzn5KFqS4/6lo9kdNFnT30UyKUhCybC8m3Kjv44ewHcGSyBiP3AAgSbzuB/GkbfA3XDeZfwf9TyWONtuFKL1Yct6igB35M4ptqJGbhlp1rz0MFswrXYxXdcdcGs3SO5k5hxRtYLqQ9J/EZyS+NyaonDZIV10QpksnHxNWvhrrEx9t/YmdVbruOJYuUHljgoqGILokcgNl+LiNGeWmoVgx4+PniqyCj0KhRcRSl1Pmi+lkUOamVo8eZyniki4mdpePOEXwauwiToX3Hadd0wQ5zptmi8jKVWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B8X9iTMsziRmrfIl3gnmaoVmPXnQU2oGaWTxbkv3T5I=; b=kdAM7tKMUMI8fex9nCegisbLhtWM/hxxsTi2Xbw91DEd5ZtjyVLqD+qkDgCD+AXGFksKrLkhy8BND9TnSINNzSKI32BBywKNv38D3gNrFDoeVJWc5eg+LXIojqhidtGvWcea4oiBHqZxVgr1DOsQztbq+E9ozYHsYdWNumFZJUc= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM4PR0501MB2162.eurprd05.prod.outlook.com (2603:10a6:200:46::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Sat, 18 Jul 2020 13:34:33 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.023; Sat, 18 Jul 2020 13:34:33 +0000 From: Raslan Darawsheh To: Thomas Monjalon , "dev@dpdk.org" CC: Ophir Munk , Matan Azrad , Shahaf Shuler , Slava Ovsiienko Thread-Topic: [PATCH] common/mlx5: fix link with ibverbs glue dlopen option Thread-Index: AQHWWSuPUKx3tcIgT06lAeRGVtx5RqkNXevg Date: Sat, 18 Jul 2020 13:34:32 +0000 Message-ID: References: <20200713153710.807451-1-thomas@monjalon.net> In-Reply-To: <20200713153710.807451-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.228.169] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0ee9300c-3b35-4526-2365-08d82b1f4e8f x-ms-traffictypediagnostic: AM4PR0501MB2162: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RgHXj/Mt5MgCiTz4GARHOVGwdGfj0n3uzWDOETjx66TiT7ijm/CznFKHqKeIxhslR9vaCQBxbv9rcvna2RFNBYrLD/OnjUNLfRL1a4xdBF/jMxt4RgH+oGempBPKaanryXPkvaaltVIHK2ju64HZ7pQfwIsINlIaJ3GYcq4LPD3Iw5/w3EGl2nbQBcFZE6CxYBAhnUD3NLIPvB+1pIjyEKFyK3pYZo6C8dE0CjQWjsklZqzSuc/RxsfE8lgicDw1/syuekQLt/qHVSnKJ2oV/TzVetgQDiPjO+QgbmJnqbn21RzllBm1SJKH0xaQKywV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(136003)(376002)(366004)(39850400004)(396003)(7696005)(83380400001)(2906002)(107886003)(71200400001)(4326008)(186003)(55016002)(316002)(478600001)(8676002)(5660300002)(66476007)(66946007)(33656002)(66556008)(52536014)(54906003)(66446008)(64756008)(110136005)(76116006)(6506007)(26005)(53546011)(86362001)(8936002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: PpGlzqK/sCqU0bTOra1uDchr10Hbz/QfBfB4FynLkSC7Z6yyKuqQNrEQ5Y1qtXS2FMFlyoRLstP+HiavR2ZDoZ4jONtljysoVDnltgly0+nSCXQcFHgybbWppCMjdm4kT/pMsZ7IFWI8mhJyuUVs7J7t8IceZlG6FHLLbbT34nBkKZWxqUPtlRG3WTCovKTZcYvng61DhtGmA8e+D4nWK5B86QNVP8jSBe2WNTnsRrPcJgBuHaL0Q5CEe0ws7Yu2NFVLSbkIOEz+4Tb4qz5I17+Ej7Cnpu0fP7nulJHIVLVPv+cRDLNvVuVbZGYpKWhYJHrbixclTa/rGwpdpGIjW/jre3Hk1QtJF51v72HX941N0Qj9GsZZEl0eVHTbCqC+UXIwU7L+CMWdNaCcfkUY6NUthINUZamRVmpT0kh+aYcDlZvROSvpxBFB8QZsA4Ohi/LAfpke1YbCH+msZB05Xsqds1JEkUXrlvCz+w/x+Ct+WNDlN/4tStpIdYWXh7zO Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ee9300c-3b35-4526-2365-08d82b1f4e8f X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2020 13:34:32.8447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e1lN6Q6A6MdsCmNCpDpjtkVNdty441JirID2OT9H8aHCObiQUmvg5KGLX7dQ1MIVe+sctszQO0oJRxISiI6t5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2162 Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix link with ibverbs glue dlopen option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Him > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, July 13, 2020 6:37 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Ophir Munk > ; Matan Azrad ; Shahaf > Shuler ; Slava Ovsiienko > > Subject: [PATCH] common/mlx5: fix link with ibverbs glue dlopen option >=20 > In case the ibverbs glue is a separate library to dlopen, > the PMD library must allocate a glue structure to be filled by dlopen. >=20 > The glue management was in mlx5_common.c and moved to > mlx5_common_os.c, > but the variable allocation was not removed from the original file. > The consequence was a link failure, if ibverbs dlopen option is enabled, > because of the redefinition of the variable (with GCC 10): > multiple definition of 'mlx5_glue' >=20 > The original definition is removed to keep only the one moved > in the Linux sub-directory. >=20 > Fixes: 79aa430721b1 ("common/mlx5: split common file under Linux > directory") > Cc: ophirmu@mellanox.com >=20 > Signed-off-by: Thomas Monjalon > --- > drivers/common/mlx5/mlx5_common.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_common.c > b/drivers/common/mlx5/mlx5_common.c > index 693e2c68c8..341239d164 100644 > --- a/drivers/common/mlx5/mlx5_common.c > +++ b/drivers/common/mlx5/mlx5_common.c > @@ -16,10 +16,6 @@ >=20 > int mlx5_common_logtype; >=20 > -#ifdef MLX5_GLUE > -const struct mlx5_glue *mlx5_glue; > -#endif > - > uint8_t haswell_broadwell_cpu; >=20 > static int > -- > 2.27.0 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh