From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DBC0A0526; Wed, 22 Jul 2020 11:11:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85DB71BFCA; Wed, 22 Jul 2020 11:11:41 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130089.outbound.protection.outlook.com [40.107.13.89]) by dpdk.org (Postfix) with ESMTP id D8F26199BC for ; Wed, 22 Jul 2020 11:11:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bo/tLyKgRHuHVuIhEb6FA1OiSD40ZfuUOjnCCq/2G1UXBk4jor1/vZsdEI2OBLOYRSTO4prXKq/9N0YWdo8jnccXzyhBTbj6yQsiiIsG6O2fdvWSOOlKakecVhBv5lHE+u0MSxx6S2cs5SfjlytaRN8g//0/tkj9/p8IBWYuvrL5kwq3Cr90rnIbX6BkdVXac0bos3rhM+vfmP+M66X4UbX8ebasxglvo7+SmCn2qTepqcIILkqeJY8UTdiqpcdyGr+ovH7mtNzqxnT1MUhLXm6Qe4Nv7x+zfosUj9RKoR+iy9RvBdqHl8RnWQ0usbsTvzGtlWiWfNqF6V82Zbq0gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P2nkOSTSMXLJPONIAemBbBha/e6IBP1g2vn2YagA1IU=; b=W23jh7ztov7rAo+qeS2krJCg/PJzUGgZ2Zo0SHYVAnPN7B+KDjrMzkyUlpeqvk7Z4owWsZGZzYbqRo6RjdnTUuGKkHHGAHdLED+RwOACqF1LEirjZTNEH6AA0G9yzwT5GSfTob9DMwuii9wnMHFoEudMVhKc9qDBnIDZKCLpCFY/6c1ARSCfeE7ek3jjsKDjeTlfndsAvDpIQSbd3o6+vy9UySq4BLWQE/Azh00Bog17713TzmWXSQ+1ysyJ58g1vc6qc/mpqdvE9z5gMijX06mQHIe/CLL6dPrz+kDj2nN7u29UWa5dCPAIWelTh9S7sb/XE/WbZKNJ/vWTVT8uig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P2nkOSTSMXLJPONIAemBbBha/e6IBP1g2vn2YagA1IU=; b=fzH7qsl5fFK6Si6NHTqf86mD5MSPb3Ng8XM5WfbdXrPv9jo3CbSfQYK+Szm8YjPKwZcHa6Jv7UwfEv0YXnAeJue8yqnUgmMjECjMTKOcBt8TFECJG2xzhuzUBNZE+3I5nEIySyJUH40FPNmiuPOvmEVRTfjCPVwlfp+CNpofkw8= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5795.eurprd05.prod.outlook.com (2603:10a6:208:111::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.25; Wed, 22 Jul 2020 09:11:38 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020 09:11:38 +0000 From: Raslan Darawsheh To: Ophir Munk , "dev@dpdk.org" CC: Matan Azrad Thread-Topic: [PATCH v3] net/mlx5: return EAGAIN on premature disable interrupt calls Thread-Index: AQHWX2z8Ryt9EKMfJkuyBYWzs4tq8akTUPSw Date: Wed, 22 Jul 2020 09:11:38 +0000 Message-ID: References: <20200721142449.24767-2-ophirmu@mellanox.com> <20200721144107.25550-1-ophirmu@mellanox.com> <20200721144107.25550-2-ophirmu@mellanox.com> In-Reply-To: <20200721144107.25550-2-ophirmu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1bc60510-3767-4c3f-405c-08d82e1f3da8 x-ms-traffictypediagnostic: AM0PR05MB5795: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1284; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IvzUJrwYrVOhtFLkZdDcVEJCW9a7EvNQDvagnfGFbHTThBVzap7n1jglLEzW/BNq+JcUd6CQEyDmh0RUDvdrbo2c5dHXPdPf6b0SBVzTkWE3+FJIzfyCtOIDhDJW2jG2Z+Eri9RMwKmTICFvrS/d3+0BWHN6HviuC9Ys8pHdXdQ4sOdu5N9AeanFNxyCpXbfK7iNYMHac7zvCSwJM4CbZGo4RgOM1I4B0xt0vPoAjvg521Wh3GCcLND+TbnkYHutvLIxnm1TvKmjHTl2Po9PW/K6JgrsYryMjJ0aj2SABJkuHtisFwSnpog2M+QD2CQTATcTsU4+TXVleeckcLloxg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(396003)(376002)(346002)(366004)(4326008)(107886003)(83380400001)(478600001)(316002)(7696005)(9686003)(6506007)(53546011)(110136005)(33656002)(8936002)(186003)(5660300002)(8676002)(26005)(52536014)(55016002)(86362001)(2906002)(66446008)(66556008)(66946007)(66476007)(76116006)(71200400001)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: JalpELXBLq+UGSgq4DDAkZLQbosjT+117eEbdNEDSGU8jMVDobDw11LayAdg4SNkS2E3UdvBHRjoAL0KFGEY4lTaaAkDchr45sS7uvb1HCCJ4yRdjMd2O1v+FH2qFSluXjEpJvwzrpQ48ln5s4SS1oNQ9V/q9R9lM0HitMtoameiDPdSyUkQG3eJQb2P3sEReliIHAezS4pGShYSplPzTQkLD2agwR7QTxob7WAZvhvHok0KfzMr5RSM7y9Gtpn9NHXqskGrPBgdBwQ8LUUvgruoXp2cBDksYyIsbI7WtGaGOMIGzpPsuEkcJOO/KtWEylhHKJ3mWDph5tJ9gOnKUMYhhKn6d8/3N4ZLAX2dyR7fxNVemQjUBv9w+vQ5KiHatlZGVXPDYtWbUFEoQGepWFtQ4MRUpAewqoenxA+Pbe3d/IMBnA2FiKtV+x2hWttMKuTRiqEaNKoa+TM2wfZSRRUP74ivsnpy6d5WIFoF3NpYnLZB4u/bHDKNCMnqQNJV Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc60510-3767-4c3f-405c-08d82e1f3da8 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 09:11:38.5528 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dUFrXH48oX5ChPPXAv90NOVdQ7oWO+GuCIrpYyyV/Z8VIpupKD6rUS8xi++i+vPfpQpQeqObbEBQL4kG01/kdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5795 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: return EAGAIN on premature disable interrupt calls X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Ophir Munk > Sent: Tuesday, July 21, 2020 5:41 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Ophir Munk > ; Matan Azrad > Subject: [PATCH v3] net/mlx5: return EAGAIN on premature disable interrup= t > calls >=20 > RXQ interrupts under Linux are based on the epoll mechanism. An > expected order of operations is as follows: > 1. Call rte_eth_dev_rx_intr_enable(), to arm the CQ for receiving events > on data input. > 2. Block on rte_epoll_wait() with an array of file descriptors > representing the CQ events. Upon data arrival the kernel will signal an > input event on the corresponding CQ fd. > 3. Call rte_eth_dev_rx_intr_disable() after the event was received and > continue in polling mode. The mlx5 implementation of > rte_eth_dev_rx_intr_disable() is to get the CQ event and ack it. >=20 > In practice applications may wake up from rte_epoll_wait() due to > timeout with no event to ack but still call > rte_eth_dev_rx_intr_disable() unconditionally. In such cases the call > should return EAGAIN (since the file descriptors are non-blocked), as > opposed to EINVAL which indicates a real failure. In case of EAGAIN the > PMD should not warn on "Unable to disable interrupt on Rx queue". >=20 > This commit fixes a earlier commit where the returned value 0 from > function devx_get_event() - was considered an error. >=20 > Fixes: 19e429e5c7c2 ("net/mlx5: implement CQ for RxQ using DevX API") >=20 > Signed-off-by: Ophir Munk > Acked-by: Viacheslav Ovsiienko > Acked-by: Raslan Darawsheh > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh