From: Raslan Darawsheh <rasland@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Li Feng <fengli@smartx.com>
Subject: Re: [dpdk-dev] [PATCH] mem: fix build
Date: Sun, 26 Apr 2020 11:00:59 +0000 [thread overview]
Message-ID: <AM0PR05MB6707CC9F53AE82D668662048C2AE0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200426104725.2809101-1-thomas@monjalon.net>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Sunday, April 26, 2020 1:47 PM
> To: dev@dpdk.org
> Cc: david.marchand@redhat.com; Anatoly Burakov
> <anatoly.burakov@intel.com>; Li Feng <fengli@smartx.com>
> Subject: [dpdk-dev] [PATCH] mem: fix build
>
> Some compilers (on RHEL7 and CentOS7) were getting this error:
> error: "RTE_EXEC_ENV_FREEBSD" is not defined [-Werror=undef]
>
> Existence of a macro must be checked with "#ifdef" or "#if defined".
>
> Fixes: d72e4042c5eb ("mem: exclude unused memory from core dump")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Tested-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
> lib/librte_eal/common/eal_common_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/eal_common_memory.c
> b/lib/librte_eal/common/eal_common_memory.c
> index 9a797a4fa3..4c897a13f1 100644
> --- a/lib/librte_eal/common/eal_common_memory.c
> +++ b/lib/librte_eal/common/eal_common_memory.c
> @@ -42,7 +42,7 @@ static uint64_t system_page_sz;
>
> #ifdef RTE_EXEC_ENV_LINUX
> #define RTE_DONTDUMP MADV_DONTDUMP
> -#elif RTE_EXEC_ENV_FREEBSD
> +#elif defined RTE_EXEC_ENV_FREEBSD
> #define RTE_DONTDUMP MADV_NOCORE
> #else
> #error "madvise doesn't support this OS"
> --
> 2.26.0
Kindest regards
Raslan Darawsheh
next prev parent reply other threads:[~2020-04-26 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 10:47 Thomas Monjalon
2020-04-26 11:00 ` Raslan Darawsheh [this message]
2020-04-26 11:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB6707CC9F53AE82D668662048C2AE0@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengli@smartx.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).