From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAF63A0350; Mon, 29 Jun 2020 10:45:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FB641BE94; Mon, 29 Jun 2020 10:44:51 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2056.outbound.protection.outlook.com [40.107.22.56]) by dpdk.org (Postfix) with ESMTP id 3A3371B9BF for ; Mon, 29 Jun 2020 10:44:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BIw187bSZYK45R+0Vp+GBKxyQzuIXXknhtypkaxBUnQprT3P8hyfvfIgwimyL62UQKtYb831AHc/pQoSUBHRanSKLwHofmApG5sDCqgMyf5wBnN0G9AwZ0rx3JSguQrx/BFU2HrlAk+GoMynVlDFtgBN5/EZjqLsWlCOgLfMCKQTywPIdPRkBw33Yb23xAeI+2PmdbVyZkVvLO4Rda/m/27sB7o5OzvvOXEFLENjYHd4jjqrKRRyrdZ2eSLeblbAzyzLm/hpJcdvfyvnKelQYSvxgrWm0t1399Lv/wWX1BYiyhE6jaTGpWDhBM+h+ScpLD27M2kA+3kYOBK+IN5Gyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Nh04y5f1riPsscUeHzj88mM1eerhli3ewRmK5ZNeO4=; b=Z18PK/iqLAxXUFLpW0oBDpD+9NeO7Zm8vbRtD250JoyfDaUgZQJlwAeWdrDajOZKcBXEp7YFXWyv8ZnJ8sGloARdM+CrRwHjh5u7/olrkrszu+R7xOGWWgcUUD8UJEOG5cudy2iX/ojILWnCSdHMlLq2JqITze+o0Qc8TB0CzcSDSIVUMT58ulRiNTKKGEYol4uUB3sD/U7/Xb3Ps092jcek4fFUVl9PQdb8n7Yy/cScG+SbjunbKClMxWYnoecEjZobyhcvsI4TfRthfJvh80/chcvH1+EMZxaNQsxoXzyOPOx2DkesZMRyoQ9dw1+My4NpdiD3jTTsWyBaqBg86w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Nh04y5f1riPsscUeHzj88mM1eerhli3ewRmK5ZNeO4=; b=Rf97QPyuip+Wahy8jBLpLxEFnLAq57ZecvnVrOclXi2p0Ya6iaowZIUtXy6rnHWzs1IxwZV2mTZWV0ezsIyMdbsoC0Ag4+nciz4NJnK9ohI3cWkh3nrkefPs6KJczSQfHjdmA54KhdCn3vo/HYk91W/8HTMqFZALoLcTyWl5H30= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4851.eurprd05.prod.outlook.com (2603:10a6:208:c1::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.23; Mon, 29 Jun 2020 08:44:43 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%4]) with mapi id 15.20.3131.027; Mon, 29 Jun 2020 08:44:43 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: use anonymous DV allocator argument Thread-Index: AQHWSi4tcGRHz7bjzE+B91CUOV2//6jvTpNw Date: Mon, 29 Jun 2020 08:44:43 +0000 Message-ID: References: <1593006401-6275-1-git-send-email-michaelba@mellanox.com> In-Reply-To: <1593006401-6275-1-git-send-email-michaelba@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7652b465-fab2-4cac-9314-08d81c08abae x-ms-traffictypediagnostic: AM0PR05MB4851: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 044968D9E1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XK86QQqaSXe/JXv7hUR52GQmKqzZz3LMUdpCQG3vlySIdHQnoU24zt5o3lxfcPUP1yoFNFE0kKSCJjRZ5Fr0oUmGs+Q21KX+d0XKCvwdRrQ0WsSSAQ2NpeqE5FTF7gmUaN6l8oJcNtIE+oV8eeEnhmZkzrMicfogu4z+jROg88hcpu7HA07xQ7j9+dmwIPa6Lpiior18NcFf7Z8CL2s+w9ehT7//LQOgWFxB32kE75frf7LfBUPFiWLfxcfKlt87wSOB4O+Th8J1jvktG7Nn+EwfGAlEiaThOy+yQW+1++aU8XdltAyGJAB6ROE2kwzjaUd5/iwpGncGkXnDAyL2LA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(346002)(366004)(39860400002)(376002)(54906003)(26005)(6506007)(478600001)(186003)(7696005)(2906002)(316002)(33656002)(110136005)(53546011)(52536014)(4326008)(66556008)(86362001)(107886003)(66476007)(8936002)(64756008)(66446008)(71200400001)(5660300002)(8676002)(55016002)(9686003)(66946007)(76116006)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 1y7HRncNthFMI8FVZAY+lT9LujsnUPqC6FxNr6Y+6vrxylVhidAZV6ITQuC+9E9b4vG32gVMrvU03FWGSwNP82Dv3WU8KCZk6lhlZZ4unupc17lJUjoEd3Fwt9x295agJdlf9saCwO1PzsRYVvvxvL0Z4KNVWepsgmVc1491LKfieAuYgK2YJTMZH79l+TGk5YW729sijZ1W6x9L8uSr/pD0TvUhKIJzUDmlBTRzp8oCehvf0sJow/QCaOoNNsUgiFnY4ZUmVzZEOz7jRiPV4Ebwj+7goOxwRE6qzUjt8NThrcruF/GMBAL3nWB5pSHn9nAVI9JEWmEDkN12ySH4YXhIew/U+eOI/fJ+pHxJYdnqdQH0pMTI2hnm7qccN/TdhhM3MEvkfAopK0iX8hvAH99EZAoJfBAOO2C0YimqGe6czjB69VHAa3Fu/cNUHvitGVAytMWSZXV4DEY2LIPMwZ9uQphKxA7ul+0zyDPvSvm2lCgly/qYh2RKpbruefly Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7652b465-fab2-4cac-9314-08d81c08abae X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2020 08:44:43.7351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qb+iOHExEIt0Eog2v8+6QmwhPaqQrS8TgFsf9M1bn9FlzOErrhFWQtDzUOJZwdm7cUu83mJWZrhyb28NjJg4hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4851 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use anonymous DV allocator argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, =20 > -----Original Message----- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 4:47 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH] net/mlx5: use anonymous DV allocator > argument >=20 > The mlx5_dev_spawn function defines an struct mlx5dv_ctx_allocators type > variable several hundred rows after it starts, with the only use it > being passed as a parameter to the mlx5_glue->dv_set_context_attr > function. > However, according to DPDK Coding Style Guidelines, variables should be > declared at the start of a block of code rather than in the middle. > Therefore, to improve the Coding Style, the variable is passed directly > to the function without declaring it before. >=20 > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/linux/mlx5_os.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > b/drivers/net/mlx5/linux/mlx5_os.c > index f0147e6..2dc57b2 100644 > --- a/drivers/net/mlx5/linux/mlx5_os.c > +++ b/drivers/net/mlx5/linux/mlx5_os.c > @@ -988,14 +988,13 @@ > TAILQ_INIT(&priv->flow_meters); > TAILQ_INIT(&priv->flow_meter_profiles); > /* Hint libmlx5 to use PMD allocator for data plane resources */ > - struct mlx5dv_ctx_allocators alctr =3D { > - .alloc =3D &mlx5_alloc_verbs_buf, > - .free =3D &mlx5_free_verbs_buf, > - .data =3D priv, > - }; > mlx5_glue->dv_set_context_attr(sh->ctx, > - MLX5DV_CTX_ATTR_BUF_ALLOCATORS, > - (void *)((uintptr_t)&alctr)); > + MLX5DV_CTX_ATTR_BUF_ALLOCATORS, > + (void *)((uintptr_t)&(struct mlx5dv_ctx_allocators){ > + .alloc =3D &mlx5_alloc_verbs_buf, > + .free =3D &mlx5_free_verbs_buf, > + .data =3D priv, > + })); > /* Bring Ethernet device up. */ > DRV_LOG(DEBUG, "port %u forcing Ethernet interface up", > eth_dev->data->port_id); > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh