From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B335EA00C2; Sun, 17 May 2020 10:34:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CBAD1D5ED; Sun, 17 May 2020 10:34:18 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80082.outbound.protection.outlook.com [40.107.8.82]) by dpdk.org (Postfix) with ESMTP id 26BAD1D5DC for ; Sun, 17 May 2020 10:34:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BomvFuYRJdIQwQ8+gllf3+o7w3ZU+IWQGIqlmVtcrPlj0tgL3NYPQonLbXew2V34RuxZnf86IJv/P5QUirLL3x5B6AahuhPO4sBljCSVvONYuewiZwnC3/gpk0I0Neorl5GYKE5dZqWRJiuIHu+AcG3s2emrdv3qQYXs4EwGCFG3FPVZ5Z7ozH9PPcT3jpI83myvf6F6Dt9wVIltwjT5T1Ml0L+yP9vFKQoI4jpqhviZzBMNkMvb+Evb16Oqtdr4ZEcbfaVV+2l7BkCflXUJN7vWkupXx6HH3bZOq2ArLaU7FsoSTmsGLOhV2md5/Z/7SHNurV1b0dNwfe52KyLFZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YH7yaogJcShO4YOOknUWyAZv1E6JP9B/QqhYfOZMl1I=; b=j+oEnRq35fDnQ3L01XiwRW/6ZdITavbjGlpmw53qRJeB3poWxObC2rRgareRBPaJdZFC7ijhsNpOdLDb8NST0k6VT7wgJ+Q45j7zQP3q7+KFiIKGGOoUmCLAYdCTxpyQw9iVXVYiT3MbkH8R4UQVPXBlWBooRFs+rUZ1mj0waoxsoFMZi/nBYBqfA4gEZwB3yT9xgQWPK6z6/HLfw3AEGJC3CxUTm64xalhK9clxFAmx5nVzApJ6OOmYKLNigsFc21FbRnpYJ0nZls/d0FnXZueeVwgtXTHomhoMyu8QBkB/bYLJ0rUDM38FIBahtxoDvxqsmHxE6CS5TZpc1sftDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YH7yaogJcShO4YOOknUWyAZv1E6JP9B/QqhYfOZMl1I=; b=EjgWCu0sqDJdVDDicZXCG8Bw3gRlMoTkdnGSaLjBQhdBUR+h3JdxxTq5s8WYtozdu5nnLGjiew550yf9EL6UCffdT5zEJyLwqQD+GmArVPUyqMftpzEfdleoua52SHDOilOwVeRC891xlAObj9P9l+7Tvkyx+l3fD7ozp2EwLDg= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB4209.eurprd05.prod.outlook.com (2603:10a6:208:61::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Sun, 17 May 2020 08:34:14 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%6]) with mapi id 15.20.3000.022; Sun, 17 May 2020 08:34:14 +0000 From: Raslan Darawsheh To: Suanming Mou , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" , Bill Zhou , Wisam Monther Thread-Topic: [PATCH] net/mlx5: fix Verbs counter pool allocation Thread-Index: AQHWKlKO++zhSGx6+E6f+SjysuqWC6ir9x9A Date: Sun, 17 May 2020 08:34:14 +0000 Message-ID: References: <1589503695-120616-1-git-send-email-suanmingm@mellanox.com> In-Reply-To: <1589503695-120616-1-git-send-email-suanmingm@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.229.217] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b30656da-65da-44cd-86a0-08d7fa3d14fb x-ms-traffictypediagnostic: AM0PR05MB4209: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-forefront-prvs: 040655413E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KqdLIZXGEbqiwZ2cdAF8cCCwUG2EZh+zEi0o3ZOgRV2e2/Sri54ImowjYJIgbIFyn4tD1u9M6a/kCCkk1JBTHz2JYLc1+i/YIqYAWdNYsGwfyhYgf+39BzEYmsw9y50lc1YPYOefb0UE9rfG2JiD7u0AafaA1452IMTU7XQlI9ZizE8DLx/6zE69TNG5vBh0UiTfJ5UKMPNOZYhgGl3M3AAfH/qtr6dqv4e4yuTxPhoiowNKIW9AkalD8HBYp71mBoEmD+Wg8KQs6Zhs8O+1SRPVuY4MC4Q3dKDrdmqZ+cgxaE7A05HgfRFq+ugN7l7gO5mVfxPmSLBKgWeL6TUtBX80gfXhsab2KNyrGbtSh2jMW502VNSx1KhN9iS/1epbO3U7U4yn9/bTkxyOcrSICvLifO5JMZJAWflkDwmYQdPkSvmhquQ0KBMS9u1EBmew x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(5660300002)(8676002)(55016002)(2906002)(110136005)(54906003)(316002)(64756008)(76116006)(86362001)(66946007)(9686003)(66556008)(66446008)(66476007)(6506007)(53546011)(7696005)(26005)(33656002)(8936002)(186003)(52536014)(6636002)(71200400001)(4326008)(107886003)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: DPT8dIXRvgluzvzwI7gPzLNxothZBfOG/PuziQ+isvFFfvsVl5Ze+UTzqTSmJtb6YsU5zHvUtwX0j8XF8ea9y8YGakmjXx3jsuedayI7UtRvu631dQlGuBrTxMjGo3XS6EVbD8SwBd6MSI6wU8x1ydKO6h/RKTAKW2Sb8xPk94XOJDIbzveBp122DZOC78OhBb5BaTH0WynTL7xKFqixYeNVEI+wQzgdFdv79PZzYHnw6Vf2bZJgOEHSYRyGsvzs9xTlFA0ooOFbA2LXQ4s5vcmJgYPUe3+HYAQH6HfTZ3Tm34ZPocKARzpSbl17aPz5FnKrxan+TenrbFYgmKvkHO5+DcBUqwzxUt2SXmk61KkWuHueeClBnXHn7gNxOy9LDML/+HStQPhGko5yTbav385GzwzjCl0nBEjnf4a1SdGnK2DlvPkT+yfmUlKdn7HTspEFnWggRQSOeofobilF9LoHqcRoxSxJvggfp4Z3rnexAGDreGYiN05LSAMlXHwn Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b30656da-65da-44cd-86a0-08d7fa3d14fb X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2020 08:34:14.7106 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ffFjrYOQV5E4HD2hJHm1HTMa8bdonzMHg941ffx9J39WV5OVdFLF81LaXAg6NSfxFP8ODU1uQILqNWi2MYOh1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4209 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Verbs counter pool allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Suanming Mou > Sent: Friday, May 15, 2020 3:48 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh ; Bill Zhou > ; Wisam Monther > Subject: [PATCH] net/mlx5: fix Verbs counter pool allocation >=20 > When create the Verbs flows with counter, randomly SEGSEV will also > comes. The reason is that the counter pool memory is not allocated > sufficiently and initialized correctly in Verbs case. >=20 > As the mlx5_flow_counter array member is moved out of the counter pool > struct, the counter pool memory layout currently contain implicitly > with mlx5_flow_counter, mlx5_age_param(if the pool is an age pool), > mlx5_flow_counter_ext(if the pool is a none batch pool). When allocate > the pool memory, the pool size should be calculated based on the pool > type accordingly. >=20 > Currently, for Verbs counter pool, both mlx5_flow_counter and > mlx5_flow_counter_ext need to be taken into account in the pool size. > And the pool type should also be initialized as CNT_POOL_TYPE_EXT. >=20 > This patch add the missing size and type for the Verbs counter pool. >=20 > Fixes: 8d93c830e450 ("net/mlx5: modify ext-counter memory allocation") >=20 > Signed-off-by: Suanming Mou > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow_verbs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c > b/drivers/net/mlx5/mlx5_flow_verbs.c > index 01eec31..c266e56 100644 > --- a/drivers/net/mlx5/mlx5_flow_verbs.c > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c > @@ -201,11 +201,12 @@ > cont->n +=3D MLX5_CNT_CONTAINER_RESIZE; > } > /* Allocate memory for new pool*/ > - size =3D sizeof(*pool) + sizeof(*cnt_ext) * > + size =3D sizeof(*pool) + (sizeof(*cnt_ext) + sizeof(*cnt)) * > MLX5_COUNTERS_PER_POOL; > pool =3D rte_calloc(__func__, 1, size, 0); > if (!pool) > return 0; > + pool->type |=3D CNT_POOL_TYPE_EXT; > for (i =3D 0; i < MLX5_COUNTERS_PER_POOL; ++i) { > cnt =3D MLX5_POOL_GET_CNT(pool, i); > TAILQ_INSERT_HEAD(&pool->counters, cnt, next); > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh