From: Raslan Darawsheh <rasland@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>,
Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: Ori Kam <orika@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix setting of port ID for egress rules
Date: Sun, 26 Jan 2020 16:36:39 +0000 [thread overview]
Message-ID: <AM0PR05MB6707DB94EADEC9E06B9828D0C2080@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <83dbb58c4cdd07e9797af3c29cb324578c5b40ea.1579696358.git.dekelp@mellanox.com>
Hi,
> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Wednesday, January 22, 2020 2:33 PM
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>
> Cc: Raslan Darawsheh <rasland@mellanox.com>; Ori Kam
> <orika@mellanox.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix setting of port ID for egress rules
>
> Previous patch fixed the setting of port-id for eswitch rules, which
> are ingress only.
> This patch expands the fix, to support nic rules as well, which can
> be ingress or egress.
>
> Fixes: ce777b147bf8 ("net/mlx5: fix E-Switch flow without port item")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Ori Kam <orika@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index 5a1b426..7a169c7 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -7645,13 +7645,13 @@ struct field_modify_info modify_tcp[] = {
> item_flags |= last_item;
> }
> /*
> - * In case of ingress traffic when E-Switch mode is enabled,
> - * we have two cases where we need to set the source port
> manually.
> + * When E-Switch mode is enabled, we have two cases where we
> need to
> + * set the source port manually.
> * The first one, is in case of Nic steering rule, and the second is
> * E-Switch rule where no port_id item was found. In both cases
> * the source port is set according the current port in use.
> */
> - if ((attr->ingress && !(item_flags & MLX5_FLOW_ITEM_PORT_ID))
> &&
> + if (!(item_flags & MLX5_FLOW_ITEM_PORT_ID) &&
> (priv->representor || priv->master)) {
> if (flow_dv_translate_item_port_id(dev, match_mask,
> match_value, NULL))
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-01-26 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 12:33 Dekel Peled
2020-01-26 16:36 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB6707DB94EADEC9E06B9828D0C2080@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).