From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19381A052F; Sun, 26 Jan 2020 17:36:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAEDE397D; Sun, 26 Jan 2020 17:36:41 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2071.outbound.protection.outlook.com [40.107.20.71]) by dpdk.org (Postfix) with ESMTP id 54BC137B1; Sun, 26 Jan 2020 17:36:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=heMQU7gS4qRqMJpE8K38qG70SpnXbQV6coivlmOWHZcRr34BXzTBgWvscEx4YlQVpc0m5w/cjFstHN8lTYomfQ4muF1lFX+usq31s9mKlMUBUimXeVvXIThjwPJNw0Qm5AtXEqpSeuKHrcnRiB9HwORfbwI6xoqywQcBSmv/n6P6SP5/JkVHO38DydIMH9of7C6afw1X6Q9JaxhkpNng/XWG71PAynQmtfN8RcapvxQWkgypoKwd+iUy+wSFX1ANjifCLRbCEreOT2BmVb28hB/SmMnsCaZjZoR0HVkw4OsCg65dRJDyh/XitTpUAv23fQb9tUYCaUWUnGrgCoUEqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ySJ6BHKl5o7nG8x5rPoVRJw6NXflxV7ldlUFyxYm+4E=; b=mHTCh8Pu3rPlJ8+EoSrMxgU5OK6+Qazn7IgzvcvytgwM+85GB1o7wIB5XAoiQMHgL2ccxeqgRvXFTw2Ai9ullssIgIF2+9iK/VUmnwQR5qiM2vwybrDrUFLBqTtPKIOPgvknuH4jOQfptWHH37NaHyP3Num2mKZtJjW7l+/xpr3DNEuRFkk5yYGWat38tOSAvfu00EeGyfJjN5lhlRgRfyQKvAdmrJ3OohZHfXGLAKluPXDqC7hEpuMW1Z+H3sZ6v09aBY0V6UdHBs3S0D42RMounq0IDDYSN0S3IPtK6JL7zpXVEifKjb4zLTset+oeotwwVGF8FsRK50QnEuutLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ySJ6BHKl5o7nG8x5rPoVRJw6NXflxV7ldlUFyxYm+4E=; b=T1XzfcX5rFb6PRe49QY6Ow0OHOQIvmeClwe1tEW7uI0FET2eQa+0r81t4EiZfAMZWs263P9tAaBk2H/cZiIkHMSjCJBK0Btx9Fyi13vEdix77hHWhJ9Z9drPgVePbV5/nFGBzfMWr9KKwZO5Y85474WijMZ22adCIhTfcG+g6tM= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB6209.eurprd05.prod.outlook.com (20.178.113.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.22; Sun, 26 Jan 2020 16:36:39 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::f0b7:a92b:aeb5:5761]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::f0b7:a92b:aeb5:5761%5]) with mapi id 15.20.2665.017; Sun, 26 Jan 2020 16:36:39 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , Slava Ovsiienko CC: Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix setting of port ID for egress rules Thread-Index: AQHV0SCJw0HmVzb6uE6B3wmCyh1b5qf9KzvQ Date: Sun, 26 Jan 2020 16:36:39 +0000 Message-ID: References: <83dbb58c4cdd07e9797af3c29cb324578c5b40ea.1579696358.git.dekelp@mellanox.com> In-Reply-To: <83dbb58c4cdd07e9797af3c29cb324578c5b40ea.1579696358.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e68a39e8-a938-4fe9-cef8-08d7a27deb15 x-ms-traffictypediagnostic: AM0PR05MB6209:|AM0PR05MB6209: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 02945962BD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(346002)(376002)(39860400002)(136003)(189003)(199004)(2906002)(52536014)(54906003)(5660300002)(55016002)(478600001)(86362001)(7696005)(4326008)(33656002)(9686003)(53546011)(6506007)(8676002)(81166006)(81156014)(8936002)(71200400001)(64756008)(66556008)(66476007)(66946007)(6636002)(450100002)(26005)(110136005)(316002)(66446008)(76116006)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB6209; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IbZv6i/J8SZkTVa6s0lUviVB8k3vC4FUPbdoXdQq3adH+S431if78VR3oVqjG7KLvWYhDbZ6ZotfbA4h8HQ56LzqKMdAvbiXFVukt0j8uL5j6H099RMU1GicUrLpCV/ZcagHU5xKxs4aEQf6RKzPOEAlC8muqppxWGtZuwL7VNQrc8XUAvShBF2HSMBJwRjy8Bvv1de6UQC9LQRcgwRPVpTpLxbmMDXmpJcfMw8WgEkKc9VuUHROKLTsSKzDgY3lMP2y0vk+Cm06bFxAkhkmE0b3XHx/YCyOsjHZR1/Zu+91Vg4zD8MrEGYI/H0hC7ADG5+9g6dimtiNvTPf+Oe/Do6vEhsXexHxsDUY1h0HY026CxM6lO7bZi/+uQ2mYMTBeSZ7rVAq/t2SuUhBcYKWwNFuDykMtYkl4sgokCTwT7UX3jLbcCsMlsxiqeW53Lm2 x-ms-exchange-antispam-messagedata: SLBtNg0F7ayP5lgxFRMvE3cg0n+GiyPU1cKhsqyVQvtXC9swY3/XS8Y7gLBKgJMYwp5I0Mqkc1bjroQTrR33cqm0F68abamnlNn2oq3F7L1F0tbVyQYb/Dz8XKfyR5LObgfA6UvjhiY+BhSloVPguQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e68a39e8-a938-4fe9-cef8-08d7a27deb15 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2020 16:36:39.3527 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tngf42C6Lrgh4A4LDDQ5r1r2VtZAO0OJQOzAbnow1IbQPYuUzOy2zseboToKTSl+I2+07mRBlaG756A2I3Nrtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6209 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix setting of port ID for egress rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, January 22, 2020 2:33 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix setting of port ID for egress rules >=20 > Previous patch fixed the setting of port-id for eswitch rules, which > are ingress only. > This patch expands the fix, to support nic rules as well, which can > be ingress or egress. >=20 > Fixes: ce777b147bf8 ("net/mlx5: fix E-Switch flow without port item") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Ori Kam > --- > drivers/net/mlx5/mlx5_flow_dv.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 5a1b426..7a169c7 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -7645,13 +7645,13 @@ struct field_modify_info modify_tcp[] =3D { > item_flags |=3D last_item; > } > /* > - * In case of ingress traffic when E-Switch mode is enabled, > - * we have two cases where we need to set the source port > manually. > + * When E-Switch mode is enabled, we have two cases where we > need to > + * set the source port manually. > * The first one, is in case of Nic steering rule, and the second is > * E-Switch rule where no port_id item was found. In both cases > * the source port is set according the current port in use. > */ > - if ((attr->ingress && !(item_flags & MLX5_FLOW_ITEM_PORT_ID)) > && > + if (!(item_flags & MLX5_FLOW_ITEM_PORT_ID) && > (priv->representor || priv->master)) { > if (flow_dv_translate_item_port_id(dev, match_mask, > match_value, NULL)) > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh