From: Raslan Darawsheh <rasland@mellanox.com>
To: "xiangxia.m.yue@gmail.com" <xiangxia.m.yue@gmail.com>,
Matan Azrad <matan@mellanox.com>,
Ali Alnubani <alialnu@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH dpdk-dev v3] common/mlx5: fix dynamic loading reference
Date: Mon, 9 Mar 2020 09:10:51 +0000 [thread overview]
Message-ID: <AM0PR05MB6707DE4D71FA95EEB2446DD7C2FE0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1583504839-11329-1-git-send-email-xiangxia.m.yue@gmail.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of
> xiangxia.m.yue@gmail.com
> Sent: Friday, March 6, 2020 4:27 PM
> To: Matan Azrad <matan@mellanox.com>; Ali Alnubani
> <alialnu@mellanox.com>
> Cc: dev@dpdk.org; Tonghao Zhang <xiangxia.m.yue@gmail.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH dpdk-dev v3] common/mlx5: fix dynamic loading
> reference
>
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> When setting the CONFIG_RTE_BUILD_SHARED_LIB to y,
> and build the mlx5 pmd, there is a building error.
> To fix it, add RTE_IBVERBS_LINK_DLOPEN to include
> relative codes.
>
> mlx5_common.o: In function `mlx5_glue_init':
> drivers/common/mlx5/mlx5_common.c:324: undefined reference to
> `dlclose'
>
> Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Tested-by: Ali Alnubani <alialnu@mellanox.com>
> ---
> v3:
> * rename the patch title
> * mv the dlfcn.h to define area
> * tested:
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis
> -ci.com%2Fovn-open-virtual-networks%2Fdpdk-next-
> net%2Fbuilds%2F151882661&data=02%7C01%7Crasland%40mellanox.co
> m%7Cc089a6504673460ee42c08d7c1da91c5%7Ca652971c7d2e4d9ba6a4d1492
> 56f461b%7C0%7C0%7C637191016800944332&sdata=AL6s1X0NFyBtAi%2
> BfFS%2FwB41xHZBUQsvDUZ5%2FWucJTd0%3D&reserved=0
>
> v2:
> * change the patch title
> ---
> drivers/common/mlx5/mlx5_common.c | 10 +++++++---
> drivers/net/mlx4/mlx4.c | 4 +++-
> 2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/common/mlx5/mlx5_common.c
> b/drivers/common/mlx5/mlx5_common.c
> index 610fb48..9ea56f2 100644
> --- a/drivers/common/mlx5/mlx5_common.c
> +++ b/drivers/common/mlx5/mlx5_common.c
> @@ -2,10 +2,12 @@
> * Copyright 2019 Mellanox Technologies, Ltd
> */
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-03-09 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 10:55 [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error xiangxia.m.yue
2020-03-03 7:15 ` Matan Azrad
2020-03-04 13:55 ` Tonghao Zhang
2020-03-04 14:25 ` Matan Azrad
2020-03-04 15:13 ` Tonghao Zhang
2020-03-04 16:03 ` Matan Azrad
2020-03-05 6:59 ` Tonghao Zhang
2020-03-06 14:27 ` [dpdk-dev] [PATCH dpdk-dev v3] common/mlx5: fix dynamic loading reference xiangxia.m.yue
2020-03-08 6:39 ` Matan Azrad
2020-03-09 9:10 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB6707DE4D71FA95EEB2446DD7C2FE0@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).