DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: Suanming Mou <suanmingm@mellanox.com>,
	Matan Azrad <matan@mellanox.com>,
	Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: optimize free counter lookup
Date: Sun, 21 Jun 2020 15:10:29 +0000	[thread overview]
Message-ID: <AM0PR05MB6707E521CD8F75E1F6EBEDCBC2960@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1592467970-143747-1-git-send-email-suanmingm@mellanox.com>

Hi,

> -----Original Message-----
> From: Suanming Mou <suanmingm@mellanox.com>
> Sent: Thursday, June 18, 2020 11:13 AM
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>
> Subject: [PATCH v2] net/mlx5: optimize free counter lookup
> 
> Currently, when allocate a new counter, it needs loop the whole
> container pool list to get a free counter.
> 
> In the case with millions of counters allocated, and all the pools
> are empty, allocate the new counter will still need to loop the
> whole container pool list first, then allocate a new pool to get a
> free counter. It wastes the cycles during the pool list traversal.
> 
> Add a global free counter list in the container helps to get the free
> counters more efficiently.
> 
> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> 
> v2: update the commit title.
> 
> This patch should be integrated after
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> es.dpdk.org%2Fcover%2F71716%2F&amp;data=02%7C01%7Crasland%40mell
> anox.com%7C6ee45fdcd79c4e70c9dd08d8135f67f0%7Ca652971c7d2e4d9ba6
> a4d149256f461b%7C0%7C0%7C637280647785241368&amp;sdata=93W%2B7FJ
> 8Z8zuoo2XsU%2B0YkHdVzTTo2xMXtrQx85N%2FCo%3D&amp;reserved=0
> 


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      reply	other threads:[~2020-06-21 15:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  7:42 [dpdk-dev] [PATCH] net/mlx5: optimize the counter allocate loop Suanming Mou
2020-06-18  8:12 ` [dpdk-dev] [PATCH v2] net/mlx5: optimize free counter lookup Suanming Mou
2020-06-21 15:10   ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR05MB6707E521CD8F75E1F6EBEDCBC2960@AM0PR05MB6707.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=suanmingm@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).