From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BC55A0559; Sun, 15 Mar 2020 12:29:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 50FC04CA6; Sun, 15 Mar 2020 12:29:55 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80088.outbound.protection.outlook.com [40.107.8.88]) by dpdk.org (Postfix) with ESMTP id 41FAEFEB; Sun, 15 Mar 2020 12:29:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KFovuVUojUcKMcE+EsH9Uw7b08CSDeLk+tKyNGxJ+BRGbjJVRVeqatZUWhAOninH1Dwez/0auXLz+RjrBYzqbIOHVDW1wRygYF2OkVt2gammeB26s8He8WW35o6atJ7Nnz11zlqXWS+re/DSFFWYmpqcx/YKUeRkeqKcfxBW9lo1SI08PuWD6ctHm7QYHfLCudlR8eEEYLCAMh8k1MOaDD1yoRWOABTbx8D6warCNlIoBYLm7lkROozkitBY4bsaP1yBNZp3EWiXrGC/yuoVYFcCK+mNl0p06z8ZlWRD+7O0llpa9Vxi00HyUL6fbRwGjwB63uvqghiiYkndfjid8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SGEt24fXMzmPnRfhvmDBueQaA1mk/ihG+q5WpwnpwTc=; b=CswgYBXwGr3hLLQST0bh4iqjSIvccWLPOGLI2QRdSRT7b63Tn2ywFcfs/ZN5elrQ+EXdaDlAtRFyP/n83+JKKrObgb0D4PHeRD/UVCIrsYTtIj6I5MflVqbbTfq1T2B57CJrV12R7AmtL1w33Iw443Wlb/WufB9VqfF04LJEyHnapUAsYJj0s8MX9TM9QlN7n4oi1S5aHPpbeHt9XY1suTkBGY8hcrIGMCS7eK3L4Oi8e4Wj09MIb22APYUz5a57NeZw69prN4KJgeDJDi1ENYldWnXuRhZw/4zX0HUDj32f1DeL7em5d7JqrzeN71jZZQp6vik7OnBiofJ6FpyPbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SGEt24fXMzmPnRfhvmDBueQaA1mk/ihG+q5WpwnpwTc=; b=jHQXL8YyIxrHtjfy9ZBi7aEQhd67IkJrIuwAW5mjXiFFGabmYjeFFAXaHvunIrYf3Jvs+QGmkhoH+T36shksKQMFHaAF7SZ2OPBvES7TVIqrdNmbm17RngNl0wLd/eN/P4+xWaQaifxDVhFPmJvzP7EIZCfDrr++0jwpgHom4lo= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB4289.eurprd05.prod.outlook.com (52.134.126.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.16; Sun, 15 Mar 2020 11:29:52 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::adbd:45ca:54:bba9%7]) with mapi id 15.20.2814.021; Sun, 15 Mar 2020 11:29:52 +0000 From: Raslan Darawsheh To: Wisam Monther , "dev@dpdk.org" , Matan Azrad CC: Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix validate set meta action for zero value Thread-Index: AQHV+FAUFWXVFUlP40qE3C0gZipPQ6hJiWIw Date: Sun, 15 Mar 2020 11:29:52 +0000 Message-ID: References: <1584005080-32321-1-git-send-email-wisamm@mellanox.com> In-Reply-To: <1584005080-32321-1-git-send-email-wisamm@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9861ef82-2557-4d49-bdef-08d7c8d42deb x-ms-traffictypediagnostic: AM0PR05MB4289:|AM0PR05MB4289: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0343AC1D30 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(396003)(376002)(39860400002)(366004)(199004)(55016002)(9686003)(450100002)(4326008)(6636002)(2906002)(478600001)(8936002)(76116006)(66556008)(66946007)(86362001)(66446008)(66476007)(71200400001)(64756008)(52536014)(33656002)(81166006)(81156014)(8676002)(53546011)(186003)(54906003)(110136005)(7696005)(5660300002)(316002)(6506007)(15650500001)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4289; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r+7s1Vpo83gXfQVct7XFay/RXx044fRL43E4/4FnlNAki2P7w8XWiZdc6oz92u/jrnl3eA97L6WbY3CheUdkOkmZophrsOuPACO/OhHdBRyx8FZQR4QCNvwbOryEldENsA9PJfBuvy9o5hUBWfEA7rkxhSx/vTVfYhybQXN6gU/PU8pe9uEcgV76WJNXlYvDdit3boNZekbNVQQM7xszzRkYT4dBRXIpRDjSIEo8bIl9/Tsv/My8GwwPwmvsmH5MwN4VjDpW3aP5A+T0KPzO9MXsfuFRVLGFVPL5Q85yBAsJyr0iGoLlky87inW1c+UP4ViaPfJhtjMtmOBEUsgQMGbd7bNL81GVw2fTDDc8Q7yBgdZMPZSis/OCnJ2EHiTam2DvY4GPtUHMdc2Ug1QKunozuEPjN/dE2mbUAviaZfE/IQAr/gVixKaFNhfjKuhS x-ms-exchange-antispam-messagedata: +PzDMVXIchf/45HmeZROXZOaIhPZOYbPwgor6LWuCq2/8XqcXhTUjD0/YApwbE+mTHMi41JuxcMqIg4kxGMAKXfmpI/gTGKDGivmPmW3CjrwExMednL1edkWOY8+PScIoBaqAvf/kmMV1npYQCyGZQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9861ef82-2557-4d49-bdef-08d7c8d42deb X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2020 11:29:52.3299 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kVn807xpkqi/qF3X1waIyUPRz1WaSVfEfz/ychVIEXACSw9NZOHAtZgsRiN7wiVKxbK/NE5s9DGRVy4iAbaqOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4289 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix validate set meta action for zero value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Wisam Monther > Sent: Thursday, March 12, 2020 11:25 AM > To: dev@dpdk.org; Raslan Darawsheh ; Matan > Azrad > Cc: Slava Ovsiienko ; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix validate set meta action for zero value >=20 > There is no reason to prevent the user from using zero metadata, > it indeed means no metadata, but sometimes the user may need to > report to datapath that there is no metadata anymore, which is > valid case. >=20 > Fixes: fcc8d2f716fd ("net/mlx5: extend flow metadata support") > Cc: viacheslavo@mellanox.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Wisam Jaddo > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index e7278f0..e2d6690 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -2109,10 +2109,6 @@ flow_dv_validate_action_set_meta(struct > rte_eth_dev *dev, > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > action, > "meta data must be within reg C0"); > - if (!(conf->data & conf->mask)) > - return rte_flow_error_set(error, EINVAL, > - RTE_FLOW_ERROR_TYPE_ACTION, > action, > - "zero value has no effect"); > return 0; > } >=20 > -- > 2.7.4 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh