From: Raslan Darawsheh <rasland@mellanox.com>
To: Alexander Kozyrev <akozyrev@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: do not select legacy MPW implicitly
Date: Mon, 15 Jun 2020 08:51:32 +0000 [thread overview]
Message-ID: <AM0PR05MB6707E832353E09EAEA1337D1C29C0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1591897320-15192-1-git-send-email-akozyrev@mellanox.com>
Hi,
> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@mellanox.com>
> Sent: Thursday, June 11, 2020 8:42 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; Slava
> Ovsiienko <viacheslavo@mellanox.com>
> Subject: [PATCH] net/mlx5: do not select legacy MPW implicitly
>
> The Legacy MPW (multi-packet write) should not be engaged implicitly.
> We should exclude this function form a Tx burst routine selection process
> unless it is requested specifically by setting the txq_mpw_en devarg.
> Exclude this function from the selection process the same way it is done
> for the Enhanced MPW in the mlx5_select_tx_function() routine.
>
> Fixes: eb8121ab9dac ("net/mlx5: introduce Tx burst routine template")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 6a17a9a..df58af5 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -5542,6 +5542,9 @@ enum mlx5_txcmp_code {
> /* Does not meet requested offloads at all. */
> continue;
> }
> + if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_MPW)
> + /* Do not enable legacy MPW if not configured. */
> + continue;
> if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_EMPW)
> /* Do not enable eMPW if not configured. */
> continue;
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-06-15 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 17:42 Alexander Kozyrev
2020-06-12 19:59 ` Slava Ovsiienko
2020-06-15 8:51 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB6707E832353E09EAEA1337D1C29C0@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=akozyrev@mellanox.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).