From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37996A0524; Sun, 26 Jan 2020 17:19:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF1B44C74; Sun, 26 Jan 2020 17:19:27 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2053.outbound.protection.outlook.com [40.107.22.53]) by dpdk.org (Postfix) with ESMTP id E67102B89; Sun, 26 Jan 2020 17:19:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hjn4OP+n7gb6VKn+yCrWL2Pj0B+xnZzszy3zAmigkUktioUv5AMW6FNW2brBAqwRIZiRBGBonfQE4koH8uXmS8zH1xLHsum52yvu1nEAuPk1Z8g19GiWbWgDEG1pCYG+mG1KFgvNf6pzFjSVwzkF7aYJ3gvHIepYKJQsO+lBPTiL7q5lMkkKWHUWhCqN7/ELBIvQbcJ7dW+LTycascwNPn5tHLipgaEnojRYc04BzwCN+JUyOvIOcTp+b0jfuSgG8+UrR5UPdIZ5QXCScsn7oP02Qz+MXD8L492EfS7H2qs1OiB3nNF7pzVpGs7XHTjfHoXzleBP4VlYuUp62Nddlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QumddCq29a2qoshQQmyuy2SPu2vhHHIS3b/wB4pBITY=; b=HzKb6w2hoLSTRr8rG9qLlytrOfSvng4MMLf94DngXwWwL0E6sBhCuJGhiOjNvReMmY/OZvpJgJUz+qNYFIIJ0WSER6pKWLVMq452JmtgpzSST+/h28TahX2faI3s9xAYpVEMjZLKgJKf9o3xlfuyEXcKr39cN+Nm/oemtfwmLUdvg2PqG4RymXKYsMLIrtQ7hz/V4FSFfoWD8nU02L0rWhPVWW3Vq2R04A4105e4TsnWf2Ga+GWnauu1Su66/dcP46Sp9nuk3kGoi2D1sE1TtaG3xjuYi5/tYGEB1LnflKO9HYPiiliqTeJAJtGHDMfrMflzQnNfji3FLUhknYfhPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QumddCq29a2qoshQQmyuy2SPu2vhHHIS3b/wB4pBITY=; b=mvcB1fkX4xWSXpL82hSmTrGthbsHa7HTd02b/KIFRVtd/y4c9TvjcB1xGg+9imOAzWaRm1GPCjYbyLy1+EUcOvd0ocwHKY5QscQlKcfymXcapRM8KXqiWEQBKLuoN5wwebZXJMFNXmGcVsfBfJDhVXA2K3t00c0w6eekUNCNGIE= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (10.186.174.145) by AM0PR05MB5891.eurprd05.prod.outlook.com (20.178.203.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.20; Sun, 26 Jan 2020 16:19:25 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::f0b7:a92b:aeb5:5761]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::f0b7:a92b:aeb5:5761%5]) with mapi id 15.20.2665.017; Sun, 26 Jan 2020 16:19:25 +0000 From: Raslan Darawsheh To: Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , Eli Britstein , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix zero out UDP checksum in encap data Thread-Index: AQHV0TU0zGW0IPQlsUihBB1WZHK956f9JkeQ Date: Sun, 26 Jan 2020 16:19:25 +0000 Message-ID: References: <1579705438-31330-1-git-send-email-matan@mellanox.com> In-Reply-To: <1579705438-31330-1-git-send-email-matan@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 20a1e1b9-a2b8-4f68-176a-08d7a27b82ec x-ms-traffictypediagnostic: AM0PR05MB5891:|AM0PR05MB5891: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:580; x-forefront-prvs: 02945962BD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(189003)(199004)(26005)(66446008)(64756008)(478600001)(66556008)(76116006)(5660300002)(66476007)(66946007)(6636002)(33656002)(52536014)(186003)(2906002)(4326008)(9686003)(55016002)(450100002)(81156014)(8676002)(8936002)(53546011)(6506007)(81166006)(316002)(7696005)(86362001)(54906003)(71200400001)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5891; H:AM0PR05MB6707.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p2lJyvd4fJWXMJzR4OIAF3eULEVGSOC0Jg8yBf6z5uC3aWrZx85Vs61YBs+WYULr2ZURMl8mHa5RBIyHn00uxKzYuwxUEap4Tddu7a9W/XsvcR4TYEgFzplMhXiFTdgOgPiw1ZKPKxn+5I9CAGfziJ+M09LfAoPSSTK7kfW5rXted0EMKeI3BkNMfSW/L+nC1dw/1Pxx+je5UXDqsMFGg5i/tfWUauTGltXp8Ljw+0VdMyFLTm6m/Ak6dAlLiBwYyBzZLBVzKEH8aj82v3MpjYoBOdjp0DvC5ptHzd0OhKIv/Da/wkYwJTQY6KdP2wntQlMOMZK9U6FQXdNBXjoEv1Mhn5M9xJ1pFFT0p3Ydu08Tv+xfBv/VC5+805B/6CAsAiZIa4uHB/UicpJ2DCL74zQd2dqJr2XCClxTxMjtOP5tE9Xc1U2ih4ybT8Yg8Jkp x-ms-exchange-antispam-messagedata: YMN3tmz1uQ0kJI7IIRE7pLlPHX02e9kcYUHPOKkhJz39XXFgnoV4lOvPlDYrcoQkAiuRyi06qVTr5f6vdBV74hjjbOqxc79nzR/xx1zC5/4o3V7slDqOaucXZlCapOveOhFjAwfxhBiKEbCnmt1SDw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20a1e1b9-a2b8-4f68-176a-08d7a27b82ec X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2020 16:19:25.6545 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: voORtrMTlnSXpadfzCguDRyiJ6DSD4V4MtbhuqAJ0xSszuVge5Ww0xXhqeKQ4DDn1L9w7OriKKa6bq4ZnzlFKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5891 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix zero out UDP checksum in encap data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Matan Azrad > Sent: Wednesday, January 22, 2020 5:04 PM > To: Slava Ovsiienko > Cc: dev@dpdk.org; Eli Britstein ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix zero out UDP checksum in encap > data >=20 > From: Eli Britstein >=20 > The cited commit zeroed the UDP checksum for raw-encap case. Add the > same handling for vxlan-encap case. >=20 > Fixes: bf1d7d9a033a ("net/mlx5: zero out UDP checksum in encapsulation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Eli Britstein > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow_dv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 5a1b426..367e7d7 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -2931,8 +2931,6 @@ struct field_modify_info modify_tcp[] =3D { > (const struct rte_flow_action_raw_encap *)action- > >conf; > res.size =3D raw_encap_data->size; > memcpy(res.buf, raw_encap_data->data, res.size); > - if (flow_dv_zero_encap_udp_csum(res.buf, error)) > - return -rte_errno; > } else { > if (action->type =3D=3D > RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP) > encap_data =3D > @@ -2946,6 +2944,8 @@ struct field_modify_info modify_tcp[] =3D { > &res.size, error)) > return -rte_errno; > } > + if (flow_dv_zero_encap_udp_csum(res.buf, error)) > + return -rte_errno; > if (flow_dv_encap_decap_resource_register(dev, &res, dev_flow, > error)) > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh