From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A84AFA04A2; Tue, 12 May 2020 13:52:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1EBE61BF85; Tue, 12 May 2020 13:52:47 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55]) by dpdk.org (Postfix) with ESMTP id 4D1A21BF7A; Tue, 12 May 2020 13:52:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MLCzIlfhPqO5GKR9s97/E4aO8GTKHqOcIO0H5EhDR7q5EQZ7xEG2BxMTO3LXRcBm7iPV46XfpJcR+POzlfPOwzgBlDQ3Onx3fBdEj4P43pKQHwjJ9n3L/lTSTlJq9xA41Smv3ulTQtMTiEkmAA/Qb2FXyalDmykCffMLb02ZMmo7of0DCP+U/Uj5YiQiuOaahqxlMnNjWifQMnVER15KNyjHaqayrDm7DEkwmokZUbAYcD6nMTPh/bGhbKJBnfqljMB6y1tDbYhoGx95TQGVBJOVlTPQlD7Qw/UwZzv+S9PKOwj74awmWbznJX7oESMZqKPOfRlxzdr0bflVDpOdtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZI2bajcDhYCl3AppJRY517qaAzoW+Z/AvbM4RoSQ7yw=; b=Us/cY6cfsguE1Je5oL0+BUiXe2hSeaPxLtVtNXNyMLGGhjKBWelqVnTOVxDxSwCYdA+gqLeiwB3IE980M6p6PSA9n+Og+vnhr7nzb0Mt3Z0YV9/6dzvBBBgItQO4jri2esKf/bzra/laLdLKbKrHhnnFLsSfYNfcQgSEnpduyc+NeYZE81asDV9GKNG90Xmc5XFzI47yXHT5RbIhti4hpA7e/b3jSh5OP/6On+rUah+D56q17hNQ0els/88za0BudKBaLawLpijGA7tpI5BQDgtLQCjf/abXX5DDHmTBD78HE7V2z2FLNakB0b7ZPIKGiW3gpuGAZ5nALgf3z4Y2Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZI2bajcDhYCl3AppJRY517qaAzoW+Z/AvbM4RoSQ7yw=; b=TVr4Q8wg5YMm8YCgfB4mwZF6iniHegBWyeMP96p99q4B+LsB6d4+L4Mpiys2ntFxT/9iupca1xAU0NuAFUDTlhL2Jp+fmVvuuU8manQ7mijW/C0TTY53JasUaYhG+cWiLSf6dYHehnPjGshQUzRfuYVxaUCmNkhSYVqTTLhTCVE= Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM0PR05MB5123.eurprd05.prod.outlook.com (2603:10a6:208:f5::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.33; Tue, 12 May 2020 11:52:44 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::508:747b:cc12:5f6e%5]) with mapi id 15.20.2979.033; Tue, 12 May 2020 11:52:44 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] common/mlx5: fix umem buffer alignment Thread-Index: AQHWJ3uHYGO+Zsy43E6tP+eYTCINYaikWKBQ Date: Tue, 12 May 2020 11:52:44 +0000 Message-ID: References: <7a382de5e9be260f7cadb07fd5396f48615ea911.1589191348.git.dekelp@mellanox.com> In-Reply-To: <7a382de5e9be260f7cadb07fd5396f48615ea911.1589191348.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [188.161.229.217] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fbd38e04-f549-4052-dfa0-08d7f66afb82 x-ms-traffictypediagnostic: AM0PR05MB5123:|AM0PR05MB5123: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0XXhhzfUBGJYeCPt46StSOqpPQeoNZbdTjQDK/aqxG/imEWGZ0MXN447BIKSuw8P6bhJxuVbG1rIzmvef6sX/PM5W6Uyts2vLMpRkJxqPienHZdq7OOQ5TVqcMRG+p3m9nLpUD4jzjmx6oUpRqIt3YP+9WBx1yq8/Jm1+Oww9EbpqpmIR9WFP2Ni6nxeImPSSOoIE0X5FgKHfgFyPrKxoGxLvFxp4C8AqLgDmc3UWbQY656WvD37lqg15JrPJ/g099tSD/1JMxiUil3hqgg7LA28OEHodU6Vlv11l8v01YeXp/ndZ51uvDusk9PhQrFKhwkJSdXV9kvLf7hrN4JgSJBPoOGkj7GtoQQSsDoWbRbUgQAuNs0bfGssc+G4Aeu8NppC6lcvMKUMmD9xyqFiQrlIKmyXXtnkp4AsoBiPRUPQAND45dfIos0mSgrp/A/vuCygQXXlsXJxwcfZzdjc1O3QqH+xCAgKaMclVwu82Szu7KMst0HkeK2wky9ln66ym+gQAfnLo33AE5TpV7g/1g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(366004)(39860400002)(136003)(376002)(396003)(33430700001)(76116006)(66556008)(86362001)(54906003)(6506007)(110136005)(33656002)(9686003)(55016002)(4326008)(186003)(450100002)(53546011)(26005)(6636002)(7696005)(5660300002)(66446008)(8676002)(66476007)(66946007)(64756008)(478600001)(8936002)(71200400001)(52536014)(33440700001)(316002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: RmXkeEdpCS0OoxaMWqX/JJPyuDZXYz7OuE1P0UvHLk/y/NhH+hSlBNFe3Q00HfZ03d6Og6M/WINeISEsJD2rZ0BjVajD+YH5NQ8yorPF/1xMUFnLxFnnU8rULHLPqTeQe7zA+jNhTAf55NzjY3jAF0B1IKCqoB7ZR0MXF9FaoL4TE0o7fWsDT6P7N8F3XX3lso2fMlE+eJM10Yf7P70ovtJsMSJerpUNLodNzZ4YfbIWmplbL9WfB03j2gc7w8vLqeF7DpkGRow9dj+hQeGy3kh8Xf1f858vsKKCNT+wWfDybIWbb5+y1d824oaGs1MkvhImB87koL3uHmr48tV6SIFCz4NU2oWDxcQFLmOlRdpP14+gfmS5Z1oAgGUpViX8iQoVdANHON2I7RC3OwWt4ejFhzxulFcfic66n9sLsai3u3hehtPcqbhv6KOUyoWvAt3yZw/hrteOaSn0q7I9FRUl4KkoqArl03qEDXLdUzFk0+VTFQpMSevB6X9J6Q0W Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbd38e04-f549-4052-dfa0-08d7f66afb82 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 11:52:44.1425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9a45n7efxCXlfPRDIn4ZTdhcGOMSK1h9kjnOptDKYsRURe+4TMM/tZE/81u1bqyY/ITw5wU1YUIxYJKMqJYU9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5123 Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix umem buffer alignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Dekel Peled > Sent: Monday, May 11, 2020 1:03 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] common/mlx5: fix umem buffer alignment >=20 > The value MLX5_WQE_BUF_ALIGNMENT is defined as 512. > In some cases this alignment size is not adequate, which results in > memory registration that is not accepted by FW. > The result error can be "page_offset is not aligned to page_size/64, > bad umem_offset" (syndrome 0x357275). >=20 > This patch updates the definition to match the running system. >=20 > Fixes: 18a68e046b51 ("net/mlx5: fix DevX Rx queue memory alignment") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad > --- > drivers/common/mlx5/mlx5_prm.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_prm.h > b/drivers/common/mlx5/mlx5_prm.h > index 4ab1c75..b39a141 100644 > --- a/drivers/common/mlx5/mlx5_prm.h > +++ b/drivers/common/mlx5/mlx5_prm.h > @@ -16,6 +16,8 @@ > #pragma GCC diagnostic error "-Wpedantic" > #endif >=20 > +#include > + > #include > #include >=20 > @@ -251,7 +253,7 @@ > #define MLX5_MAX_LOG_RQ_SEGS 5u >=20 > /* The alignment needed for WQ buffer. */ > -#define MLX5_WQE_BUF_ALIGNMENT 512 > +#define MLX5_WQE_BUF_ALIGNMENT sysconf(_SC_PAGESIZE) >=20 > /* Completion mode. */ > enum mlx5_completion_mode { > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh