From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AF05A046B for ; Thu, 25 Jul 2019 09:01:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CCAB1C289; Thu, 25 Jul 2019 09:01:50 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150087.outbound.protection.outlook.com [40.107.15.87]) by dpdk.org (Postfix) with ESMTP id E74B01C286; Thu, 25 Jul 2019 09:01:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z7C2SXowCR5EV7Xd/aYvUpiLcl4GRpLR6SjC9PGYpf2XC3Smyof7/3xIbMs+Cq5JdVCyIeJNV9wao7Xj/u4di3O100XTe+vGCrTIFtOxK1VOcYy1Wj4IQZsSdaoC52fQag+m/iWjQbtznRIpRcWciQ/3HQ1ddr1pwqkclZELYT+Oc/2tXCijYpvpyzs0iwoRC554jkccXuIbd2BiD8BnuzZwOx1PrxM9zkObSXubxtqu5EQ8cbN02GOEqpmzIESUlZvwopEP/1w/67Qsmo7vK+T7jlZ8muwtMPyGZ66ze6haeFYJ3KdzIa24802yLVl81cPipfJ//AR2OcwAJPcb/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I3TNO2MmR0JvllJvkno7NSy8+1gP86EKyjdVwLtUA24=; b=PEZInfLgwsaObkKV/EB0RK/5OtZNr2+SNkQBJ0T0HK/asAo7GVjKqJFVeuHkQilRJ9rXK2DRLrGAvqR3ABP6JNZ6xDKfAuVV13wTPvYbIJH/vLxES1rqrYQTprAHvSFUxDdPM0KUY9+ZVU9IqdFk8XWAO9n+nvH6WHLdWspoAybOE70hiZysHuJ9kOA1jaKQO+iQgs/3rrMPsuSzhzY+ck10L3nmA7NuFqVTxuvsfh4v70bso7vTdz8RttoxdRm0Zqk2YBjj5VtEPyaejM6kpwnXwC3CqKanXwUhrLb5wwD2NiTkAQ1WMFoumHXqiwROh+8DZh3AxspQEWBIP0ACXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I3TNO2MmR0JvllJvkno7NSy8+1gP86EKyjdVwLtUA24=; b=4PIswCXICvEjeifvudzovFOexDEHDklVGPDYfgjdHEuc77BFFwuCnChbmEYrYb7X5pYWdT3GrpfNb6ywcK2IKekZOaaY3Zarv14AspeCs09b4q/xVBixRYrcUyL5wqVOSAZt7mYfE/xQFbLFm/j30x85rXWj+I+Ud/Jux9WCK8s= Received: from AM0PR08MB3986.eurprd08.prod.outlook.com (20.178.118.90) by AM0PR08MB3828.eurprd08.prod.outlook.com (20.178.82.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.13; Thu, 25 Jul 2019 07:01:47 +0000 Received: from AM0PR08MB3986.eurprd08.prod.outlook.com ([fe80::9837:70f8:ce94:8324]) by AM0PR08MB3986.eurprd08.prod.outlook.com ([fe80::9837:70f8:ce94:8324%7]) with mapi id 15.20.2115.005; Thu, 25 Jul 2019 07:01:47 +0000 From: "Ruifeng Wang (Arm Technology China)" To: hgovindh , Remy Horton , Marko Kovacevic , Ori Kam , Bruce Richardson , Pablo de Lara , Radu Nicolau , "Akhil.goyal@nxp.com" , Tomasz Kantecki CC: "dev@dpdk.org" , "maciej.czekaj@caviumnetworks.com" , "stable@dpdk.org" , nd , nd Thread-Topic: [dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access Thread-Index: AQHVQj8E4E6EhyiNUE+MPZuI7ffkf6ba5vpA Date: Thu, 25 Jul 2019 07:01:47 +0000 Message-ID: References: <20190724164354.18811-1-hariprasad.govindharajan@intel.com> In-Reply-To: <20190724164354.18811-1-hariprasad.govindharajan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: b647b513-b36e-42ed-b10b-b6dd21bda2c3.0 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9b02903-4c4c-4a65-bd19-08d710cdf5ec x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR08MB3828; x-ms-traffictypediagnostic: AM0PR08MB3828: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:229; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(396003)(39860400002)(136003)(346002)(189003)(199004)(13464003)(53546011)(6506007)(8936002)(25786009)(11346002)(446003)(8676002)(478600001)(55016002)(7416002)(54906003)(110136005)(6246003)(6116002)(14454004)(3846002)(305945005)(74316002)(66446008)(81166006)(81156014)(486006)(76116006)(52536014)(6436002)(71200400001)(71190400001)(316002)(186003)(66556008)(7736002)(64756008)(66476007)(66946007)(26005)(66066001)(7696005)(476003)(4326008)(5660300002)(229853002)(86362001)(14444005)(256004)(53936002)(76176011)(2501003)(55236004)(102836004)(68736007)(9686003)(2906002)(33656002)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3828; H:AM0PR08MB3986.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3FQjM8HDs1pyXebSKR82kjx8hDl0cD8MTzk51umJI/GcYTuYEm/Xy4IFhCsNCmdOu3uAeV7+CJkVhdWO30VqFlUEAKVJ4vW0ZKFLa+wLl8UU48eJLAIFz7rJvx317pWKQfkyb1mUpM1hTrIR/AKqAwdq+vxH/w1fDizQ8vCIYkOWqQMCb+GZIsW4QwuvdYMOyeKn6GA8s4UfRY1xcTjmv05+3xEzu7e+wZBwFOT3RrJsouIGBCeLbqnbXPusIah5DUJRbWZ7LYErxY7k2wPqRBSym4K6UlQDVGNNjmmSdHUYgrgE5hrDFSWdkRuFzTny8uDeW1NKwexbnd4ne1PAShm/NNVcMI1Wy+lEvwhdH5/QdKJcgPvu53xDp5aO/z2Kp8u3qQvUC4cNUXDJtq9Yr/Dj9O3QieoOD4+JHNB+A4k= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9b02903-4c4c-4a65-bd19-08d710cdf5ec X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2019 07:01:47.4998 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ruifeng.Wang@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3828 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of hgovindh > Sent: Thursday, July 25, 2019 00:44 > To: Remy Horton ; Marko Kovacevic > ; Ori Kam ; Bruce > Richardson ; Pablo de Lara > ; Radu Nicolau ; > Akhil.goyal@nxp.com; Tomasz Kantecki > Cc: dev@dpdk.org; hgovindh ; > maciej.czekaj@caviumnetworks.com; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access >=20 > Fix unaligned memory access when reading IPv6 header which leads to > segmentation fault by changing aligned memory read to unaligned memory > read. >=20 > Bugzilla ID: 279 > Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") > Cc: maciej.czekaj@caviumnetworks.com > Cc: stable@dpdk.org > Signed-off-by: hgovindh > --- > examples/l3fwd/l3fwd_em.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c > index fa8f82be6..f0c443dae 100644 > --- a/examples/l3fwd/l3fwd_em.c > +++ b/examples/l3fwd/l3fwd_em.c > @@ -285,7 +285,7 @@ em_get_ipv6_dst_port(void *ipv6_hdr, uint16_t > portid, void *lookup_struct) > * Get part of 5 tuple: dst IP address lower 96 bits > * and src IP address higher 32 bits. > */ > - key.xmm[1] =3D *(xmm_t *)data1; > + key.xmm[1] =3D _mm_loadu_si128((xmm_t *)data1); The use of SSE intrinsics on general path will break build on other archite= ctures. How about use em_mask_key() instead? >=20 > /* > * Get part of 5 tuple: dst port and src port > -- > 2.22.0