Re: [dpdk-dev] [PATCH 2/3] cryptodev: remove unused element from device operations

[Ruifeng Wang <Ruifeng.Wang@arm.com>]

> -----Original Message-----
> From: Artur Trybula <arturx.trybula@intel.com>
> Sent: Friday, March 6, 2020 19:17
> To: dev@dpdk.org; pablo.de.lara.guarch@intel.com;
> declan.doherty@intel.com; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> g.singh@nxp.com; ravi1.kumar@amd.com; Akhil.goyal@nxp.com;
> tdu@semihalf.com; anoobj@marvell.com; fiona.trahe@intel.com;
> roy.fan.zhang@intel.com; jianjay.zhou@huawei.com; shallyv@marvell.com;
> arturx.trybula@intel.com
> Subject: [PATCH 2/3] cryptodev: remove unused element from device
> operations
> 
> This commit removes unused function pointer (queue_pair_count) from
> struct rte_cryptodev_ops.
> 
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> ---
>  lib/librte_cryptodev/rte_cryptodev_pmd.h | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h
> b/lib/librte_cryptodev/rte_cryptodev_pmd.h
> index 0e6b5f443..81975d72b 100644
> --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h
> +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h
> @@ -207,15 +207,6 @@ typedef int
> (*cryptodev_queue_pair_setup_t)(struct rte_cryptodev *dev,  typedef int
> (*cryptodev_queue_pair_release_t)(struct rte_cryptodev *dev,
>  		uint16_t qp_id);
> 
> -/**
> - * Get number of available queue pairs of a device.
> - *
> - * @param	dev	Crypto device pointer
> - *
> - * @return	Returns number of queue pairs on success.
> - */
> -typedef uint32_t (*cryptodev_queue_pair_count_t)(struct rte_cryptodev
> *dev);
> -
>  /**
>   * Create a session mempool to allocate sessions from
>   *
> @@ -344,8 +335,6 @@ struct rte_cryptodev_ops {
>  	/**< Set up a device queue pair. */
>  	cryptodev_queue_pair_release_t queue_pair_release;
>  	/**< Release a queue pair. */
> -	cryptodev_queue_pair_count_t queue_pair_count;
> -	/**< Get count of the queue pairs. */
> 
>  	cryptodev_sym_get_session_private_size_t sym_session_get_size;
>  	/**< Return private session. */
> --
> 2.17.1

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>