From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27C00A055E; Wed, 26 Feb 2020 03:47:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7994A1BFAC; Wed, 26 Feb 2020 03:47:15 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00053.outbound.protection.outlook.com [40.107.0.53]) by dpdk.org (Postfix) with ESMTP id 6203D1F1C for ; Wed, 26 Feb 2020 03:47:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g3BEbQcMwIY260oLcfo/eyuUrgWv4rLC9v4CP5pLFSY=; b=y2Dxac7sHb0h1+VNh0Jxg+020/rYRWyvPQ9XztCw8opsy7+trR7L0wG7PCkyM/f5QklAncrN25t2otH3lz7gOwujpL2bI/mtgWxPtCG37OOcUliA1cuKG0+uBwBZgwFCnrnQBaIRZPMsC/euhiZtLLr3w2Bv002tsD+qnOWmdXo= Received: from VI1PR08CA0196.eurprd08.prod.outlook.com (2603:10a6:800:d2::26) by VI1PR0801MB1648.eurprd08.prod.outlook.com (2603:10a6:800:5b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.18; Wed, 26 Feb 2020 02:47:13 +0000 Received: from VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::206) by VI1PR08CA0196.outlook.office365.com (2603:10a6:800:d2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.18 via Frontend Transport; Wed, 26 Feb 2020 02:47:13 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT047.mail.protection.outlook.com (10.152.19.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.17 via Frontend Transport; Wed, 26 Feb 2020 02:47:12 +0000 Received: ("Tessian outbound 0420f1404d58:v42"); Wed, 26 Feb 2020 02:47:12 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0b938db0313c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D8EAC691-6818-41F4-A954-B3FDA55CB2A0.1; Wed, 26 Feb 2020 02:47:07 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0b938db0313c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Feb 2020 02:47:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GIo/l0F0GRG4mbTt1zvBhaPXcbWF0xT4xvunnTOIzBkL2gXp1CZNK6UuVJQen4bLOI9VZVKaxZezZ+tTN+o2DSDNzFFXVfJ5jl1gdcWQX3DAg4lbBJG9Tj1OrxkfwsrcC6OccJG74/1afhP+jjijPTnpH+8vhGax/lT/LEkgq6lRX7iETLA2hGJo3JD1PU3qS1HhvuYIur9mq3Pre2MKysyTb0rIhDVen/92tcSR5aeLXZleoYJAXlbTL+6jhqabKHnWYvlww9UPEdLwBPYOyk21GsMlQ1ZSqE5lsHov3xmoaSkyYzn4zopGDxX7m0BvYAGla+Ljl0QCrFxkqwidbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g3BEbQcMwIY260oLcfo/eyuUrgWv4rLC9v4CP5pLFSY=; b=dfnEsq+zYuCCHZvag9TgzaSh8yQ0OJk/v/2gb5POjliAOVyKa5fTZJWbJJ0UouwOq4Ga3TKWImetE1y7K4mx5q8pai4I3rqpAWHp5HiWwuWLeYYdR5VNZGjDpLctroSk5aiRgesI9xN5PYsNjSQoY/V/X4uIQ74PFHQfBNIUQm31Y1Fhmn3q838LknDsIZRn4l6UIXJFuKkIDHQLV8WVxTZbc5EL7z26CDfuSGxFZE8cFwRs5ux/vF4mL/BDE7kaAPBe+goHcYAR50Aat7Te5k6fmvCpYoVPwSduR75g346yIfdpI7TDHN68ZRbA/oaHHaz6JUhrDei6XVxz3/28+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g3BEbQcMwIY260oLcfo/eyuUrgWv4rLC9v4CP5pLFSY=; b=y2Dxac7sHb0h1+VNh0Jxg+020/rYRWyvPQ9XztCw8opsy7+trR7L0wG7PCkyM/f5QklAncrN25t2otH3lz7gOwujpL2bI/mtgWxPtCG37OOcUliA1cuKG0+uBwBZgwFCnrnQBaIRZPMsC/euhiZtLLr3w2Bv002tsD+qnOWmdXo= Received: from AM0PR08MB3986.eurprd08.prod.outlook.com (20.178.118.90) by AM0PR08MB4548.eurprd08.prod.outlook.com (20.179.34.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.18; Wed, 26 Feb 2020 02:47:05 +0000 Received: from AM0PR08MB3986.eurprd08.prod.outlook.com ([fe80::7cbc:dcc5:f3da:ac56]) by AM0PR08MB3986.eurprd08.prod.outlook.com ([fe80::7cbc:dcc5:f3da:ac56%7]) with mapi id 15.20.2750.021; Wed, 26 Feb 2020 02:47:05 +0000 From: Ruifeng Wang To: Aaron Conole CC: David Marchand , Michael Santana , Bruce Richardson , dev , Gavin Hu , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH v1] ci: add test suite run without hugepage Thread-Index: AQHV663YFFunA/p7g0KHwZKHcVC62qgroK6AgABZ446AAA2aEIAACM9CgAChO3A= Date: Wed, 26 Feb 2020 02:47:05 +0000 Message-ID: References: <20200225073236.135581-1-ruifeng.wang@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: f4b5b08b-0232-476d-92e3-448232e8d161.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5ca5bcb0-72c4-4e8d-fa5d-08d7ba662eb5 X-MS-TrafficTypeDiagnostic: AM0PR08MB4548:|AM0PR08MB4548:|VI1PR0801MB1648: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 0325F6C77B X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(136003)(39860400002)(396003)(376002)(199004)(189003)(81166006)(186003)(8936002)(55236004)(4326008)(7696005)(81156014)(8676002)(76116006)(6916009)(86362001)(33656002)(66556008)(66946007)(478600001)(55016002)(66446008)(26005)(9686003)(64756008)(6506007)(5660300002)(316002)(71200400001)(54906003)(52536014)(66476007)(53546011)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB4548; H:AM0PR08MB3986.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IiigtwrowmIbzKl1IRTGFVU+f466w3u86iZGePbA/9YI0jIi/I7g6iEilI0dsXdOYLFZD1I8ioPHpJKfaldJ5jcbovEY/Qk/U+nGWBnCe236EDnO4eLYMWalle1WPMW3U9qzaXGgFrRFI8EuKdVlzvDytCvczfhdjB1D2ALEBoocOeLfMjBcg/XltuiDAXtVSW5vh+jitSNyulc/KDWa46oy8gYBtdDSh2YPyJ/wGpDDH8w9lDIpshN0fXT/eINbpZndrtAY/PG44iiOajuBo9axao66ztfnQAiNWrFqwz6vyxOMkFQ6V3gnbuHI8L+ahrMs8PjuzQT3XdT8d33k9OBMtaSKuPdq3X3SXrITAoiyccHF82pPXJq2uOLZxlKsYFMf9YPaKtrGBPFy2bGJXsBZ7TZm8MDT0+XxkTCLn1bYX+f9I61nrQnCEPU1nb9K x-ms-exchange-antispam-messagedata: WncTvyoGY1Og1/OBkNbCZuI1/Fs7Lc39p9zuCaa03NjHnZ2juc2NKTAWWE5VJJXYpFVuLNTvO9jQGZwfh6n9rPw0hUWbec8Cvh9VxX+1K2BWCeYQ8Mz55o/2K/U9Yg+SyQDuVfgpMyS7gyYFlzvW8g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4548 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(346002)(376002)(39860400002)(199004)(189003)(53546011)(478600001)(336012)(55016002)(33656002)(6506007)(26826003)(186003)(4326008)(6862004)(9686003)(70206006)(26005)(52536014)(70586007)(2906002)(45080400002)(5660300002)(81166006)(54906003)(316002)(7696005)(86362001)(356004)(81156014)(8676002)(36906005)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0801MB1648; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Pass; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 72bed02e-a6c5-402e-1511-08d7ba662a3c X-Forefront-PRVS: 0325F6C77B X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YoGZESwf/0FwYJyoXKVFVDLQcfVgqZJVzJKr8e5DIwlEEm1mxL069BLGgjls7DVswjMGc5ENNCNfM8GDU6pVbOHpmKkeeZTadU9kJENa+ecfhstJU6pcTwpGDpoAu0WnT9Om1fbsghj2NsGGXLf6HvD6Ur1bDKSMaoDPdmMEXxcr4QxZjXrCMajXzOe30Pu3iH9Yht88GzsJONWPhla6QFkm9zxjcO4PBNYGgMr4pq4MRKpQmAhXu0YZYH8LnxrrTUWP2zjvHgg6UB/F4yfnR4O/NJvdrrrNTH4RdX7EfErmRLizjNbthlaBv6U2cjI7Ofh8BQFR806o29zgGD4W/WdL1DkVl/duGxVwh4lSCVLW6XFqXPqs/Lv0QQDHk++EmnTb5iU4B4Q6tOucIC7N1MVM/TU91iQA1A//TF88Iy+DYqLiE/w1s1e/M6PZ3Uw6 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2020 02:47:12.8312 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ca5bcb0-72c4-4e8d-fa5d-08d7ba662eb5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1648 Subject: Re: [dpdk-dev] [PATCH v1] ci: add test suite run without hugepage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Aaron Conole > Sent: Tuesday, February 25, 2020 23:57 > To: Ruifeng Wang > Cc: David Marchand ; Michael Santana > ; Bruce Richardson > ; dev ; Gavin Hu > ; Honnappa Nagarahalli > ; nd > Subject: Re: [PATCH v1] ci: add test suite run without hugepage >=20 > Ruifeng Wang writes: >=20 > >> -----Original Message----- > >> From: Aaron Conole > >> Sent: Tuesday, February 25, 2020 22:36 > >> To: David Marchand > >> Cc: Ruifeng Wang ; Michael Santana > >> ; Bruce Richardson > >> ; dev ; Gavin Hu > >> ; Honnappa Nagarahalli > >> ; nd > >> Subject: Re: [PATCH v1] ci: add test suite run without hugepage > >> > >> David Marchand writes: > >> > >> > On Tue, Feb 25, 2020 at 8:33 AM Ruifeng Wang > > >> wrote: > >> >> > >> >> This test suite is derived from fast-tests suite. Cases in this > >> >> suite are run with '--no-huge' flag. > >> >> > >> >> The suite aims to cover as many as possible test cases out of the > >> >> fast-tests suites in the environments without huge pages support, > >> >> like containers. > >> >> > >> >> Signed-off-by: Ruifeng Wang > >> >> Reviewed-by: Gavin Hu > >> > > >> > Compilation time is what makes the most of a "tests" job in Travis. > >> > So I'd prefer we avoid adding more jobs for x86_64 (see below). > >> > > >> > > >> >> --- > >> >> .ci/linux-build.sh | 4 +++ > >> >> .travis.yml | 12 +++++++ > >> >> app/test/meson.build | 75 > >> >> ++++++++++++++++++++++++++++++++++++++++++++ > >> >> 3 files changed, 91 insertions(+) > >> >> > >> >> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index > >> >> d500c4c00..39515d915 100755 > >> >> --- a/.ci/linux-build.sh > >> >> +++ b/.ci/linux-build.sh > >> >> @@ -92,3 +92,7 @@ fi > >> >> if [ "$RUN_TESTS" =3D "1" ]; then > >> >> sudo meson test -C build --suite fast-tests -t 3 fi > >> >> + > >> >> +if [ "$RUN_TESTS_NO_HUGE" =3D "1" ]; then > >> >> + sudo meson test -C build --suite nohuge-tests -t 3 fi > >> > > >> > You can replace the "boolean" RUN_TESTS with a TESTSUITES variable > >> > that contains a list of testsuites. > >> > Then this part becomes: > >> > > >> > for testsuite in ${TESTSUITES:-}; do > >> > sudo meson test -C build --suite $testsuite -t 3 done > >> > > >> > (I wonder if we reaaaally need to be root to run those tests w/ and > >> > w/o hugepages, Aaron?) > >> > >> Last I tested, we didn't need root access when not using hugepages > >> (at least for core library functionality). It's possible that the > >> test suites for PMDs might need that access, but we don't run them in = the > travis environment. > >> > >> > > >> >> diff --git a/.travis.yml b/.travis.yml index b64a81bd0..0e07d52d0 > >> >> 100644 > >> >> --- a/.travis.yml > >> >> +++ b/.travis.yml > >> >> @@ -43,6 +43,9 @@ jobs: > >> >> - env: DEF_LIB=3D"shared" RUN_TESTS=3D1 > >> >> arch: amd64 > >> >> compiler: gcc > >> >> + - env: DEF_LIB=3D"shared" RUN_TESTS_NO_HUGE=3D1 > >> >> + arch: amd64 > >> >> + compiler: gcc > >> > > >> > And then we only need to update the existing RUN_TESTS jobs for > x86_64. > >> > >> I like the suggestion. But I guess we'd just make RUN_TESTS=3D1 set > >> TESTSUITES=3D"..." and otherwise, we can have an ARM64 test to do all > >> the test suites. > > It should be OK to do all applicable test suites in a single job? >=20 > Yes, I think so. >=20 > >> > >> Actually, the ideal would be for the tests to automatically SKIP when > >> no hugepages are enabled. > > In this way, case will run either w/ hugepage or w/o hugepage but not > > both. >=20 > Hrrm? I don't understand. If there are hugepages configured, all the te= sts > will run. If there are no hugepages, only the tests that can pass withou= t > hugepages will run. >=20 I was wondering whether it makes sense to do tests with "--no-huge" in envi= ronment where hugepages are enabled. > > It will run faster, but with less coverage? >=20 > Sortof - if there aren't hugepages configured for an environment reason (= like > unsupported) why get failure reports? Better to either fail when we try = to > setup the hugepages, or skip when none are available because they are two > separate concerns. >=20 > >> > >> > > >> >> - env: DEF_LIB=3D"shared" BUILD_DOCS=3D1 > >> >> arch: amd64 > >> >> compiler: gcc > >> >> @@ -66,6 +69,9 @@ jobs: > >> >> - env: DEF_LIB=3D"shared" RUN_TESTS=3D1 > >> >> arch: amd64 > >> >> compiler: clang > >> >> + - env: DEF_LIB=3D"shared" RUN_TESTS_NO_HUGE=3D1 > >> >> + arch: amd64 > >> >> + compiler: clang > >> >> - env: DEF_LIB=3D"shared" BUILD_DOCS=3D1 > >> >> arch: amd64 > >> >> compiler: clang > >> >> @@ -101,6 +107,9 @@ jobs: > >> >> - env: DEF_LIB=3D"static" > >> >> arch: arm64 > >> >> compiler: gcc > >> >> + - env: DEF_LIB=3D"shared" RUN_TESTS_NO_HUGE=3D1 > >> >> + arch: arm64 > >> >> + compiler: gcc > >> >> - env: DEF_LIB=3D"shared" BUILD_DOCS=3D1 > >> >> arch: arm64 > >> >> compiler: gcc > >> >> @@ -124,3 +133,6 @@ jobs: > >> >> - env: DEF_LIB=3D"shared" > >> >> arch: arm64 > >> >> compiler: clang > >> >> + - env: DEF_LIB=3D"shared" RUN_TESTS_NO_HUGE=3D1 > >> >> + arch: arm64 > >> >> + compiler: clang > >> > > >> > > >> > -- > >> > David Marchand