DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis
@ 2020-04-03 12:45 juraj.linkes
  2020-04-03 14:41 ` Aaron Conole
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: juraj.linkes @ 2020-04-03 12:45 UTC (permalink / raw)
  To: aconole, maicolgabriel; +Cc: dev, juraj.linkes

From: "juraj.linkes" <juraj.linkes@pantheon.tech>

libjansson4 is not enough to build telemetry. Replace it with
libjansson-dev.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index fd4f79cfc..2d2292ff6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,7 +15,7 @@ addons:
     update: true
     packages: &required_packages
       - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, ninja-build]
-      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4]
+      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson-dev]
 
 _aarch64_packages: &aarch64_packages
   - *required_packages
-- 
2.11.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis
  2020-04-03 12:45 [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis juraj.linkes
@ 2020-04-03 14:41 ` Aaron Conole
  2020-04-03 15:08 ` Ruifeng Wang
  2020-04-08 12:49 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
  2 siblings, 0 replies; 9+ messages in thread
From: Aaron Conole @ 2020-04-03 14:41 UTC (permalink / raw)
  To: juraj.linkes; +Cc: maicolgabriel, dev

juraj.linkes@pantheon.tech writes:

> From: "juraj.linkes" <juraj.linkes@pantheon.tech>
>
> libjansson4 is not enough to build telemetry. Replace it with
> libjansson-dev.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---

I see that earlier builds would print:

  =================
  Content Skipped
  =================

  libs:
	telemetry:	missing dependency "jansson"


But with this patch, I see that telemetry is included in the built libs.

Thanks for the catch.

Acked-by: Aaron Conole <aconole@redhat.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis
  2020-04-03 12:45 [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis juraj.linkes
  2020-04-03 14:41 ` Aaron Conole
@ 2020-04-03 15:08 ` Ruifeng Wang
  2020-04-08 12:49 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
  2 siblings, 0 replies; 9+ messages in thread
From: Ruifeng Wang @ 2020-04-03 15:08 UTC (permalink / raw)
  To: juraj.linkes, aconole, maicolgabriel; +Cc: dev, nd


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of
> juraj.linkes@pantheon.tech
> Sent: Friday, April 3, 2020 8:46 PM
> To: aconole@redhat.com; maicolgabriel@hotmail.com
> Cc: dev@dpdk.org; juraj.linkes <juraj.linkes@pantheon.tech>
> Subject: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis
> 
> From: "juraj.linkes" <juraj.linkes@pantheon.tech>
> 
> libjansson4 is not enough to build telemetry. Replace it with libjansson-dev.
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index fd4f79cfc..2d2292ff6 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -15,7 +15,7 @@ addons:
>      update: true
>      packages: &required_packages
>        - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, ninja-
> build]
> -      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev,
> libjansson4]
> +      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev,
> + libfdt-dev, libjansson-dev]
> 
>  _aarch64_packages: &aarch64_packages
>    - *required_packages
> --
> 2.11.0

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis
  2020-04-03 12:45 [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis juraj.linkes
  2020-04-03 14:41 ` Aaron Conole
  2020-04-03 15:08 ` Ruifeng Wang
@ 2020-04-08 12:49 ` Juraj Linkeš
  2020-04-08 13:10   ` Aaron Conole
                     ` (2 more replies)
  2 siblings, 3 replies; 9+ messages in thread
From: Juraj Linkeš @ 2020-04-08 12:49 UTC (permalink / raw)
  To: aconole, maicolgabriel; +Cc: dev, Juraj Linkeš

libjansson4 is not enough to build telemetry. Replace it with
libjansson-dev.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index fd4f79cfc..2d2292ff6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,7 +15,7 @@ addons:
     update: true
     packages: &required_packages
       - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, ninja-build]
-      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4]
+      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson-dev]
 
 _aarch64_packages: &aarch64_packages
   - *required_packages
-- 
2.11.0
v2:
* Fix sender to match signoff

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis
  2020-04-08 12:49 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
@ 2020-04-08 13:10   ` Aaron Conole
  2020-04-09  8:00   ` David Marchand
  2020-04-10  8:06   ` David Marchand
  2 siblings, 0 replies; 9+ messages in thread
From: Aaron Conole @ 2020-04-08 13:10 UTC (permalink / raw)
  To: Juraj Linkeš; +Cc: maicolgabriel, dev

Juraj Linkeš <juraj.linkes@pantheon.tech> writes:

> libjansson4 is not enough to build telemetry. Replace it with
> libjansson-dev.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis
  2020-04-08 12:49 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
  2020-04-08 13:10   ` Aaron Conole
@ 2020-04-09  8:00   ` David Marchand
  2020-04-09  9:23     ` Bruce Richardson
  2020-04-10  8:06   ` David Marchand
  2 siblings, 1 reply; 9+ messages in thread
From: David Marchand @ 2020-04-09  8:00 UTC (permalink / raw)
  To: Juraj Linkeš, Bruce Richardson, Ciara Power
  Cc: Aaron Conole, Michael Santana, dev

Hello,

On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
>
> libjansson4 is not enough to build telemetry. Replace it with
> libjansson-dev.

Thanks for the patch Juraj.
Just a little comment, for the v2, there was no significant change and
you could have kept Aaron and Ruifeng review tags.


I just want others' opinion, since there is a work on removing the
dependency on libjansson for telemetry.

This current patch is a fix for the CI, that could be worth
backporting to 19.11.
Hence I am for taking it in master.
Then when the telemetry rework is merged, this rework will remove the
dependency.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis
  2020-04-09  8:00   ` David Marchand
@ 2020-04-09  9:23     ` Bruce Richardson
  2020-04-09  9:30       ` David Marchand
  0 siblings, 1 reply; 9+ messages in thread
From: Bruce Richardson @ 2020-04-09  9:23 UTC (permalink / raw)
  To: David Marchand
  Cc: Juraj Linkeš, Ciara Power, Aaron Conole, Michael Santana, dev

On Thu, Apr 09, 2020 at 10:00:51AM +0200, David Marchand wrote:
> Hello,
> 
> On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
> >
> > libjansson4 is not enough to build telemetry. Replace it with
> > libjansson-dev.
> 
> Thanks for the patch Juraj.
> Just a little comment, for the v2, there was no significant change and
> you could have kept Aaron and Ruifeng review tags.
> 
> 
> I just want others' opinion, since there is a work on removing the
> dependency on libjansson for telemetry.
> 
That would be an end-goal but we are not fully there yet. Even with the
rework some parts of the library for legacy compatibility still depend on
jansson, though the majority of the code will compile without it. Therefore
this dependency should be kept in the CI beyond this release, as we weren't
planning on doing the additional work to completely replace it - though we
can re-evaluate that if people think that it's important to remove the
dependency completely.

/Bruce

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis
  2020-04-09  9:23     ` Bruce Richardson
@ 2020-04-09  9:30       ` David Marchand
  0 siblings, 0 replies; 9+ messages in thread
From: David Marchand @ 2020-04-09  9:30 UTC (permalink / raw)
  To: Bruce Richardson
  Cc: Juraj Linkeš, Ciara Power, Aaron Conole, Michael Santana, dev

On Thu, Apr 9, 2020 at 11:24 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> On Thu, Apr 09, 2020 at 10:00:51AM +0200, David Marchand wrote:
> > I just want others' opinion, since there is a work on removing the
> > dependency on libjansson for telemetry.
> >
> That would be an end-goal but we are not fully there yet. Even with the
> rework some parts of the library for legacy compatibility still depend on
> jansson, though the majority of the code will compile without it. Therefore
> this dependency should be kept in the CI beyond this release, as we weren't
> planning on doing the additional work to completely replace it - though we
> can re-evaluate that if people think that it's important to remove the
> dependency completely.

Ok, thanks for the clarification Bruce.
I will go with this patch.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis
  2020-04-08 12:49 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
  2020-04-08 13:10   ` Aaron Conole
  2020-04-09  8:00   ` David Marchand
@ 2020-04-10  8:06   ` David Marchand
  2 siblings, 0 replies; 9+ messages in thread
From: David Marchand @ 2020-04-10  8:06 UTC (permalink / raw)
  To: Juraj Linkeš
  Cc: Aaron Conole, Michael Santana, dev, Ruifeng Wang (Arm Technology China)

On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
> libjansson4 is not enough to build telemetry. Replace it with
> libjansson-dev.

Fixes: 99889bd85228 ("ci: introduce Travis builds for GitHub repositories")
Cc: stable@dpdk.org

> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

Acked-by: Aaron Conole <aconole@redhat.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>


Applied, thanks.

-- 
David Marchand


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-04-10  8:06 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 12:45 [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis juraj.linkes
2020-04-03 14:41 ` Aaron Conole
2020-04-03 15:08 ` Ruifeng Wang
2020-04-08 12:49 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
2020-04-08 13:10   ` Aaron Conole
2020-04-09  8:00   ` David Marchand
2020-04-09  9:23     ` Bruce Richardson
2020-04-09  9:30       ` David Marchand
2020-04-10  8:06   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).