From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: Aaron Conole <aconole@redhat.com>,
David Marchand <david.marchand@redhat.com>
Cc: Michael Santana <maicolgabriel@hotmail.com>,
Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org>,
Gavin Hu <Gavin.Hu@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v1] ci: add test suite run without hugepage
Date: Tue, 25 Feb 2020 15:39:27 +0000 [thread overview]
Message-ID: <AM0PR08MB3986CC0B5FA4896F7DD08C9D9EED0@AM0PR08MB3986.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <f7t4kveu42o.fsf@dhcp-25.97.bos.redhat.com>
> -----Original Message-----
> From: Aaron Conole <aconole@redhat.com>
> Sent: Tuesday, February 25, 2020 22:36
> To: David Marchand <david.marchand@redhat.com>
> Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>; Michael Santana
> <maicolgabriel@hotmail.com>; Bruce Richardson
> <bruce.richardson@intel.com>; dev <dev@dpdk.org>; Gavin Hu
> <Gavin.Hu@arm.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: Re: [PATCH v1] ci: add test suite run without hugepage
>
> David Marchand <david.marchand@redhat.com> writes:
>
> > On Tue, Feb 25, 2020 at 8:33 AM Ruifeng Wang <ruifeng.wang@arm.com>
> wrote:
> >>
> >> This test suite is derived from fast-tests suite. Cases in this suite
> >> are run with '--no-huge' flag.
> >>
> >> The suite aims to cover as many as possible test cases out of the
> >> fast-tests suites in the environments without huge pages support,
> >> like containers.
> >>
> >> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> >
> > Compilation time is what makes the most of a "tests" job in Travis.
> > So I'd prefer we avoid adding more jobs for x86_64 (see below).
> >
> >
> >> ---
> >> .ci/linux-build.sh | 4 +++
> >> .travis.yml | 12 +++++++
> >> app/test/meson.build | 75
> >> ++++++++++++++++++++++++++++++++++++++++++++
> >> 3 files changed, 91 insertions(+)
> >>
> >> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index
> >> d500c4c00..39515d915 100755
> >> --- a/.ci/linux-build.sh
> >> +++ b/.ci/linux-build.sh
> >> @@ -92,3 +92,7 @@ fi
> >> if [ "$RUN_TESTS" = "1" ]; then
> >> sudo meson test -C build --suite fast-tests -t 3 fi
> >> +
> >> +if [ "$RUN_TESTS_NO_HUGE" = "1" ]; then
> >> + sudo meson test -C build --suite nohuge-tests -t 3 fi
> >
> > You can replace the "boolean" RUN_TESTS with a TESTSUITES variable
> > that contains a list of testsuites.
> > Then this part becomes:
> >
> > for testsuite in ${TESTSUITES:-}; do
> > sudo meson test -C build --suite $testsuite -t 3 done
> >
> > (I wonder if we reaaaally need to be root to run those tests w/ and
> > w/o hugepages, Aaron?)
>
> Last I tested, we didn't need root access when not using hugepages (at least
> for core library functionality). It's possible that the test suites for PMDs might
> need that access, but we don't run them in the travis environment.
>
> >
> >> diff --git a/.travis.yml b/.travis.yml index b64a81bd0..0e07d52d0
> >> 100644
> >> --- a/.travis.yml
> >> +++ b/.travis.yml
> >> @@ -43,6 +43,9 @@ jobs:
> >> - env: DEF_LIB="shared" RUN_TESTS=1
> >> arch: amd64
> >> compiler: gcc
> >> + - env: DEF_LIB="shared" RUN_TESTS_NO_HUGE=1
> >> + arch: amd64
> >> + compiler: gcc
> >
> > And then we only need to update the existing RUN_TESTS jobs for x86_64.
>
> I like the suggestion. But I guess we'd just make RUN_TESTS=1 set
> TESTSUITES="..." and otherwise, we can have an ARM64 test to do all the test
> suites.
It should be OK to do all applicable test suites in a single job?
>
> Actually, the ideal would be for the tests to automatically SKIP when no
> hugepages are enabled.
In this way, case will run either w/ hugepage or w/o hugepage but not both.
It will run faster, but with less coverage?
>
> >
> >> - env: DEF_LIB="shared" BUILD_DOCS=1
> >> arch: amd64
> >> compiler: gcc
> >> @@ -66,6 +69,9 @@ jobs:
> >> - env: DEF_LIB="shared" RUN_TESTS=1
> >> arch: amd64
> >> compiler: clang
> >> + - env: DEF_LIB="shared" RUN_TESTS_NO_HUGE=1
> >> + arch: amd64
> >> + compiler: clang
> >> - env: DEF_LIB="shared" BUILD_DOCS=1
> >> arch: amd64
> >> compiler: clang
> >> @@ -101,6 +107,9 @@ jobs:
> >> - env: DEF_LIB="static"
> >> arch: arm64
> >> compiler: gcc
> >> + - env: DEF_LIB="shared" RUN_TESTS_NO_HUGE=1
> >> + arch: arm64
> >> + compiler: gcc
> >> - env: DEF_LIB="shared" BUILD_DOCS=1
> >> arch: arm64
> >> compiler: gcc
> >> @@ -124,3 +133,6 @@ jobs:
> >> - env: DEF_LIB="shared"
> >> arch: arm64
> >> compiler: clang
> >> + - env: DEF_LIB="shared" RUN_TESTS_NO_HUGE=1
> >> + arch: arm64
> >> + compiler: clang
> >
> >
> > --
> > David Marchand
next prev parent reply other threads:[~2020-02-25 15:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 7:32 Ruifeng Wang
2020-02-25 9:14 ` David Marchand
2020-02-25 14:36 ` Aaron Conole
2020-02-25 15:39 ` Ruifeng Wang [this message]
2020-02-25 15:56 ` Aaron Conole
2020-02-26 2:47 ` Ruifeng Wang
2020-02-25 15:23 ` Ruifeng Wang
2020-02-28 4:19 ` [dpdk-dev] [PATCH v2 0/2] no-huge test suite Ruifeng Wang
2020-02-28 4:19 ` [dpdk-dev] [PATCH v2 1/2] ci: allow multiple test suites to run in one job Ruifeng Wang
2020-02-28 4:19 ` [dpdk-dev] [PATCH v2 2/2] ci: add test suite run without hugepage Ruifeng Wang
2020-03-04 17:31 ` Aaron Conole
2020-03-05 3:41 ` Ruifeng Wang
2020-03-05 14:36 ` Aaron Conole
2020-03-06 8:09 ` Ruifeng Wang
2020-03-06 15:56 ` Aaron Conole
2020-03-06 16:05 ` David Marchand
2020-03-06 16:16 ` Aaron Conole
2020-03-06 16:33 ` Bruce Richardson
2020-03-07 14:36 ` Ruifeng Wang
2020-03-12 7:13 ` Juraj Linkeš
2020-03-12 8:33 ` Ruifeng Wang
2020-03-13 8:16 ` [dpdk-dev] [PATCH v3 0/4] no-huge unit test Ruifeng Wang
2020-03-13 8:16 ` [dpdk-dev] [PATCH v3 1/4] test: enable tests to run in no-huge mode Ruifeng Wang
2020-03-17 12:49 ` Aaron Conole
2020-03-17 19:15 ` Wang, Yipeng1
2020-03-13 8:16 ` [dpdk-dev] [PATCH v3 2/4] ci: generate fast-tests suite base on hugepage availability Ruifeng Wang
2020-03-17 12:50 ` Aaron Conole
2020-03-23 8:56 ` David Marchand
2020-03-23 9:32 ` David Marchand
2020-03-23 15:50 ` Ruifeng Wang
2020-03-28 16:17 ` David Marchand
2020-03-30 16:03 ` Ruifeng Wang
2020-04-10 12:25 ` David Marchand
2020-03-23 15:36 ` Ruifeng Wang
2020-03-13 8:16 ` [dpdk-dev] [PATCH v3 3/4] ci: proceed with verification without hugepage Ruifeng Wang
2020-03-17 12:50 ` Aaron Conole
2020-03-13 8:16 ` [dpdk-dev] [PATCH v3 4/4] ci: enable unit test for aarch64 Ruifeng Wang
2020-03-17 12:50 ` Aaron Conole
2020-03-13 12:48 ` [dpdk-dev] [PATCH v3 0/4] no-huge unit test Aaron Conole
2020-03-13 13:04 ` Aaron Conole
2020-03-13 15:54 ` David Marchand
2020-03-16 8:27 ` Ruifeng Wang
2020-03-16 13:25 ` Aaron Conole
2020-03-16 14:13 ` Aaron Conole
2020-03-16 14:41 ` Bruce Richardson
2020-03-17 17:02 ` dwilder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR08MB3986CC0B5FA4896F7DD08C9D9EED0@AM0PR08MB3986.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).