From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C3F2A046B for ; Fri, 28 Jun 2019 04:44:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 605DA2BB5; Fri, 28 Jun 2019 04:44:57 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00059.outbound.protection.outlook.com [40.107.0.59]) by dpdk.org (Postfix) with ESMTP id 160631E2F for ; Fri, 28 Jun 2019 04:44:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=testarcselector01; d=microsoft.com; cv=none; b=iY6E3FtdkKYmtTUCHZTebD+pHpJogd4E0yZcqx7s2U3GDqEya8JoxRQW/ca/41n0iSb6r93zC6E4Ka9X8YeAQmkYPzrywwYwuIIc4Id9Vs6PqZr08J/e8lAmMUrQ4GEXPkvpbjij1acqI/TnkGopLOdAjWv7r8EgxyYaf6Aw1+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=testarcselector01; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FaMd+pMplHfa4VVB7Ub0vrykDBV8EbbXQS0g35vITqU=; b=H84WtRR3IB2Iwp7SSJWyXRMT2kRC0FOURdpgbgHsn7tO6gU53awCfR/qOaDrPD6+HYvBwx9wm2pRks3vW6jyzQqw41e+nb/8iz5Piuk9nEHZ6ZY6jniJvokaD8qSiVIyKKxshJlMac3H9ApC7/pfbcB8NzLp7c9n6ROyfEjnK0I= ARC-Authentication-Results: i=1; test.office365.com 1;spf=none;dmarc=none;dkim=none;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FaMd+pMplHfa4VVB7Ub0vrykDBV8EbbXQS0g35vITqU=; b=VQy3lC6HD7aSfsnVDa3k5nx25l9vWT1ufq2QZw/L8RgBOHxANYVRw74fGKIndGHF79r8TZ0uUYbZxs5tUPSpdeJn7QiDp+Lgqyl6iET1HC7JZhAaJoJIgU+GOpd/+jzRMKJ35PSf0EtkAxxlaB5ezOa8mUipoAVhcWRG4WdnVow= Received: from AM0PR08MB4418.eurprd08.prod.outlook.com (20.179.35.207) by AM0PR08MB4371.eurprd08.prod.outlook.com (20.179.34.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Fri, 28 Jun 2019 02:44:54 +0000 Received: from AM0PR08MB4418.eurprd08.prod.outlook.com ([fe80::3582:a8b6:2af4:a6d]) by AM0PR08MB4418.eurprd08.prod.outlook.com ([fe80::3582:a8b6:2af4:a6d%3]) with mapi id 15.20.2008.014; Fri, 28 Jun 2019 02:44:54 +0000 From: "Ruifeng Wang (Arm Technology China)" To: Stephen Hemminger CC: "bruce.richardson@intel.com" , "vladimir.medvedkin@intel.com" , "dev@dpdk.org" , Honnappa Nagarahalli , "Gavin Hu (Arm Technology China)" , nd , nd Thread-Topic: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions Thread-Index: AQHVLMwV0WqbgHJxDE+UVV0PVSn4MKavn1SAgACuGHA= Date: Fri, 28 Jun 2019 02:44:54 +0000 Message-ID: References: <20190627093751.7746-1-ruifeng.wang@arm.com> <20190627082451.56719392@hermes.lan> In-Reply-To: <20190627082451.56719392@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0335c793-54c4-49ce-8ab6-1d1d3340dfee.0 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aabb5bf3-77f5-4169-19ce-08d6fb729a07 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR08MB4371; x-ms-traffictypediagnostic: AM0PR08MB4371: x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 00826B6158 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(366004)(39860400002)(396003)(346002)(13464003)(199004)(189003)(74316002)(305945005)(8936002)(81166006)(86362001)(54906003)(14454004)(99286004)(9686003)(229853002)(6436002)(7696005)(26005)(72206003)(6116002)(3846002)(7736002)(25786009)(6916009)(53936002)(6246003)(81156014)(71190400001)(71200400001)(33656002)(66556008)(476003)(68736007)(8676002)(52536014)(55016002)(76116006)(316002)(66946007)(486006)(53546011)(66476007)(73956011)(66446008)(102836004)(76176011)(5660300002)(446003)(64756008)(66066001)(2906002)(55236004)(478600001)(186003)(256004)(11346002)(6506007)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB4371; H:AM0PR08MB4418.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: f080prP+6bHuxK01sRIoKdrUU32fSx1xmqqiTLgxsSKbE74afB5sqcVzHOFsKTJkxvFjLRt/1R7po9xAz8cGnZ4cxOFRmvpjnvYHZPmIPy2V3W9DhXCg5IU00a+9U8422fCPTns1HMoJhJ7uj1XaJ5CTkcVzQYy06ifD4FJkt9nPBbe+MhiVyIlkhW/AFkEIjryOlGsjLdwtib73BwMAOoKV99q2YXuQRJn55k/pYehIooUkjzF4lBlnvZbdJRkEDsq5wAsmn1f4DXmkjBColpQUMBdPpfT9ODSh4qn5CIqMi7jXXfre8ipWHcyEkGKM4NmSrSvLUIOo5qVWKdZg251xDIDWjNo/O49K5vba8//web5Ku80l8YY7wtDaHoQ9WnNZzcz0iZoK/Ei8mqJStK3NeSdBJ2hQaLETwdtsy10= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: aabb5bf3-77f5-4169-19ce-08d6fb729a07 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2019 02:44:54.7494 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ruifeng.Wang@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4371 Subject: Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, June 27, 2019 23:25 > To: Ruifeng Wang (Arm Technology China) > Cc: bruce.richardson@intel.com; vladimir.medvedkin@intel.com; > dev@dpdk.org; Honnappa Nagarahalli ; > Gavin Hu (Arm Technology China) ; nd > Subject: Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary > functions >=20 > On Thu, 27 Jun 2019 17:37:49 +0800 > Ruifeng Wang wrote: >=20 > > Tests showed that the function inlining caused performance drop on > > some x86 platforms with the memory ordering patches applied. > > By force no-inline functions, the performance was better than before > > on x86 and no impact to arm64 platforms. > > > > Suggested-by: Medvedkin Vladimir > > Signed-off-by: Ruifeng Wang > > Reviewed-by: Gavin Hu > { >=20 > Do you actually need to force noinline or is just taking of inline enough= ? > In general, letting compiler decide is often best practice. The force noinline is an optimization for x86 platforms to keep rte_lpm_add= () API performance with memory ordering applied.=20